From 07209a4732447f9d462a2c3388c9a16bf32f2506 Mon Sep 17 00:00:00 2001 From: gsxdsm Date: Thu, 25 Jun 2026 22:10:59 -0700 Subject: [PATCH] FN-7045: capitalize Code Review step name Normalize the built-in Code Review workflow label and cover the display-name invariant. - Rename the compound-engineering built-in code-review node to "Code Review". - Add regression coverage that rejects lowercase built-in Code review node names. - Add a patch changeset for the published CLI package. Files changed: .changeset/fn-7045-code-review-step-name.md | 7 +++++++ packages/core/src/__tests__/builtin-workflows.test.ts | 9 +++++++++ packages/core/src/builtin-workflows.ts | 6 +++++- 3 files changed, 21 insertions(+), 1 deletion(-) Fusion-Task-Id: FN-7045 Fusion-Task-Lineage: 4608df38-dc5f-4d16-b33e-9f4ce00fe96d --- .changeset/fn-7045-code-review-step-name.md | 7 +++++++ packages/core/src/__tests__/builtin-workflows.test.ts | 9 +++++++++ packages/core/src/builtin-workflows.ts | 6 +++++- 3 files changed, 21 insertions(+), 1 deletion(-) create mode 100644 .changeset/fn-7045-code-review-step-name.md diff --git a/.changeset/fn-7045-code-review-step-name.md b/.changeset/fn-7045-code-review-step-name.md new file mode 100644 index 0000000000..554a1a46e1 --- /dev/null +++ b/.changeset/fn-7045-code-review-step-name.md @@ -0,0 +1,7 @@ +--- +"@runfusion/fusion": patch +--- + +summary: Capitalize the built-in Code Review step name consistently. +category: fix +dev: Updates the compound-engineering built-in workflow node display name and regression coverage. diff --git a/packages/core/src/__tests__/builtin-workflows.test.ts b/packages/core/src/__tests__/builtin-workflows.test.ts index 87f3962dcc..7ecf0007a7 100644 --- a/packages/core/src/__tests__/builtin-workflows.test.ts +++ b/packages/core/src/__tests__/builtin-workflows.test.ts @@ -39,6 +39,14 @@ describe("built-in workflows", () => { } }); + it("does not expose lowercase Code review step names in built-in workflow nodes", () => { + for (const workflow of BUILTIN_WORKFLOWS) { + for (const node of workflow.ir.nodes) { + expect(node.config?.name, `${workflow.id}:${node.id}`).not.toBe("Code review"); + } + } + }); + it("includes the stepwise coding built-in modeling step inversion (KTD-9)", () => { const stepwise = getBuiltinWorkflow("builtin:stepwise-coding"); expect(stepwise).toBeDefined(); @@ -459,6 +467,7 @@ describe("built-in workflows", () => { const codeReview = byId("code-review"); expect(codeReview?.kind).toBe("gate"); + expect(codeReview?.config?.name).toBe("Code Review"); expect(codeReview?.config?.skillName).toBe("compound-engineering:ce-code-review"); expect(codeReview?.config?.gateMode).toBe("gate"); expect(codeReview?.config?.toolMode).toBe("coding"); diff --git a/packages/core/src/builtin-workflows.ts b/packages/core/src/builtin-workflows.ts index 5b32fafe80..d0e2844c49 100644 --- a/packages/core/src/builtin-workflows.ts +++ b/packages/core/src/builtin-workflows.ts @@ -216,7 +216,11 @@ export const BUILTIN_WORKFLOWS: WorkflowDefinition[] = [ id: "code-review", kind: "gate", config: { - name: "Code review", + /* + * FNXC:Workflows 2026-06-25-00:00: + * FN-7045 requires every built-in code-review step display name to be title-case "Code Review" so compound-engineering matches WORKFLOW_STEP_TEMPLATES and the optional Code Review group. + */ + name: "Code Review", executor: "skill", skillName: "compound-engineering:ce-code-review", gateMode: "gate",