From 0771c34b0bfb20f17292c0eab2b018aef1967edb Mon Sep 17 00:00:00 2001
From: gsxdsm <gsxdsm@users.noreply.github.com>
Date: Thu, 2 Jul 2026 23:31:15 -0700
Subject: [PATCH] fix(dashboard): mark GitHub onboarding step done when
 authenticated via gh CLI
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On the GitHub onboarding step, when GitHub is authenticated via the gh CLI (no OAuth provider),
the "Continue with gh CLI auth" button called setStep("project-setup") directly, skipping the
completion bookkeeping — so "github" was never added to completedSteps and step 2 never checked
off in the progress indicator. Advance via handleNext when ready via gh CLI (marks the step
completed) and via handleSkip when GitHub isn't connected (marks it skipped).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---
 .../dashboard/app/components/ModelOnboardingModal.tsx  | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/packages/dashboard/app/components/ModelOnboardingModal.tsx b/packages/dashboard/app/components/ModelOnboardingModal.tsx
index 9261e2e103..b2292ef156 100644
--- a/packages/dashboard/app/components/ModelOnboardingModal.tsx
+++ b/packages/dashboard/app/components/ModelOnboardingModal.tsx
@@ -2668,7 +2668,15 @@ export function ModelOnboardingModal({
                   <div className="model-onboarding-github-optional__actions">
                     <button
                       className="btn btn-primary btn-sm"
-                      onClick={() => setStep("project-setup")}
+                      /*
+                       * FNXC:Onboarding 2026-07-03-08:00:
+                       * Advance via handleNext/handleSkip (not a raw setStep) so the GitHub step's
+                       * status is recorded. When GitHub is ready via the gh CLI, "Continue with gh CLI
+                       * auth" must COMPLETE the step (handleNext) — previously it jumped to project-setup
+                       * without adding "github" to completedSteps, so step 2 never checked off. When
+                       * GitHub isn't connected, "Continue without GitHub" is a SKIP (handleSkip).
+                       */
+                      onClick={isGitHubReadyViaCli ? handleNext : handleSkip}
                     >
                       {isGitHubReadyViaCli
                         ? t("setup.continueWithGhCli", "Continue with gh CLI auth →")