root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(FN-2948): merge fusion/fn-2948

Browse Source 
- feat(FN-2948): complete Step 5 — apply review feedback and finalize delivery
- test(FN-2948): complete Step 3 — update insights section visibility coverage
- feat(FN-2948): complete Step 2 — enhance insight item readability
- feat(FN-2948): complete Step 1 — hide empty insight sections
- feat(FN-2939): merge fusion/fn-2939
- feat(FN-2946): merge fusion/fn-2946

Fusion-Task-Id: FN-2948
This commit is contained in:
Fusion
2026-04-29 02:41:27 -07:00
committed by gsxdsm
parent e891a05950
commit 09cf8ccdb7
4 changed files with 257 additions and 110 deletions
Download Patch File Download Diff File Expand all files Collapse all files

122
packages/dashboard/app/components/InsightsView.tsx
View File

@@ -164,72 +164,66 @@ export function InsightsView({ projectId, addToast, onClose, onCreateTask }: Ins
</div>
<div className="insights-section-content">
{section.items.length === 0 ? (
<div className="insights-empty-section" data-testid={`insights-empty-${section.category}`}>
<p>No insights in this category</p>
</div>
) : (
<ul className="insights-list">
{section.items.map((insight) => {
const dismissState = dismissStates.get(insight.id);
const createState = createTaskStates.get(insight.id);
const isDismissInFlight = dismissState?.running ?? false;
const isCreateInFlight = createState?.running ?? false;
<ul className="insights-list">
{section.items.map((insight) => {
const dismissState = dismissStates.get(insight.id);
const createState = createTaskStates.get(insight.id);
const isDismissInFlight = dismissState?.running ?? false;
const isCreateInFlight = createState?.running ?? false;
return (
<li key={insight.id} className="insight-item" data-insight-id={insight.id}>
<div className="insight-item-header">
<h4 className="insight-item-title">{insight.title}</h4>
<div className="insight-item-actions">
<button
className="btn btn-sm btn-icon"
onClick={() => void handleCreateTask(insight.id, insight.title)}
disabled={isCreateInFlight || isAnyActionInFlight}
title="Create task from this insight"
aria-label="Create task from this insight"
data-testid={`create-task-${insight.id}`}
>
{isCreateInFlight ? (
<RefreshCw size={14} className="spin" />
) : (
<Plus size={14} />
)}
</button>
<button
className="btn btn-sm btn-icon"
onClick={() => void handleDismiss(insight.id, insight.title)}
disabled={isDismissInFlight || isAnyActionInFlight}
title="Dismiss this insight"
aria-label="Dismiss this insight"
data-testid={`dismiss-${insight.id}`}
>
{isDismissInFlight ? (
<RefreshCw size={14} className="spin" />
) : (
<X size={14} />
)}
</button>
</div>
return (
<li key={insight.id} className="insight-item" data-insight-id={insight.id}>
<div className="insight-item-header">
<h4 className="insight-item-title">{insight.title}</h4>
<div className="insight-item-actions">
<button
className="btn btn-sm btn-icon"
onClick={() => void handleCreateTask(insight.id, insight.title)}
disabled={isCreateInFlight || isAnyActionInFlight}
title="Create task from this insight"
aria-label="Create task from this insight"
data-testid={`create-task-${insight.id}`}
>
{isCreateInFlight ? (
<RefreshCw size={14} className="spin" />
) : (
<Plus size={14} />
)}
</button>
<button
className="btn btn-sm btn-icon"
onClick={() => void handleDismiss(insight.id, insight.title)}
disabled={isDismissInFlight || isAnyActionInFlight}
title="Dismiss this insight"
aria-label="Dismiss this insight"
data-testid={`dismiss-${insight.id}`}
>
{isDismissInFlight ? (
<RefreshCw size={14} className="spin" />
) : (
<X size={14} />
)}
</button>
</div>
{insight.content && (
<p className="insight-item-content">{insight.content}</p>
)}
<div className="insight-item-meta">
<span className={`insight-item-status insight-item-status--${insight.status}`}>
{insight.status}
</div>
{insight.content && (
<p className="insight-item-content">{insight.content}</p>
)}
<div className="insight-item-meta">
<span className={`insight-item-status insight-item-status--${insight.status}`}>
{insight.status}
</span>
{insight.createdAt && (
<span className="insight-item-date">
<Clock size={12} />
{new Date(insight.createdAt).toLocaleDateString()}
</span>
{insight.createdAt && (
<span className="insight-item-date">
<Clock size={12} />
{new Date(insight.createdAt).toLocaleDateString()}
</span>
)}
</div>
</li>
);
})}
</ul>
)}
)}
</div>
</li>
);
})}
</ul>
</div>
</section>
);
@@ -355,7 +349,7 @@ export function InsightsView({ projectId, addToast, onClose, onCreateTask }: Ins
</div>
) : (
<div className="insights-sections">
{sections.map(renderSection)}
{sections.filter((section) => section.items.length > 0).map(renderSection)}
</div>
)}
</div>