feat(KB-141): fix workspace type resolution and add clean-checkout typecheck tests

- Remove dist-dependent workspace type resolution from all tsconfig files

- Add clean-checkout typecheck regression test to CI suite

- Update package.json type definitions for core, engine, dashboard, and cli packages

- Update README with typecheck testing documentation

- Clean up unused test files and component dependencies

packages/engine/package.json

@@ -4,8 +4,8 @@
   "type": "module",
   "exports": {
     ".": {
-      "import": "./dist/index.js",
-      "types": "./dist/index.d.ts"
+      "types": "./src/index.ts",
+      "import": "./dist/index.js"
     }
   },
   "publishConfig": {

packages/engine/src/notifier.ts

@@ -1,4 +1,5 @@
 import type { TaskStore, Task, Column, Settings, MergeResult } from "@kb/core";
+import { EventEmitter } from "node:events";
 import { schedulerLog } from "./logger.js";
 
 export interface NtfyNotifierOptions {
@@ -6,6 +7,13 @@ export interface NtfyNotifierOptions {
   ntfyBaseUrl?: string;
 }
 
+/** Minimal store interface needed by NtfyNotifier */
+interface NtfyNotifierStore {
+  getSettings(): Promise<Settings> | Settings;
+  on(event: string, listener: (...args: any[]) => void): void;
+  off(event: string, listener: (...args: any[]) => void): void;
+}
+
 interface NtfyConfig {
   enabled: boolean;
   topic: string | undefined;
@@ -34,7 +42,7 @@ export class NtfyNotifier {
   private abortController: AbortController | null = null;
 
   constructor(
-    private store: TaskStore,
+    private store: NtfyNotifierStore,
     options: NtfyNotifierOptions = {},
   ) {
     this.ntfyBaseUrl = options.ntfyBaseUrl ?? "https://ntfy.sh";

packages/engine/src/pr-comment-handler.test.ts

@@ -1,10 +1,10 @@
 import { describe, it, expect, vi, beforeEach } from "vitest";
 import { PrCommentHandler } from "./pr-comment-handler.js";
-import type { TaskStore } from "@kb/core";
+import type { TaskStore, Task } from "@kb/core";
 
 const mockStore = {
-  addSteeringComment: vi.fn(),
-  createTask: vi.fn().mockResolvedValue({ id: "KB-123" }),
+  addSteeringComment: vi.fn<(id: string, text: string, author?: "user" | "agent") => Promise<Task>>(),
+  createTask: vi.fn<(input: Parameters<TaskStore["createTask"]>[0]) => Promise<Task>>().mockResolvedValue({ id: "KB-123" } as Task),
 } as unknown as TaskStore;
 
 describe("PrCommentHandler", () => {
@@ -126,7 +126,7 @@ describe("PrCommentHandler", () => {
         },
       ]);
 
-      const call = mockStore.addSteeringComment.mock.calls[0];
+      const call = (mockStore.addSteeringComment as ReturnType<typeof vi.fn>).mock.calls[0];
       const text = call[1] as string;
 
       expect(text).toContain("PR Review Feedback");
@@ -151,7 +151,7 @@ describe("PrCommentHandler", () => {
         },
       ]);
 
-      const call = mockStore.addSteeringComment.mock.calls[0];
+      const call = (mockStore.addSteeringComment as ReturnType<typeof vi.fn>).mock.calls[0];
       const text = call[1] as string;
 
       expect(text.length).toBeLessThan(longBody.length);
@@ -189,7 +189,7 @@ describe("PrCommentHandler", () => {
         },
       ]);
 
-      const text = mockStore.addSteeringComment.mock.calls[0][1] as string;
+      const text = (mockStore.addSteeringComment as ReturnType<typeof vi.fn>).mock.calls[0][1] as string;
       expect(text).toContain("This PR is already merged");
       expect(text).toContain("follow-up work");
     });
@@ -242,7 +242,7 @@ describe("PrCommentHandler", () => {
         },
       ]);
 
-      const call = mockStore.createTask.mock.calls[0];
+      const call = (mockStore.createTask as ReturnType<typeof vi.fn>).mock.calls[0];
       const description = call[0].description as string;
 
       expect(description).toContain("@reviewer1");

packages/engine/tsconfig.json

@@ -2,8 +2,8 @@
   "extends": "../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "dist",
-    "rootDir": "src"
+    "rootDir": "src",
+    "types": ["node", "vitest/globals"]
   },
-  "include": ["src"],
-  "exclude": ["src/**/*.test.ts"]
+  "include": ["src/**/*"]
 }