FN-6445: reject quality skip-list overlaps
Prevent dashboard curated skip-list entries from masking tests already covered by quality projects. - Add validation that flags skip-list files included by quality lanes. - Cover overlap, empty-reason overlap, and genuine orphan cases in inventory tests. - Document that skip-lists are only for genuinely non-executed dashboard tests. Files changed: docs/testing.md | 1 + scripts/__tests__/check-test-inventory.test.mjs | 29 ++++++++++++++++++++++--- scripts/check-test-inventory.mjs | 9 ++++++++ 3 files changed, 36 insertions(+), 3 deletions(-) Fusion-Task-Id: FN-6445 Fusion-Task-Lineage: 1741f684-8dfc-41fc-8f30-baa3700ac11b
This commit is contained in:
@@ -102,6 +102,7 @@ every entry needs a non-empty `reason` (empty reasons are rejected). Skip-list p
|
||||
fail in isolation) and `build-output.test.ts` (runs standalone via `test:build`
|
||||
after a Vite build). Each carries a one-line reason.
|
||||
- <!-- FNXC:DashboardTesting 2026-06-14-08:00: Skip-listed dashboard tests need actionable ownership; placeholder IDs block rescue/delete follow-through, so every non-standalone reason cites a concrete Fusion tracking task. --> Every skip-list `reason` for a pre-existing failing/orphaned test must reference a concrete `FN-NNNN` tracking task; if the test is rescued, remove the entry instead of leaving a tracking placeholder.
|
||||
- <!-- FNXC:DashboardTesting 2026-06-14-10:27: FN-6445 closes the useChatRooms.test.ts tracking drift from FN-6442: a skip-list entry that is already matched by any quality project is not a genuine ungated orphan and would overstate the orphan count. --> The guard rejects any skip-list entry whose file is already executed by a quality project. Remove the entry instead; the skip-list is only for genuinely non-executed files.
|
||||
- To remove a file from the skip-list: fix the test, confirm it passes under its
|
||||
project, delete the skip-list entry. The backfill lane then executes it.
|
||||
- The skip-list is shared verbatim with `vitest.config.ts`, which excludes the same
|
||||
|
||||
Reference in New Issue
Block a user