From 141f54e51d0a20bc36acc5edcdcb3ef2bb1843db Mon Sep 17 00:00:00 2001 From: gsxdsm Date: Fri, 31 Jul 2026 03:16:16 -0700 Subject: [PATCH] =?UTF-8?q?chore(core):=20mark=20the=20agent-store=20statu?= =?UTF-8?q?s=20formatter=20DELIBERATE-LITERAL=20(census=20101=E2=86=9299)?= =?UTF-8?q?=20(#3063)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fleet phase. `packages/core/src/agent-store.ts` was the **last** census file with no branch, worktree, or open PR against it. Claim published by pushing the branch before starting. ## Census before / after | | total | this file | |---|---|---| | before | **101** | 2 | | after | **99** | 0 | `--strict` exits 0, baseline re-recorded. **Reclassification, not conversion** — the line is unchanged. ## Already decided, in prose the census cannot read The site was flagged earlier today by another pass, as `FLAGGED AND LEFT COUNTED`: a pure formatter over `Pick` with no store and no task id, whose output is a human-readable status line. On a renamed board it falls through to `()` — still accurate, just less specific. Converting it would mean threading a lane resolution into a string builder. That reasoning is right and I did not revisit it. The only gap was mechanical: a prose note is invisible to the tool, so the site kept reading as backlog. ## This completes the sweep of unclaimed files Third and last of these. Together with #3056 (fallback arms) and #3060 (dead sync path), **every census file that was unclaimed this phase has now been examined, and not one of them needed a conversion.** Each was either a three-state fallback arm — where the legacy id is the answer when resolution fails, and removing it would break the caller — or a site a previous pass had already reviewed and deliberately kept. That is the finding worth carrying forward. The remaining **99** is not a work queue: a meaningful share is correct code the tool cannot distinguish from owed work, and every fleet pass pays to re-derive it. Since all workers rank by the same `byFile` output, we also converge on the same top file — which is how `self-healing.ts` drew three parallel conversions, two of which are now unmergeable. Two cheap changes would fix both symptoms: 1. **Mark reviewed-and-kept sites** so the count means *conversions owed*. Two lines each. 2. **Push the branch at claim time** so `git ls-remote` is authoritative before work starts. Costs nothing; I did it for all three of these. ## Verification - `census --strict` exit 0; `tsc --noEmit` **0 errors** - `check:fnxc-future-dates`, `check:lane-wiring` — exit 0 - Comment-only diff; no behaviour change Co-authored-by: Claude Opus 5 (1M context) --- packages/core/src/agent-store.ts | 3 +++ scripts/lib/lifecycle-column-census-baseline.json | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/core/src/agent-store.ts b/packages/core/src/agent-store.ts index 71470ed796..b2b6c8fc0e 100644 --- a/packages/core/src/agent-store.ts +++ b/packages/core/src/agent-store.ts @@ -226,6 +226,9 @@ export function formatCurrentTaskLine(taskId: string, linkedTask: Pick` — no store, no task id, and its output PRINTS the column name for a human reader. Same class as `github-tracking-comments.ts:165` and `in-process-runtime`'s duration helpers: threading a resolution into a string builder to pick a word is diff --git a/scripts/lib/lifecycle-column-census-baseline.json b/scripts/lib/lifecycle-column-census-baseline.json index 247f84f264..8a883195ad 100644 --- a/scripts/lib/lifecycle-column-census-baseline.json +++ b/scripts/lib/lifecycle-column-census-baseline.json @@ -4,7 +4,6 @@ "packages/engine/src/self-healing.ts": 38, "packages/engine/src/notification/notification-service.ts": 5, "packages/engine/src/executor.ts": 4, - "packages/core/src/agent-store.ts": 2, "packages/core/src/task-store/moves.ts": 2, "packages/core/src/task-store/project-store-ops.ts": 2, "packages/core/src/task-store/reads.ts": 2, @@ -65,6 +64,8 @@ "packages/cli/src/commands/task.ts\u0000done": 1, "packages/cli/src/extension.ts\u0000archived": 1, "packages/cli/src/extension.ts\u0000done": 1, + "packages/core/src/agent-store.ts\u0000archived": 1, + "packages/core/src/agent-store.ts\u0000done": 1, "packages/core/src/async-mission-store-queries.ts\u0000archived": 1, "packages/core/src/async-mission-store-queries.ts\u0000done": 1, "packages/core/src/live-agent-count.ts\u0000archived": 1,