From 23dd0fcdf4bf9d4f687213b60bbed27c83d8f1da Mon Sep 17 00:00:00 2001 From: gsxdsm Date: Fri, 10 Jul 2026 21:23:17 -0700 Subject: [PATCH] test: fix stale refinement-title assertions after FN-7165 Two store-comments refinement tests located the auto-created refinement task by `title.includes("Refinement")`, but FN-7165 (34efa8b89) intentionally changed refinement titles to `${sourceId}: ${feedback}` for traceability. The refinement task is still created correctly (the length assertion passes); only the identifying substring was stale, so the tests failed on `expect(refinement) .toBeDefined()`. Match the refinement by its feedback-derived title instead. No product behavior change. Co-Authored-By: Claude Opus 4.8 --- packages/core/src/__tests__/store-comments.test.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/core/src/__tests__/store-comments.test.ts b/packages/core/src/__tests__/store-comments.test.ts index 88bfb90915..6b5d6f064e 100644 --- a/packages/core/src/__tests__/store-comments.test.ts +++ b/packages/core/src/__tests__/store-comments.test.ts @@ -207,7 +207,9 @@ describe("TaskStore", () => { const allTasksAfter = await store.listTasks(); expect(allTasksAfter).toHaveLength(allTasksBefore.length + 1); - const refinement = allTasksAfter.find((t) => t.id !== task.id && t.title?.includes("Refinement")); + // FN-7165 titles refinements as `${sourceId}: ${feedback}` (not "Refinement …"), + // so identify the new task by its feedback-derived title. + const refinement = allTasksAfter.find((t) => t.id !== task.id && t.title?.includes("Need to fix edge case")); expect(refinement).toBeDefined(); expect(refinement?.column).toBe("triage"); expect(refinement?.dependencies).toContain(task.id); @@ -572,7 +574,9 @@ describe("TaskStore", () => { const allTasksAfter = await store.listTasks(); expect(allTasksAfter).toHaveLength(allTasksBefore.length + 1); - const refinement = allTasksAfter.find((t) => t.id !== task.id && t.title?.includes("Refinement")); + // FN-7165 titles refinements as `${sourceId}: ${feedback}` (not "Refinement …"), + // so identify the new task by its feedback-derived title. + const refinement = allTasksAfter.find((t) => t.id !== task.id && t.title?.includes("Need to fix edge case")); expect(refinement).toBeDefined(); });