root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(FN-4647): complete Step 2 — clarify done-task fallback semantics

Browse Source 
Fusion-Task-Id: FN-4647
Fusion-Task-Lineage: c86304d4-ff28-478a-a254-8ddaeca53447
This commit is contained in:
Fusion
2026-05-15 11:51:52 -07:00
committed by gsxdsm
parent c513257fa2
commit 2a0e34c6aa
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
packages/dashboard/app/components/TaskChangesTab.tsx
View File

@@ -24,8 +24,13 @@ interface TaskChangesTabProps {
* Used as a last-resort fallback when the live worktree diff is empty or the * Used as a last-resort fallback when the live worktree diff is empty or the
* recorded `mergeDetails.commitSha` resolves to an empty git commit (which * recorded `mergeDetails.commitSha` resolves to an empty git commit (which
* can happen when the merger stores a per-branch SHA that gets collapsed * can happen when the merger stores a per-branch SHA that gets collapsed
* into a different squash on main). Without this, the tab would show "no * into a different squash on main).
* changes" while the card shows N. *
* Done-task sources of truth:
* - Authoritative landed diff: `/api/tasks/:id/diff` lineage union.
* - Fallback labels: `Final commit summary` (`mergeDetails`) or
* `files touched during execution` (`modifiedFiles`).
* - Never present fallback values as bare landed `files changed`.
*/ */
modifiedFiles?: string[]; modifiedFiles?: string[];
} }
@@ -70,7 +75,8 @@ function renderModifiedFilesFallback(
<p>{modifiedFiles.length} file{modifiedFiles.length === 1 ? "" : "s"} modified during execution.</p> <p>{modifiedFiles.length} file{modifiedFiles.length === 1 ? "" : "s"} modified during execution.</p>
<span className="task-changes-state-hint"> <span className="task-changes-state-hint">
{isDone {isDone
? "The recorded merge commit has no diff (likely collapsed into a squash on main). Showing file paths only — patches unavailable." // FN-4647: done-task fallback must explicitly describe executor-captured scope.
? "These are files captured from the worktree during execution. They may differ from the files that actually landed on main. The lineage-backed diff is unavailable for this task."
: "The live worktree diff is empty. Showing the last file paths captured during execution — patches unavailable."} : "The live worktree diff is empty. Showing the last file paths captured during execution — patches unavailable."}
</span> </span>
</div> </div>
@@ -312,7 +318,7 @@ export function TaskChangesTab({ taskId, worktree, projectId, column, mergeDetai
<p>Detailed file changes unavailable.</p> <p>Detailed file changes unavailable.</p>
<span className="task-changes-state-hint"> <span className="task-changes-state-hint">
{hasSummary {hasSummary
? `Merge summary: ${summaryFiles ?? 0} file${(summaryFiles ?? 0) === 1 ? "" : "s"} changed, +${summaryAdditions ?? 0} additions, -${summaryDeletions ?? 0} deletions.` ? `Final commit summary: ${summaryFiles ?? 0} file${(summaryFiles ?? 0) === 1 ? "" : "s"} changed, +${summaryAdditions ?? 0} additions, -${summaryDeletions ?? 0} deletions. Counts only the recorded merge/squash commit, not the full task lineage.`
: "No merge commit was recorded for this task."} : "No merge commit was recorded for this task."}
</span> </span>
</div> </div>