test(FN-000): address follow-up review feedback

packages/cli/src/__tests__/ci-workflow.test.ts

@@ -180,12 +180,20 @@ describe("PR checks workflow (.github/workflows/pr-checks.yml)", () => {
 
   it("keeps build coverage as an explicit PR gate", () => {
     const buildSteps = workflow.jobs?.build?.steps ?? [];
-    expect(buildSteps.some((step: any) => step.name === "Build" && step.run === "pnpm build")).toBe(true);
+    expect(
+      buildSteps.some(
+        (step: any) => step.name === "Build" && typeof step.run === "string" && step.run.includes("pnpm build"),
+      ),
+    ).toBe(true);
   });
 
   it("does not spend PR action minutes on a pre-test workspace build", () => {
     const testSteps = workflow.jobs?.["test-shards"]?.steps ?? [];
-    expect(testSteps.some((step: any) => step.name === "Build" || step.run === "pnpm build")).toBe(false);
+    expect(
+      testSteps.some(
+        (step: any) => step.name === "Build" || (typeof step.run === "string" && step.run.includes("pnpm build")),
+      ),
+    ).toBe(false);
   });
 });
 

packages/cli/src/__tests__/package-config.test.ts

@@ -22,6 +22,11 @@ function loadRootPackageJson(): any {
   return JSON.parse(readFileSync(path, "utf-8"));
 }
 
+function hasProjectArg(script: string | undefined, project: string): boolean {
+  const parts = script?.trim().split(/\s+/) ?? [];
+  return parts.some((part, index) => part === "--project" && parts[index + 1] === project);
+}
+
 describe("CLI package.json publishing config", () => {
   const pkg = loadPackageJson("cli");
 
@@ -249,10 +254,18 @@ describe("Workspace bootstrap script contract", () => {
   });
 
   it("keeps dashboard's default test lane curated with explicit deep coverage", () => {
-    expect(dashboardPkg.scripts?.test).toContain("--project dashboard-app-quality");
-    expect(dashboardPkg.scripts?.test).toContain("--project dashboard-api-quality");
-    expect(dashboardPkg.scripts?.["test:deep"]).toContain("--project dashboard-app");
-    expect(dashboardPkg.scripts?.["test:deep"]).toContain("--project dashboard-api");
+    const defaultTest = dashboardPkg.scripts?.test;
+    const deepTest = dashboardPkg.scripts?.["test:deep"];
+
+    expect(hasProjectArg(defaultTest, "dashboard-app-quality")).toBe(true);
+    expect(hasProjectArg(defaultTest, "dashboard-api-quality")).toBe(true);
+    expect(hasProjectArg(defaultTest, "dashboard-app")).toBe(false);
+    expect(hasProjectArg(defaultTest, "dashboard-api")).toBe(false);
+
+    expect(hasProjectArg(deepTest, "dashboard-app")).toBe(true);
+    expect(hasProjectArg(deepTest, "dashboard-api")).toBe(true);
+    expect(hasProjectArg(deepTest, "dashboard-app-quality")).toBe(false);
+    expect(hasProjectArg(deepTest, "dashboard-api-quality")).toBe(false);
   });
 });