root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(FN-4352): resolve review findings for secondary mobile control reverts

Browse Source 
Fusion-Task-Id: FN-4352
Fusion-Task-Lineage: 429612a4-fe44-4ac0-8d9b-d0d6c1743b36
This commit is contained in:
Fusion
2026-05-13 11:59:33 -07:00
committed by gsxdsm
parent 799318fbfd
commit 2cedd24d30
3 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/dashboard/app/components/ChatView.css
View File

@@ -1666,13 +1666,9 @@
opacity: 1; opacity: 1;
} }
/* FN-4352: secondary hover-revealed row action stays compact (inflated by FN-3628). */ /* FN-4352: secondary hover-revealed row action keeps base compact sizing (inflated by FN-3628). */
.chat-message-copy-action { .chat-message-copy-action {
opacity: 1; opacity: 1;
width: calc(var(--space-lg) * 2);
height: calc(var(--space-lg) * 2);
min-width: calc(var(--space-lg) * 2);
min-height: calc(var(--space-lg) * 2);
} }
.chat-tool-calls-group-summary, .chat-tool-calls-group-summary,

2
packages/dashboard/app/components/WorkflowResultsTab.css
View File

@@ -569,5 +569,5 @@
justify-content: space-between; justify-content: space-between;
} }
/* FN-4352: secondary in-row expand control intentionally has no mobile size override (inflated by FN-4236). */ /* FN-4352: reverted mobile expand-toggle inflation from FN-4236; falls back to compact base sizing. */
} }

6
packages/dashboard/app/components/__tests__/ChatView.test.tsx
View File

@@ -4631,10 +4631,10 @@ describe("ChatView mobile CSS contract", () => {
expect(css).toMatch(/@media\s*\(max-width:\s*768px\)[\s\S]*?\.chat-thread-header-render-toggle\s*\{[^}]*flex-shrink:\s*0/); expect(css).toMatch(/@media\s*\(max-width:\s*768px\)[\s\S]*?\.chat-thread-header-render-toggle\s*\{[^}]*flex-shrink:\s*0/);
}); });
it("mobile keeps response copy action visible and touch-friendly", () => { it("FN-4352: response copy action stays compact on mobile", () => {
expect(css).toMatch(/@media\s*\(max-width:\s*768px\)[\s\S]*?\.chat-message-copy-action\s*\{[^}]*opacity:\s*1/); expect(css).toMatch(/@media\s*\(max-width:\s*768px\)[\s\S]*?\.chat-message-copy-action\s*\{[^}]*opacity:\s*1/);
expect(css).toMatch(/@media\s*\(max-width:\s*768px\)[\s\S]*?\.chat-message-copy-action\s*\{[^}]*min-width:\s*calc\(var\(--space-lg\)\s*\*\s*2\.25\)/); expect(css).not.toMatch(/@media\s*\(max-width:\s*768px\)[\s\S]*?\.chat-message-copy-action\s*\{[^}]*min-width:\s*calc\(var\(--space-lg\)\s*\*\s*2\.25\)/);
expect(css).toMatch(/@media\s*\(max-width:\s*768px\)[\s\S]*?\.chat-message-copy-action\s*\{[^}]*min-height:\s*calc\(var\(--space-lg\)\s*\*\s*2\.25\)/); expect(css).not.toMatch(/@media\s*\(max-width:\s*768px\)[\s\S]*?\.chat-message-copy-action\s*\{[^}]*min-height:\s*calc\(var\(--space-lg\)\s*\*\s*2\.25\)/);
}); });
}); });