root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(terminal): tighten CSS selector in keyboard layout test

Browse Source 
Update test regexps to match .modal.terminal-modal (two-class selector) and assert min-height: 100dvh on mobile. Also clean up a stale comment in TaskDetailModal.
This commit is contained in:
gsxdsm
2026-04-26 11:44:39 -07:00
parent dd63ecec91
commit 303e0e1032
2 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
packages/dashboard/app/__tests__/terminal-mobile-keyboard-layout.test.ts
View File

@@ -99,7 +99,7 @@ describe("terminal mobile keyboard layout CSS contract", () => {
// so it must appear later in the stylesheet.
const afterSection = css.slice(terminalMediaStart);
const baseRuleMatch = afterSection.match(/^\s+\.terminal-modal\s*\{/m);
const baseRuleMatch = afterSection.match(/^\s+\.modal\.terminal-modal\s*\{/m);
const keyboardMatch = afterSection.match(keyboardOpenSelectorPattern);
expect(baseRuleMatch).not.toBeNull();
@@ -120,9 +120,9 @@ describe("terminal mobile keyboard layout CSS contract", () => {
function findMobileTerminalModalRule(): string {
const searchFrom = terminalMediaStart >= 0 ? terminalMediaStart : 0;
const afterSection = css.slice(searchFrom);
// Match the first indented .terminal-modal { ... } in this section
// Match the first indented .modal.terminal-modal { ... } in this section
const match = afterSection.match(
/^\s+\.terminal-modal\s*\{([^}]*)\}/m,
/^\s+\.modal\.terminal-modal\s*\{([^}]*)\}/m,
);
return match?.[1] ?? "";
}
@@ -141,6 +141,11 @@ describe("terminal mobile keyboard layout CSS contract", () => {
const ruleBody = findMobileTerminalModalRule();
expect(ruleBody).toContain("max-height: 100dvh");
});
it("sets min-height: 100dvh on mobile", () => {
const ruleBody = findMobileTerminalModalRule();
expect(ruleBody).toContain("min-height: 100dvh");
});
});
describe("desktop .modal.terminal-modal base rule", () => {

4
packages/dashboard/app/components/TaskDetailModal.tsx
View File

@@ -73,7 +73,7 @@ function resolveEffectiveValidator(
}
/**
* Extract planning/triage model from agent log entries.
* Extract planning model from agent log entries.
* Looks for text entries with agent role "triage" matching the pattern:
* "Triage using model: <provider>/<modelId>"
* Returns the latest match, or null if none found.
@@ -92,7 +92,7 @@ function extractPlanningModelFromLog(entries: AgentLogEntry[]): { provider: stri
}
/**
* Resolve the effective planning/triage model following the resolution order:
* Resolve the effective planning model following the resolution order:
* 1. Per-task planningModelProvider/planningModelId override
* 2. Runtime triage model from agent log marker (if present)
* 3. Project settings planningProvider/planningModelId