diff --git a/packages/engine/src/__tests__/planner-lane-resolution.test.ts b/packages/engine/src/__tests__/planner-lane-resolution.test.ts index 20d567da18..c0abf9b4c9 100644 --- a/packages/engine/src/__tests__/planner-lane-resolution.test.ts +++ b/packages/engine/src/__tests__/planner-lane-resolution.test.ts @@ -26,7 +26,14 @@ function storeWith(ir: WorkflowIr | null): TaskStore { getTaskWorkflowSelection: vi.fn(() => selection), getTaskWorkflowSelectionAsync: vi.fn(async () => selection), getWorkflowDefinition: vi.fn(async () => (ir ? { ir } : null)), - resolveTaskWorkflowIrSync: vi.fn(() => { if (!ir) throw new Error("no ir"); return ir; }), + /* + FNXC:WorkflowResolvedColumns 2026-07-31-23:59: + The `resolveTaskWorkflowIrSync` stub is REMOVED, and it was redundant: this suite passes without + it. That reader answers with the DEFAULT board for every task in production, so stubbing it with a + working IR feeds the broken reader the right answer — the suite would keep passing even if its + call site stopped resolving. Audited across the 8 files that stubbed it (#3197): four were + redundant like this one, one is legitimately about the sync path, one was masking real inertness. + */ } as unknown as TaskStore; } diff --git a/packages/engine/src/__tests__/recover-approved-intake-post-u11.test.ts b/packages/engine/src/__tests__/recover-approved-intake-post-u11.test.ts index d5fa59c1b5..b19ff0ecf2 100644 --- a/packages/engine/src/__tests__/recover-approved-intake-post-u11.test.ts +++ b/packages/engine/src/__tests__/recover-approved-intake-post-u11.test.ts @@ -99,7 +99,14 @@ function createStore(task: Task, workflowIr: WorkflowIr): TaskStore { silently takes the legacy `{ intake: "triage" }` fallback, which reads as "the conversion does not work" rather than "the fake is incomplete". */ - resolveTaskWorkflowIrSync: vi.fn(() => workflowIr), + /* + FNXC:WorkflowResolvedColumns 2026-07-31-23:59: + The `resolveTaskWorkflowIrSync` stub is REMOVED, and it was redundant: this suite passes without + it. That reader answers with the DEFAULT board for every task in production, so stubbing it with a + working IR feeds the broken reader the right answer — the suite would keep passing even if its + call site stopped resolving. Audited across the 8 files that stubbed it (#3197): four were + redundant like this one, one is legitimately about the sync path, one was masking real inertness. + */ getTaskWorkflowSelectionAsync: vi.fn(async () => selection), getWorkflowDefinition: vi.fn(async () => ({ ir: workflowIr })), on: vi.fn(), off: vi.fn(), diff --git a/packages/engine/src/__tests__/triage-undeclared-column-rescue.test.ts b/packages/engine/src/__tests__/triage-undeclared-column-rescue.test.ts index 1004322b56..1061cf30d3 100644 --- a/packages/engine/src/__tests__/triage-undeclared-column-rescue.test.ts +++ b/packages/engine/src/__tests__/triage-undeclared-column-rescue.test.ts @@ -105,7 +105,14 @@ function createStore(ir: WorkflowIr, workflowId: string = WF): TaskStore { getTaskWorkflowSelection: vi.fn(() => selection), getTaskWorkflowSelectionAsync: vi.fn(async () => selection), getWorkflowDefinition: vi.fn(async () => ({ ir })), - resolveTaskWorkflowIrSync: vi.fn(() => ir), + /* + FNXC:WorkflowResolvedColumns 2026-07-31-23:59: + The `resolveTaskWorkflowIrSync` stub is REMOVED, and it was redundant: this suite passes without + it. That reader answers with the DEFAULT board for every task in production, so stubbing it with a + working IR feeds the broken reader the right answer — the suite would keep passing even if its + call site stopped resolving. Audited across the 8 files that stubbed it (#3197): four were + redundant like this one, one is legitimately about the sync path, one was masking real inertness. + */ logEntry: vi.fn(), } as unknown as TaskStore; }