root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(FN-XXXX): guard Database against nested .fusion/.fusion paths

Browse Source 
Throws if a caller passes a path whose last two segments are both `.fusion` — that pattern only happens when a Store class joins `.fusion` onto a path that already ends in `.fusion`. Surfaces the bug at the call site instead of silently creating a stray nested directory under the project. Complements the recent in-process-runtime PluginStore fix by catching any other call paths still passing the wrong rootDir.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
gsxdsm
2026-05-01 21:56:59 -07:00
parent 03d0fac59c
commit 36d623a16f
2 changed files with 19 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/guard-nested-fusion-database.md Normal file
View File

@@ -0,0 +1,5 @@
---
"@runfusion/fusion": patch
---
Add a defensive guard in `Database` constructor that throws when opening a database at a path whose last two segments are both `.fusion`. This catches caller bugs where a `.fusion` directory is passed in place of a project root (causing `.fusion/.fusion/fusion.db` to be silently created). Future regressions of this class of bug now fail loudly at the originating call site instead of leaving stray nested directories.

14
packages/core/src/db.ts
View File

@@ -713,6 +713,20 @@ export class Database {
throw new Error(`[fusion] Database constructor requires an absolute fusionDir path, got: ${fusionDir}`); throw new Error(`[fusion] Database constructor requires an absolute fusionDir path, got: ${fusionDir}`);
} }
// Defensive: a fusionDir whose last two path segments are both ".fusion"
// indicates a caller mistakenly passed a `.fusion` directory where a
// project root was expected (a Store class joined `.fusion` onto a path
// that already ended in `.fusion`). Failing fast here surfaces the bug
// at the originating call site rather than silently creating a stray
// `.fusion/.fusion/` tree under the project.
if (!inMemory && /\.fusion[\\/]\.fusion(?:[\\/]|$)/.test(fusionDir)) {
throw new Error(
`[fusion] Refusing to open Database at nested .fusion/.fusion path: ${fusionDir}\n` +
"This means a caller passed a .fusion directory where a project root was expected. " +
"Audit the call site for an extra `join(rootDir, '.fusion')` step.",
);
}
// Ensure .fusion directory exists (only meaningful for disk-backed mode; // Ensure .fusion directory exists (only meaningful for disk-backed mode;
// in-memory mode never touches the filesystem here). // in-memory mode never touches the filesystem here).
if (!inMemory && !existsSync(fusionDir)) { if (!inMemory && !existsSync(fusionDir)) {