feat(FN-2613): tokenize standalone mobile footer spacing

- Replace hardcoded mobile footer offset with --executor-footer-height in MobileNavBar content padding
- Move standalone display-mode behavior to a :root token override and remove global #root standalone padding
- Scope standalone bottom-gap application to mobile layout containers (project content and executor status bar)
- Update mobile nav and PWA CSS tests to assert tokenized spacing and scoped standalone rules
This commit is contained in:
Fusion
2026-04-26 22:00:36 -07:00
committed by gsxdsm
parent b918ba5ee6
commit 394960f251
4 changed files with 30 additions and 12 deletions

View File

@@ -92,6 +92,8 @@ describe("mobile-nav-bar.css", () => {
it("defines content padding rule for mobile nav", () => {
expect(mobileMediaBlock).toContain(".project-content--with-mobile-nav");
expect(cssContent).toContain(".project-content--with-footer.project-content--with-mobile-nav");
expect(cssContent).toContain("var(--executor-footer-height)");
expect(cssContent).not.toContain("calc(32px + var(--mobile-nav-height)");
});
it("mobile-more-sheet uses additive safe-area padding (not max) to prevent Settings clipping", () => {

View File

@@ -3,6 +3,24 @@ import { resolve } from "node:path";
import { describe, expect, it } from "vitest";
import { loadAllAppCss } from "../test/cssFixture";
function getStandaloneDisplayModeBlock(css: string): string {
const match = /@media\s*\(\s*display-mode:\s*standalone\s*\)\s*\{/.exec(css);
expect(match).toBeTruthy();
const start = match!.index;
const open = css.indexOf("{", start);
let depth = 1;
let i = open + 1;
while (i < css.length && depth > 0) {
if (css[i] === "{") depth++;
else if (css[i] === "}") depth--;
i++;
}
return css.slice(start, i);
}
describe("PWA configuration", () => {
it("manifest defines required PWA fields and icon sizes", () => {
const manifestPath = resolve(__dirname, "../public/manifest.json");
@@ -36,11 +54,13 @@ describe("PWA configuration", () => {
expect(indexHtml).toMatch(/<meta\s+name="viewport"[^>]*content="[^"]*viewport-fit=cover[^"]*"/i);
});
it("CSS includes display-mode: standalone rule with safe-area-inset-bottom for PWA home bar spacing", () => {
it("CSS includes display-mode: standalone rule with a :root token override only", () => {
const cssContent = loadAllAppCss();
const standaloneBlock = getStandaloneDisplayModeBlock(cssContent);
expect(cssContent).toMatch(/@media\s*\(\s*display-mode:\s*standalone\s*\)/);
expect(cssContent).toMatch(/@media\s*\(\s*display-mode:\s*standalone\s*\)\s*\{[\s\S]*?#root\s*\{[\s\S]*?env\(safe-area-inset-bottom,\s*0px\)/);
expect(standaloneBlock).toContain("@media (display-mode: standalone)");
expect(standaloneBlock).toMatch(/:root\s*\{[\s\S]*?--standalone-bottom-gap:\s*8px/);
expect(standaloneBlock).not.toContain("#root {");
});
it("CSS includes --standalone-bottom-gap token with 8px value in standalone mode", () => {
@@ -52,11 +72,12 @@ describe("PWA configuration", () => {
expect(cssContent).toMatch(/--standalone-bottom-gap:\s*8px/);
});
it("CSS uses additive bottom spacing in standalone mode (safe-area + gap)", () => {
it("CSS applies standalone bottom gap via scoped mobile layout rules, not global #root padding", () => {
const cssContent = loadAllAppCss();
// #root should use var(--standalone-bottom-gap) in a calc expression for additive spacing
expect(cssContent).toContain("var(--standalone-bottom-gap))");
expect(cssContent).toMatch(/\.project-content--with-mobile-nav\s*\{[^}]*var\(--standalone-bottom-gap\)/);
expect(cssContent).toMatch(/\.executor-status-bar\s*\{[^}]*var\(--standalone-bottom-gap\)/);
expect(cssContent).not.toMatch(/#root\s*\{[^}]*var\(--standalone-bottom-gap\)/);
});
it("service worker contains lifecycle handlers and versioned cache name", () => {

View File

@@ -39,7 +39,7 @@
/* Content padding: both mobile nav AND footer */
.project-content--with-footer.project-content--with-mobile-nav {
padding-bottom: calc(32px + var(--mobile-nav-height) + env(safe-area-inset-bottom, 0px) + var(--standalone-bottom-gap));
padding-bottom: calc(var(--executor-footer-height) + var(--mobile-nav-height) + env(safe-area-inset-bottom, 0px) + var(--standalone-bottom-gap));
}
}

View File

@@ -2690,11 +2690,6 @@ input[type="range"]:focus-visible {
/* PWA standalone mode: 8px extra breathing room for iOS home indicator */
--standalone-bottom-gap: 8px;
}
#root {
/* FN-1626: additive bottom spacing = safe-area inset + standalone home bar gap */
padding-bottom: calc(env(safe-area-inset-bottom, 0px) + var(--standalone-bottom-gap));
}
}
/* === Mobile Responsive Overrides ===