fix(FN-2546): harden scheduled automation catch-up reliability

- Preserve overdue nextRunAt when schedule updates only touch non-cadence fields
- Recompute nextRunAt only when cadence changes, schedules are re-enabled, or nextRunAt is missing
- Sync memory dreams automation during ProjectEngine startup before CronRunner begins ticking
- Add core/engine regression coverage and a patch changeset for @runfusion/fusion release notes
This commit is contained in:
Fusion
2026-04-25 17:06:38 -07:00
committed by gsxdsm
parent 856146cced
commit 39622f0398
5 changed files with 112 additions and 5 deletions

View File

@@ -317,6 +317,72 @@ describe("AutomationStore", () => {
expect(reenabled.nextRunAt).toBeTruthy();
});
it("preserves overdue nextRunAt when updating non-cadence fields", async () => {
const schedule = await store.createSchedule({
name: "Catch-up",
command: "echo catch-up",
scheduleType: "hourly",
});
const overdue = new Date(Date.now() - 60_000).toISOString();
store["db"].prepare("UPDATE automations SET nextRunAt = ? WHERE id = ?").run(overdue, schedule.id);
const updated = await store.updateSchedule(schedule.id, {
description: "updated description",
});
expect(updated.nextRunAt).toBe(overdue);
});
it("recomputes nextRunAt when cadence changes", async () => {
const schedule = await store.createSchedule({
name: "Cadence",
command: "echo cadence",
scheduleType: "hourly",
});
const overdue = new Date(Date.now() - 60_000).toISOString();
store["db"].prepare("UPDATE automations SET nextRunAt = ? WHERE id = ?").run(overdue, schedule.id);
const updated = await store.updateSchedule(schedule.id, {
scheduleType: "custom",
cronExpression: "*/5 * * * *",
});
expect(updated.nextRunAt).not.toBe(overdue);
expect(new Date(updated.nextRunAt ?? 0).getTime()).toBeGreaterThan(Date.now() - 1000);
});
it("recomputes nextRunAt when enabling from disabled state", async () => {
const schedule = await store.createSchedule({
name: "Enable",
command: "echo enable",
scheduleType: "hourly",
enabled: false,
});
const updated = await store.updateSchedule(schedule.id, {
enabled: true,
});
expect(updated.nextRunAt).toBeTruthy();
expect(new Date(updated.nextRunAt ?? 0).getTime()).toBeGreaterThan(Date.now() - 1000);
});
it("recomputes nextRunAt when missing on enabled schedule", async () => {
const schedule = await store.createSchedule({
name: "Missing next run",
command: "echo missing",
scheduleType: "hourly",
});
store["db"].prepare("UPDATE automations SET nextRunAt = NULL WHERE id = ?").run(schedule.id);
const updated = await store.updateSchedule(schedule.id, {
command: "echo changed",
});
expect(updated.nextRunAt).toBeTruthy();
expect(new Date(updated.nextRunAt ?? 0).getTime()).toBeGreaterThan(Date.now() - 1000);
});
it("rejects empty name", async () => {
const schedule = await store.createSchedule({
name: "Test",

View File

@@ -254,6 +254,9 @@ export class AutomationStore extends EventEmitter<AutomationStoreEvents> {
async updateSchedule(id: string, updates: ScheduledTaskUpdateInput): Promise<ScheduledTask> {
return this.withScheduleLock(id, async () => {
const schedule = await this.getSchedule(id);
const previousEnabled = schedule.enabled;
const previousScheduleType = schedule.scheduleType;
const previousCronExpression = schedule.cronExpression;
if (updates.name !== undefined) {
if (!updates.name.trim()) throw new Error("Name cannot be empty");
@@ -299,11 +302,16 @@ export class AutomationStore extends EventEmitter<AutomationStoreEvents> {
schedule.enabled = updates.enabled;
}
// Recompute next run if enabled
if (schedule.enabled) {
schedule.nextRunAt = this.computeNextRun(schedule.cronExpression);
} else {
const cadenceChanged =
schedule.scheduleType !== previousScheduleType ||
schedule.cronExpression !== previousCronExpression;
const enabledFromDisabled = !previousEnabled && schedule.enabled;
const missingNextRunAt = !schedule.nextRunAt;
if (!schedule.enabled) {
schedule.nextRunAt = undefined;
} else if (cadenceChanged || enabledFromDisabled || missingNextRunAt) {
schedule.nextRunAt = this.computeNextRun(schedule.cronExpression);
}
schedule.updatedAt = new Date().toISOString();