fix(KB-503): address code review feedback for Step 1

- Add optional globalDir parameter to resolveProject(), getDefaultProject(),
  setDefaultProject(), and clearDefaultProject() for test isolation
- Remove ESLint suppression by using void operator for intentionally unused var
- Update all tests to use isolated globalDir parameter
- Complete tests for default project resolution
This commit is contained in:
gsxdsm
2026-03-31 22:38:56 -07:00
parent 48484843aa
commit 3e96e9ef71
798 changed files with 125632 additions and 450 deletions

View File

@@ -0,0 +1,118 @@
import http from "node:http";
import type { Socket } from "node:net";
import { PassThrough } from "node:stream";
type TestResponse = {
status: number;
body: unknown;
headers: http.OutgoingHttpHeaders;
};
class MockSocket extends PassThrough {
public writable = true;
public readable = true;
public remoteAddress = "127.0.0.1";
public encrypted = false;
setTimeout(): this {
return this;
}
setNoDelay(): this {
return this;
}
setKeepAlive(): this {
return this;
}
destroySoon(): void {
this.destroy();
}
}
function normalizeBody(body: Buffer | string | undefined): Buffer | undefined {
if (body === undefined) return undefined;
return Buffer.isBuffer(body) ? body : Buffer.from(body);
}
export async function request(
app: (req: http.IncomingMessage, res: http.ServerResponse) => void,
method: string,
path: string,
body?: Buffer | string,
headers: Record<string, string> = {},
): Promise<TestResponse> {
const normalizedBody = normalizeBody(body);
const socket = new MockSocket();
const req = new http.IncomingMessage(socket as unknown as Socket);
const res = new http.ServerResponse(req);
const chunks: Buffer[] = [];
req.method = method;
req.url = path;
req.httpVersion = "1.1";
req.headers = Object.fromEntries(
Object.entries({
host: "127.0.0.1",
...headers,
...(normalizedBody ? { "content-length": String(normalizedBody.length) } : {}),
}).map(([key, value]) => [key.toLowerCase(), value]),
);
res.assignSocket(socket as unknown as Socket);
const originalWrite = res.write.bind(res);
const originalEnd = res.end.bind(res);
res.write = ((chunk: string | Buffer, encoding?: BufferEncoding | ((error?: Error | null) => void), cb?: (error?: Error | null) => void) => {
chunks.push(Buffer.isBuffer(chunk) ? chunk : Buffer.from(chunk, typeof encoding === "string" ? encoding : undefined));
return originalWrite(chunk as never, encoding as never, cb);
}) as typeof res.write;
res.end = ((chunk?: string | Buffer, encoding?: BufferEncoding | (() => void), cb?: () => void) => {
if (chunk !== undefined) {
chunks.push(Buffer.isBuffer(chunk) ? chunk : Buffer.from(chunk, typeof encoding === "string" ? encoding : undefined));
}
return originalEnd(chunk as never, encoding as never, cb as never);
}) as typeof res.end;
const response = new Promise<TestResponse>((resolve, reject) => {
res.on("finish", () => {
const rawBody = Buffer.concat(chunks).toString("utf8");
const contentType = res.getHeader("content-type");
const shouldParseJson = typeof contentType === "string" && contentType.includes("application/json");
try {
resolve({
status: res.statusCode,
body: shouldParseJson && rawBody.length > 0 ? JSON.parse(rawBody) : rawBody,
headers: res.getHeaders(),
});
} catch (error) {
reject(error);
}
});
res.on("error", reject);
});
app(req, res);
process.nextTick(() => {
if (normalizedBody) {
req.emit("data", normalizedBody);
}
req.complete = true;
req.emit("end");
});
return response;
}
export async function get(
app: (req: http.IncomingMessage, res: http.ServerResponse) => void,
path: string,
): Promise<TestResponse> {
return request(app, "GET", path);
}