root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(FN-2639): replace native confirms with dashboard confirm dialog

Browse Source 
- Add reusable ConfirmDialog component, styles, and useConfirm hook to provide async confirmation flows
- Wire ConfirmProvider at app level and migrate confirm call sites across task, agent, roadmap, plugin, and settings UI actions
- Update modal interaction patterns to support dialog reentry and consistent destructive-action confirmations
- Expand dashboard tests with confirm dialog and hook coverage plus migrated component test assertions
This commit is contained in:
Fusion
2026-04-27 04:05:25 -07:00
committed by gsxdsm
parent 00239149ab
commit 410a438a7f
41 changed files with 953 additions and 266 deletions
Download Patch File Download Diff File Expand all files Collapse all files

61
packages/dashboard/app/components/__tests__/NewTaskModal.test.tsx
View File

@@ -35,6 +35,12 @@ vi.mock("../../api", () => ({
updateGlobalSettings: vi.fn().mockResolvedValue({}),
}));
const mockConfirm = vi.fn();
vi.mock("../../hooks/useConfirm", () => ({
useConfirm: () => ({ confirm: mockConfirm }),
}));
function makeTask(id: string): Task {
return {
id,
@@ -69,6 +75,8 @@ function renderNewTaskModal(props = {}) {
describe("NewTaskModal", () => {
beforeEach(() => {
vi.clearAllMocks();
mockConfirm.mockReset();
mockConfirm.mockResolvedValue(true);
});
it("renders all form fields when open", async () => {
@@ -230,22 +238,24 @@ describe("NewTaskModal", () => {
});
});
it("confirms before closing with dirty state", () => {
it("confirms before closing with dirty state", async () => {
const { props } = renderNewTaskModal();
const descTextarea = screen.getByRole('textbox');
fireEvent.change(descTextarea, { target: { value: "Test description" } });
// Mock confirm to return false (cancel)
const originalConfirm = window.confirm;
window.confirm = vi.fn().mockReturnValue(false);
mockConfirm.mockResolvedValueOnce(false);
fireEvent.click(screen.getByRole("button", { name: "Cancel" }));
expect(window.confirm).toHaveBeenCalledWith("You have unsaved changes. Discard them?");
await waitFor(() => {
expect(mockConfirm).toHaveBeenCalledWith({
title: "Discard Changes",
message: "You have unsaved changes. Discard them?",
danger: true,
});
});
expect(props.onClose).not.toHaveBeenCalled();
window.confirm = originalConfirm;
});
it("closes without confirm when state is not dirty", () => {
@@ -772,19 +782,22 @@ describe("NewTaskModal", () => {
});
});
it("treats non-default priority as dirty state on cancel", () => {
it("treats non-default priority as dirty state on cancel", async () => {
renderNewTaskModal();
fireEvent.click(screen.getByTestId("task-form-more-options-toggle"));
fireEvent.change(screen.getByTestId("task-priority-select"), { target: { value: "high" } });
const originalConfirm = window.confirm;
window.confirm = vi.fn().mockReturnValue(false);
mockConfirm.mockResolvedValueOnce(false);
fireEvent.click(screen.getByRole("button", { name: "Cancel" }));
expect(window.confirm).toHaveBeenCalledWith("You have unsaved changes. Discard them?");
window.confirm = originalConfirm;
await waitFor(() => {
expect(mockConfirm).toHaveBeenCalledWith({
title: "Discard Changes",
message: "You have unsaved changes. Discard them?",
danger: true,
});
});
});
});
@@ -956,16 +969,16 @@ describe("NewTaskModal", () => {
fireEvent.click(screen.getByText("Executor Bot"));
// Mock confirm to return true (confirm discard)
const originalConfirm = window.confirm;
window.confirm = vi.fn().mockReturnValue(true);
// Try to close - should show confirm
fireEvent.click(screen.getByRole("button", { name: "Cancel" }));
expect(window.confirm).toHaveBeenCalledWith("You have unsaved changes. Discard them?");
window.confirm = originalConfirm;
await waitFor(() => {
expect(mockConfirm).toHaveBeenCalledWith({
title: "Discard Changes",
message: "You have unsaved changes. Discard them?",
danger: true,
});
});
});
it("resets agent selection after successful task creation", async () => {