root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(dashboard): memoize normalized shell state to stop render thrash

Browse Source 
normalizeShellState rebuilds the object and its profiles array on every
call. useShellConnection was calling it during render, so consumers that
put state.profiles in a useEffect dep array (AppInner does, for the
shell-connection status effect) re-ran the effect on every render. The
async getShellConnectionNativeResult resolution then triggered another
render, feeding the loop. On desktop it stabilized; on iOS Safari it
could pin the main thread.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
gsxdsm
2026-05-08 08:37:26 -07:00
parent b8d14849ee
commit 4b666a04fe
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/dashboard/app/hooks/useShellConnection.ts
View File

@@ -1,4 +1,4 @@
import { useCallback } from "react";
import { useCallback, useMemo } from "react";
import { useShellContext } from "../context/ShellContext";
import {
createOrUpdateProfile,
@@ -11,13 +11,19 @@ import type { ShellConnectionProfileInput } from "../types/native-shell";
export function useShellConnection() {
const context = useShellContext();
// Memoize the normalized state. normalizeShellState rebuilds the object and
// its profiles array on every call, so without this any consumer that puts
// `state.profiles` in a useEffect dep array (see AppInner) re-runs the
// effect every render — which can pin the main thread on iOS Safari.
const state = useMemo(() => normalizeShellState(context.state), [context.state]);
const saveProfile = useCallback((profile: ShellConnectionProfileInput) => createOrUpdateProfile(context.shellApi, profile), [context.shellApi]);
const removeProfile = useCallback((profileId: string) => deleteProfile(context.shellApi, profileId), [context.shellApi]);
const setActiveProfile = useCallback((profileId: string | null) => selectActiveProfile(context.shellApi, profileId), [context.shellApi]);
return {
...context,
state: normalizeShellState(context.state),
state,
saveProfile,
removeProfile,
setActiveProfile,