root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(FN-4651): complete Step 2 — split predicates and persist retry counter

Browse Source 
Fusion-Task-Id: FN-4651
Fusion-Task-Lineage: 14d15555-468d-4690-8efd-a09b31b5d407
This commit is contained in:
Fusion
2026-05-15 12:34:18 -07:00
committed by gsxdsm
parent 8866934b7d
commit 5a9de72b3f
7 changed files with 65 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
packages/engine/src/__tests__/restart-recovery-coordinator.test.ts
View File

@@ -5,6 +5,8 @@ import {
extractMissingWorktreePathFromSessionStartFailure,
isMissingWorktreeSessionStartFailure,
isRecoverableMissingWorktreeReviewFailure,
isRecoverableMissingWorktreeReviewFailureNoProgress,
isRecoverableMissingWorktreeReviewFailureWithProgress,
} from "../restart-recovery-coordinator.js";
function createTask(overrides: Partial<Task>): Task {
@@ -44,7 +46,7 @@ describe("RestartRecoveryCoordinator", () => {
expect(extractMissingWorktreePathFromSessionStartFailure("Refusing to start coding agent in incomplete worktree:")).toBeNull();
});
it("identifies recoverable in-review missing-worktree failures with step progress", () => {
it("identifies recoverable in-review missing-worktree failures with and without step progress", () => {
const baseTask = createTask({
column: "in-review",
paused: false,
@@ -56,9 +58,13 @@ describe("RestartRecoveryCoordinator", () => {
expect(isRecoverableMissingWorktreeReviewFailure({ ...baseTask, error: "Refusing to start coding agent in incomplete worktree: /tmp/wt" })).toBe(true);
expect(isRecoverableMissingWorktreeReviewFailure({ ...baseTask, error: "Refusing to start coding agent in unregistered git worktree: /tmp/wt" })).toBe(true);
expect(isRecoverableMissingWorktreeReviewFailure({ ...baseTask, paused: true, error: "Refusing to start coding agent in missing worktree: /tmp/wt" })).toBe(false);
expect(isRecoverableMissingWorktreeReviewFailure({ ...baseTask, error: "other" })).toBe(false);
expect(isRecoverableMissingWorktreeReviewFailure({ ...baseTask, steps: [{ id: "s2", title: "y", status: "pending" }] as any, error: "Refusing to start coding agent in missing worktree: /tmp/wt" })).toBe(false);
expect(isRecoverableMissingWorktreeReviewFailureWithProgress({ ...baseTask, paused: true, error: "Refusing to start coding agent in missing worktree: /tmp/wt" })).toBe(false);
expect(isRecoverableMissingWorktreeReviewFailureWithProgress({ ...baseTask, error: "other" })).toBe(false);
expect(isRecoverableMissingWorktreeReviewFailureWithProgress({ ...baseTask, steps: [{ id: "s2", title: "y", status: "pending" }] as any, error: "Refusing to start coding agent in missing worktree: /tmp/wt" })).toBe(false);
const noProgressTask = { ...baseTask, steps: [{ id: "s2", title: "y", status: "pending" }] as any, error: "Refusing to start coding agent in missing worktree: /tmp/wt" };
expect(isRecoverableMissingWorktreeReviewFailureNoProgress(noProgressTask)).toBe(true);
expect(isRecoverableMissingWorktreeReviewFailure(noProgressTask)).toBe(true);
});
it("requeues interrupted failed tasks with no progress, then resumes remaining orphans", async () => {

15
packages/engine/src/restart-recovery-coordinator.ts
View File

@@ -52,7 +52,7 @@ export function extractMissingWorktreePathFromSessionStartFailure(error: unknown
return pathPart.length > 0 ? pathPart : null;
}
export function isRecoverableMissingWorktreeReviewFailure(task: Task): boolean {
export function isRecoverableMissingWorktreeReviewFailureWithProgress(task: Task): boolean {
return task.column === "in-review"
&& !task.paused
&& task.status === "failed"
@@ -60,6 +60,19 @@ export function isRecoverableMissingWorktreeReviewFailure(task: Task): boolean {
&& hasStepProgress(task);
}
export function isRecoverableMissingWorktreeReviewFailureNoProgress(task: Task): boolean {
return task.column === "in-review"
&& !task.paused
&& task.status === "failed"
&& isMissingWorktreeSessionStartFailure(task.error)
&& !hasStepProgress(task);
}
export function isRecoverableMissingWorktreeReviewFailure(task: Task): boolean {
return isRecoverableMissingWorktreeReviewFailureWithProgress(task)
|| isRecoverableMissingWorktreeReviewFailureNoProgress(task);
}
export class RestartRecoveryCoordinator {
constructor(
private readonly store: TaskStore,