root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(FN-4104): wrap workflow result headers and warn on overlapping in-prog

Browse Source 
Adds warning logic when overlapping in-progress step updates occur, and wraps workflow result table headers with proper text handling and styling in the dashboard UI.

Fusion-Task-Id: FN-4104
This commit is contained in:
Fusion
2026-05-12 15:15:47 -07:00
committed by gsxdsm
parent 5e74361859
commit 5bbfc66c83
6 changed files with 123 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
packages/engine/src/__tests__/executor-review-verdicts.test.ts
View File

@@ -1271,6 +1271,44 @@ describe("E2E review pipeline — multi-verdict sequence", () => {
mockedExistsSync.mockReturnValue(true);
});
it("warns when fn_task_update marks a second step in-progress", async () => {
const store = createMockStore();
store.getTask.mockResolvedValue({
id: "FN-001",
title: "Test",
description: "Test task",
column: "in-progress",
dependencies: [],
currentStep: 0,
log: [],
prompt: "# test\n## Steps\n### Step 0: Preflight\n### Step 1: Implement\n### Step 2: Verify",
createdAt: new Date().toISOString(),
updatedAt: new Date().toISOString(),
steps: [
{ name: "Preflight", status: "in-progress" },
{ name: "Implement", status: "pending" },
{ name: "Verify", status: "pending" },
],
});
store.updateStep.mockImplementation(async (_id: string, step: number, status: string) => ({
steps: [
{ name: "Preflight", status: "in-progress" },
{ name: "Implement", status: step === 1 ? status : "pending" },
{ name: "Verify", status: "pending" },
],
}));
const { tools } = await captureE2ETools(store);
const result = await tools.fn_task_update("u-warn", { step: 2, status: "in-progress" });
expect(executorLog.warn).toHaveBeenCalledTimes(1);
expect(executorLog.warn).toHaveBeenCalledWith(
"FN-E2E: fn_task_update marking step 2 in-progress while step 1 is already in-progress",
);
expect(store.updateStep).toHaveBeenCalledWith("FN-E2E", 1, "in-progress");
expect(result.content[0].text).toContain("Step 2 (Implement) → in-progress");
});
it("full sequence: plan APPROVE → code REVISE (blocked) → code APPROVE (unblocked) → done", async () => {
const store = createMockStore();
store.updateStep.mockImplementation(async (_id: string, step: number, status: string) =>

16
packages/engine/src/executor.ts
View File

@@ -4296,6 +4296,22 @@ export class TaskExecutor {
const stepIndex = step - 1;
if (status === "in-progress") {
try {
const latestTask = await store.getTask(taskId);
const otherInProgressStepIndex = latestTask.steps.findIndex(
(taskStep, index) => index !== stepIndex && taskStep.status === "in-progress",
);
if (otherInProgressStepIndex !== -1) {
executorLog.warn(
`${taskId}: fn_task_update marking step ${step} in-progress while step ${otherInProgressStepIndex + 1} is already in-progress`,
);
}
} catch (err) {
executorLog.warn(`${taskId}: failed to inspect step lease state before fn_task_update: ${err}`);
}
}
// Enforce code review REVISE: block advancing to "done" when the last
// code review for this step returned REVISE. The agent must fix the
// issues and call fn_review_step(type="code") again before proceeding.