root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

FN-5773: add safe reconcile-done endpoint for shipped mission features

Browse Source 
Add a guarded API path to reconcile mission features to done after delivery tasks have already shipped.

- add POST /api/missions/features/:featureId/reconcile-done with validation for feature id, task id, task linkage, and terminal task columns (done/archived)
- keep active-work protections by rejecting non-terminal task columns and mismatched existing task links with clear conflict responses
- extend mission API e2e coverage for success and failure cases, including done/archived reconciliation, missing inputs, invalid ids, missing tasks/features, and mismatched links
- document reconcile-done behavior, safety gates, and error semantics in missions docs

Files changed:
 docs/missions.md                                   |  31 ++++++
 packages/dashboard/src/__tests__/mission-e2e.test.ts    | 105 +++++++++++++++++++++
 packages/dashboard/src/mission-routes.ts           |  59 ++++++++++++
 3 files changed, 195 insertions(+)

Fusion-Task-Id: FN-5773

Fusion-Task-Lineage: c638b43f-d66f-479a-82c1-a9378a628ca3
This commit is contained in:
gsxdsm
2026-05-31 07:43:28 -07:00
parent ba81d1f0ac
commit 5c33ab133e
3 changed files with 195 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
docs/missions.md
View File

@@ -258,6 +258,37 @@ If validation cannot run (unexpected loop state, duplicate trigger, blocked vali
| `POST /api/missions/:missionId/autopilot/start` | Start watching manually |
| `POST /api/missions/:missionId/autopilot/stop` | Stop watching manually |
## Feature Reconciliation API Endpoint
Use this endpoint when a feature's delivery task has already shipped and is now terminal (`done` or `archived`), but the feature status still needs to be reconciled to `done`.
### `POST /api/missions/features/:featureId/reconcile-done`
**Request body:**
```json
{ "taskId": "FN-123" }
```
**Safety gate behavior:**
- Validates `featureId` and requires a non-empty string `taskId`.
- Looks up the feature and the delivery task in the request's scoped project store.
- Only allows reconciliation when the delivery task column is `done` or `archived`.
- If feature has no `taskId`, the endpoint links it first, then marks feature status `done` via `updateFeatureStatus` (which recomputes slice status).
- If feature already has a different `taskId`, returns `409` (conflict).
**How this differs from `PATCH /api/missions/features/:featureId`:**
- `PATCH` keeps the execution-status guard and rejects `done`/`triaged`/`in-progress`/`blocked` when no linked task exists.
- `reconcile-done` is a dedicated, evidence-gated path for shipped work where the delivery task is already terminal.
**Error responses:**
- `400` — invalid feature ID format or missing/empty `taskId`.
- `404` — feature not found or delivery task not found.
- `409` — feature/task mismatch or delivery task is not in `done`/`archived` (use normal PATCH/triage/link flow for active work).
## Validation Contract Lifecycle
Fusion's validation contract lifecycle is the structured feature delivery system for missions. It combines validation contracts, AI validation, and bounded retries to provide systematic, auditable feature completion. The lifecycle covers the full end-to-end path from clarification through blocked handoff.