From 5ff81cb46033d7b6f1c199499e85b447850f394e Mon Sep 17 00:00:00 2001 From: gsxdsm Date: Tue, 30 Jun 2026 22:25:38 -0700 Subject: [PATCH] FN-7343: Remove task chat steering guidance copy Remove the visible steering/refinement guidance shell from task Activity chat while preserving composer behavior. - Drop the TaskChatTab composer label/hint affordance and stale aria-describedby wiring. - Keep accessible form names and existing steering/refinement send flows intact. - Update dashboard docs, regression tests, and the published package changeset for the copy removal. Files changed: .changeset/fn-7343-task-chat-copy.md | 7 ++++ docs/dashboard-guide.md | 2 +- packages/dashboard/app/components/TaskChatTab.css | 29 --------------- packages/dashboard/app/components/TaskChatTab.tsx | 24 +++++-------- .../app/components/__tests__/TaskChatTab.test.tsx | 41 +++++++++++++--------- .../TaskDetailModal.task-activity-chat.test.tsx | 13 ++++--- .../components/__tests__/TaskDetailModal.test.tsx | 15 ++++---- 7 files changed, 59 insertions(+), 72 deletions(-) Fusion-Task-Id: FN-7343 Fusion-Task-Lineage: ebcffb2c-a42e-46af-8291-1ff77bcec2c6 Co-authored-by: Fusion (runfusion.ai) --- .changeset/fn-7343-task-chat-copy.md | 7 ++++ docs/dashboard-guide.md | 2 +- .../dashboard/app/components/TaskChatTab.css | 29 ------------- .../dashboard/app/components/TaskChatTab.tsx | 24 ++++------- .../components/__tests__/TaskChatTab.test.tsx | 41 +++++++++++-------- ...askDetailModal.task-activity-chat.test.tsx | 13 ++++-- .../__tests__/TaskDetailModal.test.tsx | 15 +++---- 7 files changed, 59 insertions(+), 72 deletions(-) create mode 100644 .changeset/fn-7343-task-chat-copy.md diff --git a/.changeset/fn-7343-task-chat-copy.md b/.changeset/fn-7343-task-chat-copy.md new file mode 100644 index 0000000000..f8ddfb1a54 --- /dev/null +++ b/.changeset/fn-7343-task-chat-copy.md @@ -0,0 +1,7 @@ +--- +"@runfusion/fusion": patch +--- + +summary: Remove the extra steering guidance copy from task Activity chat. +category: fix +dev: Keeps the Activity composer APIs intact while removing the visible TaskChatTab label/hint shell. diff --git a/docs/dashboard-guide.md b/docs/dashboard-guide.md index 95e5d0316b..e66dc6fef2 100644 --- a/docs/dashboard-guide.md +++ b/docs/dashboard-guide.md @@ -1120,7 +1120,7 @@ Recommended workflow: ordinary chains stay as `Blocks N` so noise stays low, hig -The **Activity** tab is the first task-detail tab by default and presents a segmented control for **Live**, **Feed**, and **Raw Logs**. Live contains the live, chat-styled transcript of task agent output. Consecutive entries are grouped by role and labeled as Planner, Executor, Reviewer, or Merger; legacy log rows without an agent role use the neutral Agent fallback. Agent group headers and user message headers show a small muted relative timestamp (for example, “just now”, “1m ago”, or “2h ago”) based on the transcript timestamp, while agent group metadata still includes the entry count. Consecutive text/message chunks inside a role group render as one continuous markdown bubble, while consecutive tool/tool-result/tool-error rows collapse into one expandable, compact tool-call summary that stays collapsed by default and mirrors regular Chat's dense treatment; the summary stays single-line/ellipsis-friendly on desktop and mobile, counts tool invocations, lists deduped tool names with overflow, and shows an error count when failures are present, while the expanded body pairs each call with its result or error in dense entry cards. Thinking entries render in a collapsible block that starts expanded. The transcript opens at the latest output whenever the tab loads or becomes active, then follows new live output when you are already near the bottom while preserving your scroll position when you review older messages. When older task-agent history exists, scrolling to the top or selecting **Load previous messages** prepends earlier transcript entries without moving the message you were reading. When you scroll away from the bottom of a populated transcript, a sticky **Latest** button appears inside the transcript so you can jump back to the newest message and resume live follow. For non-`done` tasks, the **Steering comment** composer sends guidance through the same steering path used by comments, including active planning/triage, `in-progress`, and `in-review` sessions, plus live CLI-agent sessions reported by the session bridge; an `in-review` Activity Live message or Comments-tab task comment re-engages an executor unless an open PR blocks moving the task back, and other messages are still saved as queued guidance when no session is currently live. Feed and Raw Logs do not show a steering composer. On a `done` task, the composer switches to **Refinement request** copy; sending starts a refinement task using the typed text as feedback and shows a success toast with the new task ID, while the current task detail modal remains on the completed task. The task-detail Activity Live segment keeps the composer pinned and visible on mobile and desktop while the transcript scrolls internally; its textarea placeholder reads “Steer the currently executing agent” for steering mode and switches to refinement copy for completed tasks, with the same inline, icon-only send affordance to the right of the input at every breakpoint. In the composer, plain **Enter** sends, **Shift+Enter** inserts a newline, and **Cmd/Ctrl+Enter** remains a supported send shortcut. +The **Activity** tab is the first task-detail tab by default and presents a segmented control for **Live**, **Feed**, and **Raw Logs**. Live contains the live, chat-styled transcript of task agent output. Consecutive entries are grouped by role and labeled as Planner, Executor, Reviewer, or Merger; legacy log rows without an agent role use the neutral Agent fallback. Agent group headers and user message headers show a small muted relative timestamp (for example, “just now”, “1m ago”, or “2h ago”) based on the transcript timestamp, while agent group metadata still includes the entry count. Consecutive text/message chunks inside a role group render as one continuous markdown bubble, while consecutive tool/tool-result/tool-error rows collapse into one expandable, compact tool-call summary that stays collapsed by default and mirrors regular Chat's dense treatment; the summary stays single-line/ellipsis-friendly on desktop and mobile, counts tool invocations, lists deduped tool names with overflow, and shows an error count when failures are present, while the expanded body pairs each call with its result or error in dense entry cards. Thinking entries render in a collapsible block that starts expanded. The transcript opens at the latest output whenever the tab loads or becomes active, then follows new live output when you are already near the bottom while preserving your scroll position when you review older messages. When older task-agent history exists, scrolling to the top or selecting **Load previous messages** prepends earlier transcript entries without moving the message you were reading. When you scroll away from the bottom of a populated transcript, a sticky **Latest** button appears inside the transcript so you can jump back to the newest message and resume live follow. For non-`done` tasks, the Activity Live composer sends typed guidance through the same steering path used by comments, including active planning/triage, `in-progress`, and `in-review` sessions, plus live CLI-agent sessions reported by the session bridge; an `in-review` Activity Live message or Comments-tab task comment re-engages an executor unless an open PR blocks moving the task back, and other messages are still saved as queued guidance when no session is currently live. Feed and Raw Logs do not show the composer. On a `done` task, the same composer starts a refinement task using the typed text as feedback and shows a success toast with the new task ID, while the current task detail modal remains on the completed task. The task-detail Activity Live segment keeps the composer pinned and visible on mobile and desktop while the transcript scrolls internally; its textarea placeholder reads “Steer the currently executing agent” for steering mode and switches to refinement copy for completed tasks, with the same inline, icon-only send affordance to the right of the input at every breakpoint. In the composer, plain **Enter** sends, **Shift+Enter** inserts a newline, and **Cmd/Ctrl+Enter** remains a supported send shortcut. The top-level **Chat** tab opens the planner-model conversation for the same task instead of posting steering comments. It appears after Activity by default, or before Activity when **Settings → Appearance → Open task details with Chat first** is enabled. Each send includes server-built, bounded context for the task id, status/column/progress/current step, dependencies, recent activity/comment excerpts, prompt/plan content, and available source/review state; unavailable sections are labeled so the planner states uncertainty rather than inventing execution evidence. Opening the tab with no existing history does not create a database chat row; when no planner-chat history is found, Chat shows a guided empty state with starter prompts for recent activity, current status/blockers, next best action, and plan/definition review. Selecting a starter creates/resumes the planner chat and sends that prompt as an ordinary chat message through the task-context-aware planner-chat composer/stream path. The starter prompts disappear while history is loading or after conversation history exists, so Activity Live, Feed, Raw Logs, and the steering composer remain separate. Planner Chat defaults to focused mode, keeps its composer visible at the bottom while only the transcript scrolls, and on narrow/mobile task-detail layouts collapses nonessential rows above the chat until the user selects the Chat collapse control. diff --git a/packages/dashboard/app/components/TaskChatTab.css b/packages/dashboard/app/components/TaskChatTab.css index 77e55900dc..22bd092fe9 100644 --- a/packages/dashboard/app/components/TaskChatTab.css +++ b/packages/dashboard/app/components/TaskChatTab.css @@ -481,25 +481,6 @@ FN-7241 adds timestamps inside individual task-detail transcript blocks. Keep bl padding: var(--space-sm) var(--space-md); } -.task-chat-composer-affordance { - display: flex; - align-items: baseline; - justify-content: space-between; - gap: var(--space-sm); - min-width: 0; -} - -.task-chat-composer-label { - color: var(--text); - font-weight: 600; -} - -.task-chat-composer-hint { - color: var(--text-muted); - font-size: var(--space-md); - text-align: right; -} - .task-chat-composer-row { display: flex; align-items: flex-end; @@ -637,16 +618,6 @@ FN-6660 corrects the repeated mobile sizing misses from FN-6507, FN-6604, and FN padding: var(--space-xs) var(--space-sm); } - .task-chat-composer-affordance { - align-items: flex-start; - flex-direction: column; - gap: calc(var(--space-xs) / 2); - } - - .task-chat-composer-hint { - text-align: left; - } - .task-chat-composer-row { align-items: flex-end; gap: var(--space-xs); diff --git a/packages/dashboard/app/components/TaskChatTab.tsx b/packages/dashboard/app/components/TaskChatTab.tsx index fda32aa0fd..20ee58b30e 100644 --- a/packages/dashboard/app/components/TaskChatTab.tsx +++ b/packages/dashboard/app/components/TaskChatTab.tsx @@ -1,5 +1,5 @@ import type { AgentLogEntry, AgentRole, SteeringComment, Task, TaskDetail } from "@fusion/core"; -import React, { useCallback, useId, useLayoutEffect, useMemo, useRef, useState } from "react"; +import React, { useCallback, useLayoutEffect, useMemo, useRef, useState } from "react"; import ReactMarkdown from "react-markdown"; import remarkGfm from "remark-gfm"; import { ChevronDown, Cpu, Loader2, Maximize2, Minimize2, Send } from "lucide-react"; @@ -582,7 +582,6 @@ export function TaskChatTab({ task, projectId, active, addToast, onTaskUpdated, const previousActiveRef = useRef(false); const anchorFrameRef = useRef(null); const textareaRef = useRef(null); - const composerHintId = useId(); const userMessages = useMemo( () => mergeUserMessages(task.steeringComments, optimisticMessages), @@ -594,14 +593,14 @@ export function TaskChatTab({ task, projectId, active, addToast, onTaskUpdated, const isDoneTask = task.column === "done"; /* * FNXC:TaskDetailActivity 2026-06-30-21:51: - * Activity → Live (legacy `current`) is the operational steering surface for task execution. Show an explicit steering-comment affordance here while keeping the top-level planner-model Chat tab separate; Feed and Raw Logs remain read-only Activity segments without this composer. + * Activity → Live (legacy `current`) is the operational steering surface for task execution. Keep the top-level planner-model Chat tab separate; Feed and Raw Logs remain read-only Activity segments without this composer. + * + * FNXC:TaskDetailActivity 2026-06-30-23:59: + * Task Activity must keep the operational composer and existing steering/refinement APIs while removing the visible steering-comment guidance label/hint block from task chat. Use non-visible accessible names on the form/textarea/button so the removed copy does not leave a UI shell or dangling aria-describedby reference. */ - const composerLabel = isDoneTask - ? t("taskChat.refinementComposerLabel", "Refinement request") - : t("taskChat.steeringComposerLabel", "Steering comment"); - const composerHint = isDoneTask - ? t("taskChat.refinementComposerHint", "Create a follow-up refinement task from this completed task.") - : t("taskChat.steeringComposerHint", "Send operational guidance to the active task through steering comments."); + const composerFormLabel = isDoneTask + ? t("taskChat.refinementComposerFormLabel", "Task refinement composer") + : t("taskChat.activityComposerFormLabel", "Task activity composer"); const composerPlaceholder = isDoneTask ? t("taskChat.donePlaceholder", "Start a refinement task for this completed task") : t("taskChat.activePlaceholder", "Steer the currently executing agent"); @@ -938,11 +937,7 @@ export function TaskChatTab({ task, projectId, active, addToast, onTaskUpdated, ) : null} -
-
- {composerLabel} - {composerHint} -
+