root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(FN-3280): harden reviewState persistence, API, and PR feedback sync

Browse Source 
Merges reviewState hardening (FN-3280 steps 2-3: hardened persistence, API fixes, and PR feedback sync), stepIndex reconciliation for task updates (FN-3757), roadmap route context extraction into the fusion-plugin-roadmap plugin (FN-3160), and shared state snapshots for mesh sync with autostash hard

Fusion-Task-Id: FN-3280
This commit is contained in:
Fusion
2026-05-08 16:23:10 -07:00
committed by gsxdsm
parent d487eeaf36
commit 60962765bf
17 changed files with 136 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packages/core/src/__tests__/agent-store.test.ts
View File

@@ -2909,7 +2909,8 @@ describe("AgentStore", () => {
expect(agentSnapshot2.payload).toEqual(agentSnapshot.payload);
expect(runSnapshot2.payload).toEqual(runSnapshot.payload);
expect(limitedRunSnapshot.payload.runs).toHaveLength(1);
expect(limitedRunSnapshot.payload.runs[0]?.id).toBe(run2.id);
const limitedRunId = limitedRunSnapshot.payload.runs[0]?.id;
expect([run1.id, run2.id]).toContain(limitedRunId);
expect(applyRun.applied + applyRun.skipped).toBeGreaterThanOrEqual(0);
});
});

30
packages/core/src/__tests__/db.test.ts
View File

@@ -159,7 +159,7 @@ describe("Database", () => {
});
it("seeds schema version", () => {
expect(db.getSchemaVersion()).toBe(68);
expect(db.getSchemaVersion()).toBe(69);
});
it("seeds lastModified", () => {
const ts = db.getLastModified();
@@ -181,7 +181,7 @@ describe("Database", () => {
it("is idempotent - calling init() twice does not fail", () => {
expect(() => db.init()).not.toThrow();
expect(db.getSchemaVersion()).toBe(68);
expect(db.getSchemaVersion()).toBe(69);
});
it("does not overwrite existing config on re-init", () => {
// Update the config
@@ -954,7 +954,7 @@ describe("schema migrations", () => {
db.init();
// Verify version bumped to 29 (includes v1→v2 through v26→v29)
expect(db.getSchemaVersion()).toBe(68);
expect(db.getSchemaVersion()).toBe(69);
// Verify new columns exist and existing data is intact
const cols = db.prepare("PRAGMA table_info(tasks)").all() as Array<{ name: string }>;
@@ -979,11 +979,11 @@ describe("schema migrations", () => {
const db = new Database(fusionDir);
db.init();
expect(db.getSchemaVersion()).toBe(68);
expect(db.getSchemaVersion()).toBe(69);
// Re-init should not fail
db.init();
expect(db.getSchemaVersion()).toBe(68);
expect(db.getSchemaVersion()).toBe(69);
db.close();
});
@@ -1018,7 +1018,7 @@ describe("schema migrations", () => {
db.init();
expect(db.getSchemaVersion()).toBe(68);
expect(db.getSchemaVersion()).toBe(69);
const cols = db.prepare("PRAGMA table_info(tasks)").all() as Array<{ name: string }>;
expect(cols.map((col) => col.name)).toContain("priority");
@@ -1059,7 +1059,7 @@ describe("schema migrations", () => {
db.init();
expect(db.getSchemaVersion()).toBe(68);
expect(db.getSchemaVersion()).toBe(69);
const cols = db.prepare("PRAGMA table_info(tasks)").all() as Array<{ name: string }>;
const colNames = cols.map((col) => col.name);
@@ -1128,7 +1128,7 @@ describe("schema migrations", () => {
db.init();
expect(db.getSchemaVersion()).toBe(68);
expect(db.getSchemaVersion()).toBe(69);
const cols = db.prepare("PRAGMA table_info(tasks)").all() as Array<{ name: string }>;
const colNames = cols.map((col) => col.name);
@@ -1231,7 +1231,7 @@ describe("schema migrations", () => {
db.init();
expect(db.getSchemaVersion()).toBe(68);
expect(db.getSchemaVersion()).toBe(69);
const cols = db.prepare("PRAGMA table_info(chat_messages)").all() as Array<{ name: string }>;
expect(cols.map((col) => col.name)).toContain("attachments");
@@ -1305,7 +1305,7 @@ describe("schema migrations", () => {
db.init();
expect(db.getSchemaVersion()).toBe(68);
expect(db.getSchemaVersion()).toBe(69);
const tables = db.prepare("SELECT name FROM sqlite_master WHERE type='table' AND name = 'agentRatings'").all() as Array<{ name: string }>;
expect(tables).toEqual([{ name: "agentRatings" }]);
@@ -1329,7 +1329,7 @@ describe("schema migrations", () => {
db.init();
expect(db.getSchemaVersion()).toBe(68);
expect(db.getSchemaVersion()).toBe(69);
const tables = db.prepare("SELECT name FROM sqlite_master WHERE type='table' AND name = 'mission_events'").all() as Array<{ name: string }>;
expect(tables).toEqual([{ name: "mission_events" }]);
@@ -1433,7 +1433,7 @@ describe("schema migrations", () => {
db.init();
// Verify version bumped to 29
expect(db.getSchemaVersion()).toBe(68);
expect(db.getSchemaVersion()).toBe(69);
// Verify new columns exist and existing data is intact
const cols = db.prepare("PRAGMA table_info(tasks)").all() as Array<{ name: string }>;
@@ -1902,7 +1902,7 @@ describe("createDatabase factory", () => {
const db = createDatabase(fusionDir);
db.init();
expect(db.getSchemaVersion()).toBe(68);
expect(db.getSchemaVersion()).toBe(69);
expect(db.getLastModified()).toBeGreaterThan(0);
db.close();
@@ -2035,7 +2035,7 @@ describe("migration v67 drops orphan project auth tables", () => {
const migrated = new Database(fusion);
migrated.init();
expect(migrated.getSchemaVersion()).toBe(68);
expect(migrated.getSchemaVersion()).toBe(69);
const tables = migrated
.prepare("SELECT name FROM sqlite_master WHERE type='table' AND name LIKE 'project_auth_%'")
.all() as Array<{ name: string }>;
@@ -2049,7 +2049,7 @@ describe("migration v67 drops orphan project auth tables", () => {
const fusion = join(temp, ".fusion");
const fresh = new Database(fusion);
fresh.init();
expect(fresh.getSchemaVersion()).toBe(68);
expect(fresh.getSchemaVersion()).toBe(69);
const tables = fresh
.prepare("SELECT name FROM sqlite_master WHERE type='table' AND name LIKE 'project_auth_%'")
.all() as Array<{ name: string }>;

10
packages/core/src/__tests__/insight-store.test.ts
View File

@@ -886,7 +886,7 @@ describe("Migration: pre-33 DB upgrade", () => {
// Step 1: Create a fresh database at v33 (runs all migrations up to 33)
const db1 = createDatabase(legacyDir);
db1.init();
expect(db1.getSchemaVersion()).toBe(68);
expect(db1.getSchemaVersion()).toBe(69);
db1.close();
// Step 2: Manually downgrade to version 32 and drop insight tables
@@ -921,7 +921,7 @@ describe("Migration: pre-33 DB upgrade", () => {
expect(tableNamesBefore).not.toContain("project_insight_runs");
// Now run init — this triggers the v32→v33 migration
db3.init();
expect(db3.getSchemaVersion()).toBe(68);
expect(db3.getSchemaVersion()).toBe(69);
// Step 4: Verify insight tables exist after migration
const tablesAfter = db3.prepare(
@@ -952,12 +952,12 @@ describe("Migration: pre-33 DB upgrade", () => {
try {
const db1 = createDatabase(testDir);
db1.init();
expect(db1.getSchemaVersion()).toBe(68);
expect(db1.getSchemaVersion()).toBe(69);
db1.close();
const db2 = createDatabase(testDir);
expect(() => db2.init()).not.toThrow();
expect(db2.getSchemaVersion()).toBe(68);
expect(db2.getSchemaVersion()).toBe(69);
db2.close();
} finally {
rmSync(testDir, { recursive: true, force: true });
@@ -971,7 +971,7 @@ describe("Migration: pre-33 DB upgrade", () => {
// Step 1: Create a fresh DB and run migrations
const db1 = createDatabase(compatDir);
db1.init();
expect(db1.getSchemaVersion()).toBe(68);
expect(db1.getSchemaVersion()).toBe(69);
// Step 2: Strip lifecycle and cancelledAt columns by recreating the
// table without them. This simulates a DB that was created before the

2
packages/core/src/__tests__/mission-store.test.ts
View File

@@ -2629,7 +2629,7 @@ describe("MissionStore", () => {
describe("Loop State & Validator Run Schema (v31)", () => {
it("schema version is 40 after migration", () => {
expect(db.getSchemaVersion()).toBe(68);
expect(db.getSchemaVersion()).toBe(69);
});
it("mission_features table has loop state columns", () => {

2
packages/core/src/__tests__/run-audit.test.ts
View File

@@ -465,7 +465,7 @@ describe("Run Audit", () => {
});
it("schema version is bumped to 40", () => {
expect(db.getSchemaVersion()).toBe(68);
expect(db.getSchemaVersion()).toBe(69);
});
});
});

15
packages/core/src/__tests__/store.test.ts
View File

@@ -4181,6 +4181,21 @@ describe("TaskStore", () => {
expect(cleared.review).toBeUndefined();
});
it("persists reviewState independently from legacy review", async () => {
const created = await store.createTask({ description: "Task with review state" });
const reviewState: NonNullable<Task["reviewState"]> = {
source: "pull-request",
summary: { reviewDecision: "CHANGES_REQUESTED", reviewers: [], blockingReasons: [], checks: [] },
items: [{ id: "ri-1", body: "Fix this", author: { login: "octocat" }, createdAt: new Date().toISOString() }],
addressing: [{ itemId: "ri-1", status: "queued", selectedAt: new Date().toISOString() }],
};
await store.updateTask(created.id, { reviewState });
const reloaded = await store.getTask(created.id);
expect(reloaded.reviewState).toEqual(reviewState);
expect(reloaded.review).toBeUndefined();
});
it("preserves review metadata through archive and unarchive", async () => {
const review: NonNullable<Task["review"]> = {
mode: "pull-request",

2
packages/core/src/__tests__/task-documents.test.ts
View File

@@ -51,7 +51,7 @@ describe("TaskStore task documents", () => {
expect(tableNames.has("task_documents")).toBe(true);
expect(tableNames.has("task_document_revisions")).toBe(true);
expect(db.getSchemaVersion()).toBe(68);
expect(db.getSchemaVersion()).toBe(69);
const index = db
.prepare(

9
packages/core/src/db.ts
View File

@@ -88,7 +88,7 @@ export function probeFts5(db: DatabaseSync): boolean {
// ── Schema Definition ────────────────────────────────────────────────
const SCHEMA_VERSION = 68;
const SCHEMA_VERSION = 69;
function normalizeTaskComments(
steeringComments: SteeringComment[] | undefined,
@@ -202,6 +202,7 @@ CREATE TABLE IF NOT EXISTS tasks (
steeringComments TEXT DEFAULT '[]',
comments TEXT DEFAULT '[]',
review TEXT,
reviewState TEXT,
workflowStepResults TEXT DEFAULT '[]',
prInfo TEXT,
issueInfo TEXT,
@@ -2629,6 +2630,12 @@ export class Database {
});
}
if (version < 69) {
this.applyMigration(69, () => {
this.addColumnIfMissing("tasks", "reviewState", "TEXT");
});
}
}
/**

15
packages/core/src/store.ts
View File

@@ -91,6 +91,7 @@ interface TaskRow {
steeringComments: string | null;
comments: string | null;
review: string | null;
reviewState: string | null;
workflowStepResults: string | null;
prInfo: string | null;
issueInfo: string | null;
@@ -753,7 +754,7 @@ export class TaskStore extends EventEmitter<TaskStoreEvents> {
return deduped.length > 0 ? deduped : undefined;
})(),
review: fromJson<import("./types.js").TaskReview>(row.review) ?? undefined,
reviewState: fromJson<import("./types.js").TaskReviewState>(row.review) ?? undefined,
reviewState: fromJson<import("./types.js").TaskReviewState>(row.reviewState) ?? undefined,
workflowStepResults: (() => { const w = fromJson<import("./types.js").WorkflowStepResult[]>(row.workflowStepResults); return w && w.length > 0 ? w : undefined; })(),
prInfo: fromJson<import("./types.js").PrInfo>(row.prInfo),
issueInfo: fromJson<import("./types.js").IssueInfo>(row.issueInfo),
@@ -1020,7 +1021,7 @@ export class TaskStore extends EventEmitter<TaskStoreEvents> {
"error", "summary", "thinkingLevel", "executionMode",
"tokenUsageInputTokens", "tokenUsageOutputTokens", "tokenUsageCachedTokens", "tokenUsageTotalTokens", "tokenUsageFirstUsedAt", "tokenUsageLastUsedAt",
"createdAt", "updatedAt", "columnMovedAt", "executionStartedAt", "executionCompletedAt",
"dependencies", "steps", "comments", "review", "workflowStepResults", "steeringComments",
"dependencies", "steps", "comments", "review", "reviewState", "workflowStepResults", "steeringComments",
"attachments", "prInfo", "issueInfo", "sourceIssueProvider", "sourceIssueRepository", "sourceIssueExternalIssueId", "sourceIssueNumber", "sourceIssueUrl", "mergeDetails",
"breakIntoSubtasks", "enabledWorkflowSteps", "modifiedFiles",
"missionId", "sliceId", "assignedAgentId", "pausedByAgentId", "assigneeUserId", "nodeId", "effectiveNodeId", "effectiveNodeSource",
@@ -1070,7 +1071,7 @@ export class TaskStore extends EventEmitter<TaskStoreEvents> {
"tokenUsageInputTokens", "tokenUsageOutputTokens", "tokenUsageCachedTokens", "tokenUsageTotalTokens", "tokenUsageFirstUsedAt", "tokenUsageLastUsedAt",
"createdAt", "updatedAt", "columnMovedAt", "executionStartedAt", "executionCompletedAt",
"dependencies", "steps", "attachments", "steeringComments",
"comments", "review", "workflowStepResults", "prInfo", "issueInfo", "sourceIssueProvider", "sourceIssueRepository", "sourceIssueExternalIssueId", "sourceIssueNumber", "sourceIssueUrl", "mergeDetails",
"comments", "review", "reviewState", "workflowStepResults", "prInfo", "issueInfo", "sourceIssueProvider", "sourceIssueRepository", "sourceIssueExternalIssueId", "sourceIssueNumber", "sourceIssueUrl", "mergeDetails",
"breakIntoSubtasks", "enabledWorkflowSteps", "modifiedFiles",
"missionId", "sliceId", "assignedAgentId", "pausedByAgentId", "assigneeUserId", "nodeId", "effectiveNodeId", "effectiveNodeSource",
"sourceType", "sourceAgentId", "sourceRunId", "sourceSessionId", "sourceMessageId", "sourceParentTaskId", "sourceMetadata",
@@ -1113,11 +1114,11 @@ export class TaskStore extends EventEmitter<TaskStoreEvents> {
tokenUsageTotalTokens, tokenUsageFirstUsedAt, tokenUsageLastUsedAt, createdAt, updatedAt, columnMovedAt,
executionStartedAt, executionCompletedAt,
dependencies, steps, log, attachments, steeringComments,
comments, review, workflowStepResults, prInfo, issueInfo,
comments, review, reviewState, workflowStepResults, prInfo, issueInfo,
sourceIssueProvider, sourceIssueRepository, sourceIssueExternalIssueId, sourceIssueNumber, sourceIssueUrl,
mergeDetails, breakIntoSubtasks, enabledWorkflowSteps, modifiedFiles, missionId, sliceId, assignedAgentId, pausedByAgentId, assigneeUserId, nodeId, effectiveNodeId, effectiveNodeSource, sourceType, sourceAgentId, sourceRunId, sourceSessionId, sourceMessageId, sourceParentTaskId, sourceMetadata, checkedOutBy, checkedOutAt
) VALUES (
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?
)
ON CONFLICT(id) DO UPDATE SET
title = excluded.title,
@@ -1173,6 +1174,7 @@ export class TaskStore extends EventEmitter<TaskStoreEvents> {
steeringComments = excluded.steeringComments,
comments = excluded.comments,
review = excluded.review,
reviewState = excluded.reviewState,
workflowStepResults = excluded.workflowStepResults,
prInfo = excluded.prInfo,
issueInfo = excluded.issueInfo,
@@ -1256,7 +1258,8 @@ export class TaskStore extends EventEmitter<TaskStoreEvents> {
toJson(task.attachments || []),
toJson(task.steeringComments || []),
toJson(task.comments || []),
toJsonNullable(task.reviewState ?? task.review),
toJsonNullable(task.review),
toJsonNullable(task.reviewState),
toJson(task.workflowStepResults || []),
toJsonNullable(task.prInfo),
toJsonNullable(task.issueInfo),

1
packages/core/src/types.ts
View File

@@ -885,7 +885,6 @@ export interface TaskReviewStateItem {
verdict?: TaskReviewVerdict;
step?: number;
summary?: string;
addressingStatus?: TaskReviewItemStatus;
}
export interface ReviewAddressingRecord {