From 6111a6e3f2f501f2435ec9258933affa5cce35f0 Mon Sep 17 00:00:00 2001 From: gsxdsm Date: Thu, 23 Jul 2026 00:00:45 -0700 Subject: [PATCH] fix(ci): full-suite bookkeeping v31 after origin/main (#2408) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Summary Restore full-suite green after latest `origin/main` landings. PR #2392 already merged; this branch starts from current main. - **ExecutorStatusBar mobile utility test:** assert `Waiting` (product rename from Queued) and that the In Review segment is gone. - **AppearanceSection task-popup help:** assert FN-8478 fallback copy (board deep-tab chips + List row/card + right-dock → movable popup). - **Changeset format gate:** shorten `mobile-board-pointercancel-settle.md` summary to ≤120 chars (was blocking `pnpm test:gate` on main). ## Context Latest main Full Suite run failed primarily on dashboard app quality backfill: - https://github.com/Runfusion/Fusion/actions/runs/29970703115 ## Test plan - [x] `pnpm test:gate` ×2 - [x] `utility-mobile.test.tsx` + `AppearanceSection.test.tsx` - [x] `settings-default-descriptions.test.tsx` - [ ] CI PR checks / Full Suite on this branch ## Summary by CodeRabbit * **Bug Fixes** * Improved mobile board column snapping when resting mid-screen, flinging past columns, or making unintended swipes. * Updated task status labels to show “Waiting,” “Running,” and “Blocked.” * Refined help text for opening tasks as popups, including click-target and subsequent-task behavior. --- .../components/__tests__/utility-mobile.test.tsx | 10 ++++++++-- .../sections/__tests__/AppearanceSection.test.tsx | 15 +++++++++++---- 2 files changed, 19 insertions(+), 6 deletions(-) diff --git a/packages/dashboard/app/components/__tests__/utility-mobile.test.tsx b/packages/dashboard/app/components/__tests__/utility-mobile.test.tsx index 6840b2030f..387d6724fe 100644 --- a/packages/dashboard/app/components/__tests__/utility-mobile.test.tsx +++ b/packages/dashboard/app/components/__tests__/utility-mobile.test.tsx @@ -67,13 +67,19 @@ describe("Utility component mobile adaptations", () => { }); it("renders ExecutorStatusBar segments", () => { + /* + FNXC:DashboardTests 2026-07-22-18:20: + ExecutorStatusBar ships Waiting (not Queued) for intake/hold and no longer + renders an In Review segment — align mobile utility coverage with ExecutorStatusBar.tsx. + */ render(); const bar = screen.getByRole("status"); + expect(bar).toHaveTextContent("Waiting"); expect(bar).toHaveTextContent("Running"); expect(bar).toHaveTextContent("Blocked"); - expect(bar).toHaveTextContent("Queued"); - expect(bar).toHaveTextContent("In Review"); + expect(bar).not.toHaveTextContent("Queued"); + expect(bar).not.toHaveTextContent("In Review"); }); it("renders ActiveAgentsPanel grid and cards when agents are provided", () => { diff --git a/packages/dashboard/app/components/settings/sections/__tests__/AppearanceSection.test.tsx b/packages/dashboard/app/components/settings/sections/__tests__/AppearanceSection.test.tsx index 826f1dc42e..ade3f33009 100644 --- a/packages/dashboard/app/components/settings/sections/__tests__/AppearanceSection.test.tsx +++ b/packages/dashboard/app/components/settings/sections/__tests__/AppearanceSection.test.tsx @@ -71,11 +71,18 @@ describe("AppearanceSection", () => { expect(checkbox).not.toBeChecked(); /* FNXC:MobileTaskPopups 2026-07-15-17:35: - This assertion tracked copy that FN-7945 deliberately rewrote — the setting became all-viewport, so the help text gained "List row/card" and the popup became "movable" — and it had been failing against the shipped string ever since. - Realigned to the copy the section actually renders rather than deleted: the requirement (the help text must state which click targets route to the popup) is still worth asserting, and dropping it would leave the copy uncovered. + Help text must state which click targets route to the popup. + + FNXC:DashboardTests 2026-07-22-18:20: + AppearanceSection.tsx t() fallback (and FN-8478) documents board task-card deep-tab chips + plus List row/card and right-dock Tasks-list → movable task popup. Assert the live help body. */ - expect(screen.getByText(/ordinary board task-card, List row\/card, and right-dock Tasks-list clicks open the existing movable task popup/)).toBeInTheDocument(); - expect(screen.getByText(/Deep-tab and other task opens keep their current behavior/)).toBeInTheDocument(); + expect( + screen.getByText( + /board task-card clicks including Changes, Retries, and Workflow chips, plus ordinary List row\/card and right-dock Tasks-list clicks, open the existing movable task popup/, + ), + ).toBeInTheDocument(); + expect(screen.getByText(/Other task opens keep their current behavior/)).toBeInTheDocument(); fireEvent.click(checkbox);