root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(FN-4482): harden scope guard typing and prompt source

Browse Source 
Fusion-Task-Id: FN-4482
Fusion-Task-Lineage: 5850cda2-ded5-42ac-a206-396839580748
This commit is contained in:
Fusion
2026-05-14 14:21:16 -07:00
committed by gsxdsm
parent ffd274d646
commit 61cfb115c0
2 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/engine/src/__tests__/executor-plan-only-scope-leak.test.ts
View File

@@ -91,7 +91,7 @@ describe("FN-4482 plan-only scope leak guard", () => {
const { store, tool } = await setup({ unstaged: ["docs/foo.md"] });
const result = await tool.execute("id", {});
expect(result.content[0].text).toContain("Task marked complete");
expect(store.logEntry.mock.calls.some(([_, message]) => String(message).includes("[scope-leak] reviewLevel="))).toBe(false);
expect(store.logEntry.mock.calls.some((call: unknown[]) => String(call[1]).includes("[scope-leak] reviewLevel="))).toBe(false);
});
it("warns but allows plan-only off-scope edits in default warn mode", async () => {
@@ -131,7 +131,7 @@ describe("FN-4482 plan-only scope leak guard", () => {
const { store, tool } = await setup({ enforcement: "off", unstaged: ["packages/core/src/db.ts"] });
const result = await tool.execute("id", {});
expect(result.content[0].text).toContain("Task marked complete");
expect(store.logEntry.mock.calls.some(([_, message]) => String(message).includes("[scope-leak] reviewLevel="))).toBe(false);
expect(store.logEntry.mock.calls.some((call: unknown[]) => String(call[1]).includes("[scope-leak] reviewLevel="))).toBe(false);
});
it.each([0, 2])("uses warn-only behavior for non-plan-only review level %s", async (reviewLevel) => {
@@ -151,6 +151,6 @@ describe("FN-4482 plan-only scope leak guard", () => {
const result = await tool.execute("id", {});
expect(result.content[0].text).toContain("Task marked complete");
expect((executorLog.warn as any).mock.calls.some(([message]: [string]) => message.includes("Failed to capture uncommitted modified files"))).toBe(true);
expect(store.logEntry.mock.calls.some(([_, message]) => String(message).includes("[scope-leak] reviewLevel="))).toBe(false);
expect(store.logEntry.mock.calls.some((call: unknown[]) => String(call[1]).includes("[scope-leak] reviewLevel="))).toBe(false);
});
});