root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(FN-5245): swallow deleted-task races in GitHub tracking services

Browse Source 
Fixes a race condition where task deletion could race against move-related GitHub tracking logs. Both `GitHubTrackingCommentService` and `GitHubTrackingStateService.handleTaskMoved` are hardened to gracefully swallow deleted-task races, with a regression test covering the delete-after-move scenario.

Fusion-Task-Id: FN-5245
This commit is contained in:
Fusion (runfusion.ai)
2026-05-20 04:32:21 -07:00
committed by gsxdsm
parent 1b49cbc94d
commit 646e546ef5
3 changed files with 58 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
packages/dashboard/src/github-tracking-state.ts
View File

@@ -140,7 +140,8 @@ export class GitHubTrackingStateService {
const { owner, repo, number } = issue;
if (!owner || !repo || !number) {
await store.logEntry(
await this.safeLogDeletedTaskEntry(
store,
event.task.id,
"Failed to update GitHub tracking issue state",
"Linked issue metadata is incomplete",
@@ -153,7 +154,7 @@ export class GitHubTrackingStateService {
const globalSettings = (await store.getGlobalSettingsStore?.()?.getSettings?.() ?? {}) as Pick<GlobalSettings, never>;
const resolution = resolveGithubTrackingAuth({ projectSettings, globalSettings });
if (!resolution.ok) {
await store.logEntry(event.task.id, "Skipped GitHub tracking issue state update", resolution.message);
await this.safeLogDeletedTaskEntry(store, event.task.id, "Skipped GitHub tracking issue state update", resolution.message);
return;
}
@@ -164,7 +165,7 @@ export class GitHubTrackingStateService {
if (decision.action === "close") {
const existing = await client.getIssue(owner, repo, number);
if (existing?.state === "closed") {
await store.logEntry(event.task.id, "Linked GitHub tracking issue already closed", `${owner}/${repo}#${number}`);
await this.safeLogDeletedTaskEntry(store, event.task.id, "Linked GitHub tracking issue already closed", `${owner}/${repo}#${number}`);
return;
}
}
@@ -189,7 +190,8 @@ export class GitHubTrackingStateService {
await updateIssueState();
}
await store.logEntry(
await this.safeLogDeletedTaskEntry(
store,
event.task.id,
decision.action === "close"
? "Closed linked GitHub tracking issue"
@@ -197,7 +199,8 @@ export class GitHubTrackingStateService {
`${owner}/${repo}#${number}`,
);
} catch (err) {
await store.logEntry(
await this.safeLogDeletedTaskEntry(
store,
event.task.id,
decision.action === "close"
? "Failed to close GitHub tracking issue"