root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix(cli): guarantee TUI quit exits even if graceful shutdown stalls

Browse Source 
Pressing q/Ctrl+C in the TUI routes through SIGINT so the dashboard's
graceful shutdown runs (kills dev-server process groups, engines, mesh,
central-core). That shutdown awaits several teardown steps with no
timeout, so a single hung step left process.exit(0) unreachable: the
process never exited and the still-alive dashboard kept writing output
onto the restored shell. The shutdownInProgress guard also swallowed
repeat signals, so mashing q could not escape.

Both shutdown() and devShutdown() now arm an unref'd 3s hard-exit
watchdog on the first signal and force an immediate process.exit(0) on a
second signal.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
gsxdsm
2026-06-27 13:22:28 -07:00
parent 39d20be05f
commit 661b6b8a47
2 changed files with 37 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
.changeset/tui-quit-hard-exit.md Normal file
View File

@@ -0,0 +1,7 @@
---
"@runfusion/fusion": patch
---
summary: Pressing q (or Ctrl+C) in the TUI now always quits, even if a teardown step stalls.
category: fix
dev: dashboard.ts shutdown/devShutdown arm an unref'd 3s hard-exit watchdog on the first signal and force an immediate process.exit(0) on a second signal, so a hung stopAllDevServers/engine/central-core teardown can no longer leave the process alive repainting the restored shell.

32
packages/cli/src/commands/dashboard.ts
View File

@@ -1097,6 +1097,28 @@ export async function runDashboard(port: number, opts: { paused?: boolean; dev?:
let disposed = false;
let shutdownInProgress = false;
/*
* FNXC:DashboardShutdown 2026-06-27-10:32:
* Pressing `q`/Ctrl+C in the TUI routes through SIGINT so the graceful shutdown
* runs (kills dev-server process groups, engines, mesh, central-core). That
* shutdown awaits several teardown steps with no timeout, so a single hung step
* (a dev-server child that won't die, an in-flight engine merge, a stuck
* central-core close) left `process.exit(0)` unreachable: the process never
* exited, and because the alt-screen was already restored the still-alive
* dashboard kept writing output onto the user's shell ("the TUI keeps rendering
* what happened"). The `shutdownInProgress` guard also swallowed repeat signals,
* so mashing `q` could not escape.
*
* Guarantee exit two ways: (1) arm a hard-exit watchdog the moment shutdown
* begins so any hung teardown step still force-exits within the grace window,
* and (2) let a second signal force an immediate exit. The watchdog is unref'd
* so it never itself keeps the process alive.
*/
const SHUTDOWN_HARD_EXIT_GRACE_MS = 3000;
function armHardExitWatchdog(): void {
setTimeout(() => process.exit(0), SHUTDOWN_HARD_EXIT_GRACE_MS).unref();
}
async function logShutdownDiagnostics(reason: string): Promise<void> {
const uptimeSeconds = Math.round((Date.now() - dashboardStartedAt) / 1000);
let taskSummary = "tasks=unknown";
@@ -1913,8 +1935,11 @@ export async function runDashboard(port: number, opts: { paused?: boolean; dev?:
});
const shutdown = async (signal: NodeJS.Signals) => {
if (shutdownInProgress) return;
// Second signal (user mashing q/Ctrl+C because the first didn't exit) —
// force an immediate exit rather than being swallowed by the guard.
if (shutdownInProgress) process.exit(0);
shutdownInProgress = true;
armHardExitWatchdog();
// Log active handles at shutdown for diagnostics
const handleTypes: Record<string, number> = {};
@@ -2243,8 +2268,11 @@ export async function runDashboard(port: number, opts: { paused?: boolean; dev?:
// UI-only mode: simplified shutdown handlers (no engine components)
if (noEngine) {
const devShutdown = async (signal: NodeJS.Signals) => {
if (shutdownInProgress) return;
// Second signal (user mashing q/Ctrl+C because the first didn't exit) —
// force an immediate exit rather than being swallowed by the guard.
if (shutdownInProgress) process.exit(0);
shutdownInProgress = true;
armHardExitWatchdog();
// Log active handles at shutdown for diagnostics
const handleTypes: Record<string, number> = {};