feat(FN-1171): add agent soul memory and employees workflows
- Add soul and memory fields to agent types and AgentStore with persistence/update test coverage - Add dashboard routes and API helpers to fetch and update agent soul/memory data - Extend AgentDetailView with Soul, Memory, and Employees tabs and rename children labels to employees - Normalize employee route params for type safety and add focused route/component tests for the new flows
This commit is contained in:
gsxdsm
@@ -0,0 +1,247 @@
|
||||
import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
|
||||
import { EventEmitter } from "node:events";
|
||||
import { request } from "../test-request.js";
|
||||
|
||||
type AgentRecord = {
|
||||
id: string;
|
||||
name: string;
|
||||
role: "executor" | "reviewer" | "triage" | "merger" | "scheduler" | "engineer" | "custom";
|
||||
state: string;
|
||||
createdAt: string;
|
||||
updatedAt: string;
|
||||
metadata: Record<string, unknown>;
|
||||
reportsTo?: string;
|
||||
soul?: string;
|
||||
memory?: string;
|
||||
};
|
||||
|
||||
const mockInit = vi.fn().mockResolvedValue(undefined);
|
||||
const mockGetAgent = vi.fn();
|
||||
const mockUpdateAgent = vi.fn();
|
||||
const mockGetAgentsByReportsTo = vi.fn();
|
||||
const mockListAgents = vi.fn().mockResolvedValue([]);
|
||||
|
||||
vi.mock("@fusion/core", () => {
|
||||
return {
|
||||
AgentStore: class MockAgentStore {
|
||||
init = mockInit;
|
||||
getAgent = mockGetAgent;
|
||||
updateAgent = mockUpdateAgent;
|
||||
getAgentsByReportsTo = mockGetAgentsByReportsTo;
|
||||
listAgents = mockListAgents;
|
||||
},
|
||||
};
|
||||
});
|
||||
|
||||
class MockStore extends EventEmitter {
|
||||
getRootDir(): string {
|
||||
return "/tmp/fn-1171-test";
|
||||
}
|
||||
|
||||
getFusionDir(): string {
|
||||
return "/tmp/fn-1171-test/.fusion";
|
||||
}
|
||||
|
||||
getDatabase() {
|
||||
return {
|
||||
exec: vi.fn(),
|
||||
prepare: vi.fn().mockReturnValue({
|
||||
run: vi.fn().mockReturnValue({ changes: 0 }),
|
||||
get: vi.fn(),
|
||||
all: vi.fn().mockReturnValue([]),
|
||||
}),
|
||||
};
|
||||
}
|
||||
}
|
||||
|
||||
function createAgent(overrides: Partial<AgentRecord> = {}): AgentRecord {
|
||||
return {
|
||||
id: "agent-001",
|
||||
name: "Agent One",
|
||||
role: "executor",
|
||||
state: "idle",
|
||||
createdAt: "2026-01-01T00:00:00.000Z",
|
||||
updatedAt: "2026-01-01T00:00:00.000Z",
|
||||
metadata: {},
|
||||
...overrides,
|
||||
};
|
||||
}
|
||||
|
||||
describe("Agent soul/memory routes", () => {
|
||||
let store: MockStore;
|
||||
let app: ReturnType<typeof import("../server.js").createServer>;
|
||||
let agents: Map<string, AgentRecord>;
|
||||
|
||||
beforeEach(async () => {
|
||||
vi.clearAllMocks();
|
||||
agents = new Map<string, AgentRecord>();
|
||||
|
||||
mockInit.mockResolvedValue(undefined);
|
||||
mockListAgents.mockResolvedValue([]);
|
||||
|
||||
mockGetAgent.mockImplementation(async (agentId: string) => {
|
||||
return agents.get(agentId) ?? null;
|
||||
});
|
||||
|
||||
mockUpdateAgent.mockImplementation(async (agentId: string, updates: Partial<AgentRecord>) => {
|
||||
const existing = agents.get(agentId);
|
||||
if (!existing) {
|
||||
throw new Error(`Agent ${agentId} not found`);
|
||||
}
|
||||
|
||||
const updated: AgentRecord = {
|
||||
...existing,
|
||||
...updates,
|
||||
updatedAt: "2026-01-02T00:00:00.000Z",
|
||||
};
|
||||
|
||||
agents.set(agentId, updated);
|
||||
return updated;
|
||||
});
|
||||
|
||||
mockGetAgentsByReportsTo.mockImplementation(async (agentId: string) => {
|
||||
return Array.from(agents.values()).filter((agent) => agent.reportsTo === agentId);
|
||||
});
|
||||
|
||||
store = new MockStore();
|
||||
const { createServer } = await import("../server.js");
|
||||
app = createServer(store as any);
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
vi.restoreAllMocks();
|
||||
});
|
||||
|
||||
it("GET /api/agents/:id/soul returns null when not set", async () => {
|
||||
agents.set("agent-001", createAgent());
|
||||
|
||||
const response = await request(app, "GET", "/api/agents/agent-001/soul");
|
||||
|
||||
expect(response.status).toBe(200);
|
||||
expect(response.body).toEqual({ soul: null });
|
||||
});
|
||||
|
||||
it("GET /api/agents/:id/soul returns text when set", async () => {
|
||||
agents.set("agent-001", createAgent({ soul: "Calm, analytical, and direct." }));
|
||||
|
||||
const response = await request(app, "GET", "/api/agents/agent-001/soul");
|
||||
|
||||
expect(response.status).toBe(200);
|
||||
expect(response.body).toEqual({ soul: "Calm, analytical, and direct." });
|
||||
});
|
||||
|
||||
it("PATCH /api/agents/:id/soul updates and returns agent", async () => {
|
||||
agents.set("agent-001", createAgent());
|
||||
|
||||
const response = await request(
|
||||
app,
|
||||
"PATCH",
|
||||
"/api/agents/agent-001/soul",
|
||||
JSON.stringify({ soul: "Mentoring collaborator with concise feedback." }),
|
||||
{ "content-type": "application/json" },
|
||||
);
|
||||
|
||||
expect(response.status).toBe(200);
|
||||
expect((response.body as any).soul).toBe("Mentoring collaborator with concise feedback.");
|
||||
expect(mockUpdateAgent).toHaveBeenCalledWith("agent-001", {
|
||||
soul: "Mentoring collaborator with concise feedback.",
|
||||
});
|
||||
});
|
||||
|
||||
it("PATCH /api/agents/:id/soul rejects strings longer than 10,000 chars", async () => {
|
||||
agents.set("agent-001", createAgent());
|
||||
|
||||
const response = await request(
|
||||
app,
|
||||
"PATCH",
|
||||
"/api/agents/agent-001/soul",
|
||||
JSON.stringify({ soul: "x".repeat(10001) }),
|
||||
{ "content-type": "application/json" },
|
||||
);
|
||||
|
||||
expect(response.status).toBe(400);
|
||||
expect((response.body as any).error).toBe("soul must be at most 10,000 characters");
|
||||
expect(mockUpdateAgent).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("GET /api/agents/:id/memory returns null when not set", async () => {
|
||||
agents.set("agent-001", createAgent());
|
||||
|
||||
const response = await request(app, "GET", "/api/agents/agent-001/memory");
|
||||
|
||||
expect(response.status).toBe(200);
|
||||
expect(response.body).toEqual({ memory: null });
|
||||
});
|
||||
|
||||
it("PATCH /api/agents/:id/memory updates and returns agent", async () => {
|
||||
agents.set("agent-001", createAgent());
|
||||
|
||||
const response = await request(
|
||||
app,
|
||||
"PATCH",
|
||||
"/api/agents/agent-001/memory",
|
||||
JSON.stringify({ memory: "Prefers minimal examples, avoids long prose unless requested." }),
|
||||
{ "content-type": "application/json" },
|
||||
);
|
||||
|
||||
expect(response.status).toBe(200);
|
||||
expect((response.body as any).memory).toBe("Prefers minimal examples, avoids long prose unless requested.");
|
||||
expect(mockUpdateAgent).toHaveBeenCalledWith("agent-001", {
|
||||
memory: "Prefers minimal examples, avoids long prose unless requested.",
|
||||
});
|
||||
});
|
||||
|
||||
it("PATCH /api/agents/:id/memory rejects strings longer than 50,000 chars", async () => {
|
||||
agents.set("agent-001", createAgent());
|
||||
|
||||
const response = await request(
|
||||
app,
|
||||
"PATCH",
|
||||
"/api/agents/agent-001/memory",
|
||||
JSON.stringify({ memory: "x".repeat(50001) }),
|
||||
{ "content-type": "application/json" },
|
||||
);
|
||||
|
||||
expect(response.status).toBe(400);
|
||||
expect((response.body as any).error).toBe("memory must be at most 50,000 characters");
|
||||
expect(mockUpdateAgent).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("returns 404 for nonexistent agent on soul/memory endpoints", async () => {
|
||||
const missingGetSoul = await request(app, "GET", "/api/agents/agent-missing/soul");
|
||||
const missingPatchSoul = await request(
|
||||
app,
|
||||
"PATCH",
|
||||
"/api/agents/agent-missing/soul",
|
||||
JSON.stringify({ soul: "value" }),
|
||||
{ "content-type": "application/json" },
|
||||
);
|
||||
const missingGetMemory = await request(app, "GET", "/api/agents/agent-missing/memory");
|
||||
const missingPatchMemory = await request(
|
||||
app,
|
||||
"PATCH",
|
||||
"/api/agents/agent-missing/memory",
|
||||
JSON.stringify({ memory: "value" }),
|
||||
{ "content-type": "application/json" },
|
||||
);
|
||||
|
||||
expect(missingGetSoul.status).toBe(404);
|
||||
expect(missingPatchSoul.status).toBe(404);
|
||||
expect(missingGetMemory.status).toBe(404);
|
||||
expect(missingPatchMemory.status).toBe(404);
|
||||
});
|
||||
|
||||
it("GET /api/agents/:id/employees returns same payload as /children", async () => {
|
||||
agents.set("agent-parent", createAgent({ id: "agent-parent", name: "Parent" }));
|
||||
agents.set("agent-child-1", createAgent({ id: "agent-child-1", name: "Child One", reportsTo: "agent-parent" }));
|
||||
agents.set("agent-child-2", createAgent({ id: "agent-child-2", name: "Child Two", reportsTo: "agent-parent" }));
|
||||
|
||||
const childrenResponse = await request(app, "GET", "/api/agents/agent-parent/children");
|
||||
const employeesResponse = await request(app, "GET", "/api/agents/agent-parent/employees");
|
||||
|
||||
expect(childrenResponse.status).toBe(200);
|
||||
expect(employeesResponse.status).toBe(200);
|
||||
expect(employeesResponse.body).toEqual(childrenResponse.body);
|
||||
expect((employeesResponse.body as any[])).toHaveLength(2);
|
||||
});
|
||||
});
|
||||
@@ -8000,6 +8000,122 @@ Output ONLY the prompt text (no markdown, no explanations).`;
|
||||
}
|
||||
});
|
||||
|
||||
/**
|
||||
* GET /api/agents/:id/soul
|
||||
* Fetch agent soul/personality text.
|
||||
*/
|
||||
router.get("/agents/:id/soul", async (req, res) => {
|
||||
try {
|
||||
const scopedStore = await getScopedStore(req);
|
||||
const { AgentStore } = await import("@fusion/core");
|
||||
const agentStore = new AgentStore({ rootDir: scopedStore.getFusionDir() });
|
||||
await agentStore.init();
|
||||
|
||||
const agent = await agentStore.getAgent(req.params.id);
|
||||
if (!agent) {
|
||||
throw notFound("Agent not found");
|
||||
}
|
||||
|
||||
res.json({ soul: agent.soul ?? null });
|
||||
} catch (err: any) {
|
||||
if (err instanceof ApiError) {
|
||||
throw err;
|
||||
}
|
||||
rethrowAsApiError(err);
|
||||
}
|
||||
});
|
||||
|
||||
/**
|
||||
* PATCH /api/agents/:id/soul
|
||||
* Update agent soul/personality text.
|
||||
* Body: { soul: string }
|
||||
*/
|
||||
router.patch("/agents/:id/soul", async (req, res) => {
|
||||
try {
|
||||
const { soul } = req.body ?? {};
|
||||
if (typeof soul !== "string") {
|
||||
throw badRequest("soul must be a string");
|
||||
}
|
||||
if (soul.length > 10000) {
|
||||
throw badRequest("soul must be at most 10,000 characters");
|
||||
}
|
||||
|
||||
const scopedStore = await getScopedStore(req);
|
||||
const { AgentStore } = await import("@fusion/core");
|
||||
const agentStore = new AgentStore({ rootDir: scopedStore.getFusionDir() });
|
||||
await agentStore.init();
|
||||
|
||||
const agent = await agentStore.updateAgent(req.params.id, { soul });
|
||||
res.json(agent);
|
||||
} catch (err: any) {
|
||||
if (err instanceof ApiError) {
|
||||
throw err;
|
||||
}
|
||||
if (err.message?.includes("not found")) {
|
||||
throw notFound(err.message);
|
||||
}
|
||||
rethrowAsApiError(err);
|
||||
}
|
||||
});
|
||||
|
||||
/**
|
||||
* GET /api/agents/:id/memory
|
||||
* Fetch per-agent memory text.
|
||||
*/
|
||||
router.get("/agents/:id/memory", async (req, res) => {
|
||||
try {
|
||||
const scopedStore = await getScopedStore(req);
|
||||
const { AgentStore } = await import("@fusion/core");
|
||||
const agentStore = new AgentStore({ rootDir: scopedStore.getFusionDir() });
|
||||
await agentStore.init();
|
||||
|
||||
const agent = await agentStore.getAgent(req.params.id);
|
||||
if (!agent) {
|
||||
throw notFound("Agent not found");
|
||||
}
|
||||
|
||||
res.json({ memory: agent.memory ?? null });
|
||||
} catch (err: any) {
|
||||
if (err instanceof ApiError) {
|
||||
throw err;
|
||||
}
|
||||
rethrowAsApiError(err);
|
||||
}
|
||||
});
|
||||
|
||||
/**
|
||||
* PATCH /api/agents/:id/memory
|
||||
* Update per-agent memory text.
|
||||
* Body: { memory: string }
|
||||
*/
|
||||
router.patch("/agents/:id/memory", async (req, res) => {
|
||||
try {
|
||||
const { memory } = req.body ?? {};
|
||||
if (typeof memory !== "string") {
|
||||
throw badRequest("memory must be a string");
|
||||
}
|
||||
if (memory.length > 50000) {
|
||||
throw badRequest("memory must be at most 50,000 characters");
|
||||
}
|
||||
|
||||
const scopedStore = await getScopedStore(req);
|
||||
const { AgentStore } = await import("@fusion/core");
|
||||
const agentStore = new AgentStore({ rootDir: scopedStore.getFusionDir() });
|
||||
await agentStore.init();
|
||||
|
||||
const agent = await agentStore.updateAgent(req.params.id, { memory });
|
||||
res.json(agent);
|
||||
} catch (err: any) {
|
||||
if (err instanceof ApiError) {
|
||||
throw err;
|
||||
}
|
||||
if (err.message?.includes("not found")) {
|
||||
throw notFound(err.message);
|
||||
}
|
||||
rethrowAsApiError(err);
|
||||
}
|
||||
});
|
||||
|
||||
/**
|
||||
* POST /api/agents/:id/state
|
||||
* Update agent state.
|
||||
@@ -8553,20 +8669,25 @@ Output ONLY the prompt text (no markdown, no explanations).`;
|
||||
* Response 200: Agent[] — Array of agents where reportsTo equals :id
|
||||
* Response 404: { error: "Agent not found" } — When parent agent doesn't exist
|
||||
*/
|
||||
router.get("/agents/:id/children", async (req, res) => {
|
||||
const getAgentEmployeesHandler = async (req: Request, res: Response) => {
|
||||
try {
|
||||
const scopedStore = await getScopedStore(req);
|
||||
const { AgentStore } = await import("@fusion/core");
|
||||
const agentStore = new AgentStore({ rootDir: scopedStore.getFusionDir() });
|
||||
await agentStore.init();
|
||||
|
||||
const agentId = Array.isArray(req.params.id) ? req.params.id[0] : req.params.id;
|
||||
if (!agentId) {
|
||||
throw badRequest("Agent id is required");
|
||||
}
|
||||
|
||||
// Validate the parent agent exists
|
||||
const parent = await agentStore.getAgent(req.params.id);
|
||||
const parent = await agentStore.getAgent(agentId);
|
||||
if (!parent) {
|
||||
throw notFound("Agent not found");
|
||||
}
|
||||
|
||||
const children = await agentStore.getAgentsByReportsTo(req.params.id);
|
||||
const children = await agentStore.getAgentsByReportsTo(agentId);
|
||||
res.json(children);
|
||||
} catch (err: any) {
|
||||
if (err instanceof ApiError) {
|
||||
@@ -8574,7 +8695,15 @@ Output ONLY the prompt text (no markdown, no explanations).`;
|
||||
}
|
||||
rethrowAsApiError(err);
|
||||
}
|
||||
});
|
||||
};
|
||||
|
||||
router.get("/agents/:id/children", getAgentEmployeesHandler);
|
||||
|
||||
/**
|
||||
* GET /api/agents/:id/employees
|
||||
* Alias for /api/agents/:id/children.
|
||||
*/
|
||||
router.get("/agents/:id/employees", getAgentEmployeesHandler);
|
||||
|
||||
// ── Agent Generation Routes ──────────────────────────────────────────────
|
||||
|
||||
|
||||
Reference in New Issue
Block a user