root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

feat(FN-5362): add heartbeat executor sparse-cache reports-health diagnosti

Browse Source 
The merge fixes a stale cache-miss path in the heartbeat executor and adds `reports-health` diagnostics for cache-state reporting, with a regression test covering a sparse-cache false-positive scenario. It also adds a two-line tweak to the merger and updates the diagnostics documentation.

Fusion-Task-Id: FN-5362
This commit is contained in:
Fusion (runfusion.ai)
2026-05-20 12:16:37 -07:00
committed by gsxdsm
parent 5548dc57de
commit 6fb4b9ee47
4 changed files with 130 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

88
packages/engine/src/__tests__/heartbeat-executor.test.ts
View File

@@ -261,6 +261,65 @@ describe("executeHeartbeat", () => {
expect(section).toContain("**stale**");
});
it("buildReportsHealthSection reproduces sparse-cache false positive without persisted interval (FN-5362)", async () => {
const now = Date.now();
const store = createStoreWithAgentForExec();
vi.mocked(store.getCachedAgent).mockReturnValue(null);
vi.mocked(store.getAgent).mockResolvedValue({
id: "agent-frontend",
} as unknown as Agent);
vi.mocked(store.getAgentsByReportsTo).mockResolvedValue([
{
id: "agent-frontend",
name: "Frontend Engineer",
state: "idle",
taskId: null,
lastHeartbeatAt: new Date(now - 20 * 60_000).toISOString(),
updatedAt: new Date(now - 20 * 60_000).toISOString(),
} as unknown as Agent,
]);
const monitor = new HeartbeatMonitor({
store,
taskStore: mockTaskStore,
rootDir: "/tmp",
pollIntervalMs: 5 * 60_000,
});
const section = await (monitor as any).buildReportsHealthSection("agent-001", store);
expect(section).toContain("Frontend Engineer");
expect(section).toContain("**stale**");
});
it("buildReportsHealthSection uses persisted agent interval when cache is sparse (FN-5362)", async () => {
const now = Date.now();
const store = createStoreWithAgentForExec();
vi.mocked(store.getCachedAgent).mockReturnValue(null);
vi.mocked(store.getAgent).mockResolvedValue({
id: "agent-frontend",
runtimeConfig: { heartbeatIntervalMs: 60 * 60_000 },
} as unknown as Agent);
vi.mocked(store.getAgentsByReportsTo).mockResolvedValue([
{
id: "agent-frontend",
name: "Frontend Engineer",
state: "idle",
taskId: null,
lastHeartbeatAt: new Date(now - 20 * 60_000).toISOString(),
updatedAt: new Date(now - 20 * 60_000).toISOString(),
} as unknown as Agent,
]);
const monitor = new HeartbeatMonitor({
store,
taskStore: mockTaskStore,
rootDir: "/tmp",
pollIntervalMs: 5 * 60_000,
});
const section = await (monitor as any).buildReportsHealthSection("agent-001", store);
expect(section).toContain("Frontend Engineer");
expect(section).not.toContain("**stale**");
});
it("buildReportsHealthSection keeps 60m-interval reports healthy within the grace window", async () => {
const now = Date.now();
const store = createStoreWithAgentForExec();
@@ -418,6 +477,35 @@ describe("executeHeartbeat", () => {
expect(section).not.toContain("**stale**");
});
it("buildReportsHealthSection logs stale decisions with interval source (FN-5362)", async () => {
const now = Date.now();
const store = createStoreWithAgentForExec();
vi.mocked(store.getCachedAgent).mockReturnValue(null);
vi.mocked(store.getAgent).mockResolvedValue({
id: "agent-overdue",
runtimeConfig: { heartbeatIntervalMs: 60 * 60_000 },
} as unknown as Agent);
vi.mocked(store.getAgentsByReportsTo).mockResolvedValue([
{
id: "agent-overdue",
name: "Overdue",
state: "active",
taskId: null,
lastHeartbeatAt: new Date(now - 100 * 60_000).toISOString(),
updatedAt: new Date(now - 100 * 60_000).toISOString(),
} as unknown as Agent,
]);
const monitor = new HeartbeatMonitor({ store, taskStore: mockTaskStore, rootDir: "/tmp", pollIntervalMs: 5 * 60_000 });
await (monitor as any).buildReportsHealthSection("agent-001", store);
expect(heartbeatLog.log).toHaveBeenCalledWith(
expect.stringContaining("[reports-health] stale report agent-overdue intervalSource=persisted-agent"),
);
expect(heartbeatLog.log).toHaveBeenCalledWith(expect.stringContaining("staleThresholdMs="));
expect(heartbeatLog.log).toHaveBeenCalledWith(expect.stringContaining("heartbeatAgeMs="));
});
it("buildReportsHealthSection preserves AgentStore method binding for direct-report lookups", async () => {
const now = new Date().toISOString();
const report = { id: "agent-004", name: "bound-report", state: "active", taskId: "FN-102", reportsTo: "agent-001", lastHeartbeatAt: now, updatedAt: now } as Agent;