root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(KB-656): add autoExpand prop to QuickEntryBox

Browse Source 
- Add autoExpand prop to QuickEntryBox (defaults to true for backward compatibility)
- When autoExpand is true, component auto-expands on focus
- List view passes autoExpand={false} to keep view collapsed by default
- Board view continues to auto-expand using default behavior
- Add tests for both autoExpand modes and verify focus behavior
This commit is contained in:
gsxdsm
2026-04-02 09:20:37 -07:00
parent 18a2b3ec32
commit 70e9cd9ca3
5 changed files with 41 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
packages/dashboard/app/components/__tests__/QuickEntryBox.test.tsx
View File

@@ -180,17 +180,26 @@ describe("QuickEntryBox", () => {
expect((textarea as HTMLTextAreaElement).placeholder).toBe("Add a task...");
});
it("does NOT expand on focus", () => {
renderQuickEntryBox({}, { startCollapsed: true });
// Component starts with disclosure expanded by default
it("does NOT expand on focus when autoExpand is false", () => {
renderQuickEntryBox({ autoExpand: false });
const textarea = screen.getByTestId("quick-entry-input");
fireEvent.focus(textarea);
// Should NOT auto-expand on focus (manual toggle only)
// Should NOT auto-expand on focus when autoExpand is false
expect(textarea.classList.contains("quick-entry-input--expanded")).toBe(false);
});
it("expands on focus by default (backward compatible)", () => {
renderQuickEntryBox();
const textarea = screen.getByTestId("quick-entry-input");
fireEvent.focus(textarea);
// Should auto-expand on focus by default (autoExpand defaults to true)
expect(textarea.classList.contains("quick-entry-input--expanded")).toBe(true);
});
it("toggle button expands the view", () => {
renderQuickEntryBox({}, { startCollapsed: true });
// Component starts with disclosure expanded by default
@@ -838,12 +847,13 @@ describe("QuickEntryBox", () => {
expect(props.onCreate).toHaveBeenCalled();
});
// After creation, input should be cleared
// After creation, input is cleared and focus is restored
expect((textarea as HTMLTextAreaElement).value).toBe("");
// Disclosure preference persists - controls remain visible since we expanded earlier
expect(screen.getByTestId("quick-entry-deps-button")).toBeTruthy();
expect(screen.getByTestId("plan-button")).toBeTruthy();
expect(screen.getByTestId("subtask-button")).toBeTruthy();
// With autoExpand=true (default), textarea auto-expands on focus restore
// So the toggle should be expanded (controls visible)
expect(screen.getByTestId("quick-entry-toggle").getAttribute("aria-expanded")).toBe("true");
expect(document.getElementById("quick-entry-controls")?.hasAttribute("hidden")).toBe(false);
});
});