root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(test): address review — inherit coreSetup from root via extends: true

Browse Source 
Remove duplicate coreSetup from reports-dashboard project setupFiles.
With extends: true, coreSetup is already inherited from the root config.
Only dashboardSetup needs to be explicitly added at the project level.
This commit is contained in:
Josemi Liebana
2026-05-25 12:34:53 +02:00
parent ca0aa2ff9c
commit 7b90f441fe
1 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
plugins/fusion-plugin-reports/vitest.config.ts
View File

@@ -4,6 +4,13 @@ import { computeMaxWorkers } from "../../packages/core/src/__test-utils__/vitest
const maxWorkers = computeMaxWorkers(); const maxWorkers = computeMaxWorkers();
const coreSetup = fileURLToPath(
new URL("../../packages/core/src/__test-utils__/vitest-setup.ts", import.meta.url),
);
const dashboardSetup = fileURLToPath(
new URL("./src/dashboard/test-setup.ts", import.meta.url),
);
export default defineConfig({ export default defineConfig({
resolve: { resolve: {
alias: { alias: {
@@ -13,9 +20,8 @@ export default defineConfig({
}, },
}, },
test: { test: {
setupFiles: [ // coreSetup runs for all projects via extends: true inheritance
fileURLToPath(new URL("../../packages/core/src/__test-utils__/vitest-setup.ts", import.meta.url)), setupFiles: [coreSetup],
],
globalSetup: [fileURLToPath(new URL("../../packages/core/src/__test-utils__/vitest-teardown.ts", import.meta.url))], globalSetup: [fileURLToPath(new URL("../../packages/core/src/__test-utils__/vitest-teardown.ts", import.meta.url))],
pool: "threads", pool: "threads",
maxWorkers, maxWorkers,
@@ -27,10 +33,9 @@ export default defineConfig({
name: "reports-dashboard", name: "reports-dashboard",
environment: "jsdom", environment: "jsdom",
include: ["src/dashboard/**/__tests__/**/*.test.{ts,tsx}", "src/dashboard/**/*.test.{ts,tsx}"], include: ["src/dashboard/**/__tests__/**/*.test.{ts,tsx}", "src/dashboard/**/*.test.{ts,tsx}"],
setupFiles: [ // coreSetup is inherited from root via extends: true.
fileURLToPath(new URL("../../packages/core/src/__test-utils__/vitest-setup.ts", import.meta.url)), // Only add dashboardSetup which is jsdom-specific.
fileURLToPath(new URL("./src/dashboard/test-setup.ts", import.meta.url)), setupFiles: [dashboardSetup],
],
}, },
}, },
{ {