feat(FN-2951): enforce unavailable-node scheduling and improve active agents panel
- Enforce unavailable-node routing policy in the scheduler and wire policy integration through engine startup - Expand scheduler and node-routing policy test coverage for unavailable-node handling and policy integration behavior - Hoist the Active Agents panel above the main agents list and display next-heartbeat ETA details - Fix Active Agents panel UI issues by resolving stuck "Connecting..." cards and adding spacing adjustments - Add changesets covering Active Agents panel hoist/heartbeat ETA and connecting-state fixes Fusion-Task-Id: FN-2951
This commit is contained in:
Fusion
@@ -1,78 +1,68 @@
|
||||
import { describe, expect, it } from "vitest";
|
||||
import type { EffectiveNode } from "../effective-node.js";
|
||||
import type { NodeStatus, UnavailableNodePolicy } from "@fusion/core";
|
||||
import { applyUnavailableNodePolicy } from "../node-routing-policy.js";
|
||||
|
||||
function effectiveNode(nodeId: string | undefined, source: EffectiveNode["source"]): EffectiveNode {
|
||||
return { nodeId, source };
|
||||
}
|
||||
|
||||
describe("applyUnavailableNodePolicy", () => {
|
||||
it.each<[UnavailableNodePolicy | undefined, NodeStatus | undefined]>([
|
||||
["block", "online"],
|
||||
["block", "offline"],
|
||||
["block", "error"],
|
||||
["block", "connecting"],
|
||||
["block", undefined],
|
||||
["fallback-local", "online"],
|
||||
["fallback-local", "offline"],
|
||||
["fallback-local", "error"],
|
||||
["fallback-local", "connecting"],
|
||||
["fallback-local", undefined],
|
||||
[undefined, "online"],
|
||||
[undefined, "offline"],
|
||||
[undefined, "error"],
|
||||
[undefined, "connecting"],
|
||||
[undefined, undefined],
|
||||
])("always allows local execution (policy=%s, status=%s)", (policy, status) => {
|
||||
const result = applyUnavailableNodePolicy(status, policy, true);
|
||||
|
||||
expect(result).toEqual({
|
||||
allowed: true,
|
||||
fallbackToLocal: false,
|
||||
reason: "local-execution",
|
||||
it("always allows local execution regardless of policy or health", () => {
|
||||
const result = applyUnavailableNodePolicy({
|
||||
effectiveNode: effectiveNode(undefined, "local"),
|
||||
nodeHealth: "offline",
|
||||
policy: "block",
|
||||
});
|
||||
|
||||
expect(result).toEqual({ allowed: true, fallbackToLocal: false });
|
||||
});
|
||||
|
||||
it.each<[
|
||||
NodeStatus | undefined,
|
||||
{ allowed: boolean; fallbackToLocal: boolean },
|
||||
]>([
|
||||
it.each<[NodeStatus | undefined, { allowed: boolean; fallbackToLocal?: boolean; reason?: string }]>([
|
||||
["online", { allowed: true, fallbackToLocal: false }],
|
||||
["offline", { allowed: false, fallbackToLocal: false }],
|
||||
["error", { allowed: false, fallbackToLocal: false }],
|
||||
["connecting", { allowed: false, fallbackToLocal: false }],
|
||||
["offline", { allowed: false, reason: "Node node-1 is offline; policy is block" }],
|
||||
["error", { allowed: false, reason: "Node node-1 is error; policy is block" }],
|
||||
["connecting", { allowed: false, reason: "Node node-1 is connecting; policy is block" }],
|
||||
[undefined, { allowed: true, fallbackToLocal: false }],
|
||||
])("applies block policy for status=%s", (status, expected) => {
|
||||
const result = applyUnavailableNodePolicy(status, "block", false);
|
||||
|
||||
expect(result.allowed).toBe(expected.allowed);
|
||||
expect(result.fallbackToLocal).toBe(expected.fallbackToLocal);
|
||||
});
|
||||
|
||||
it.each<[
|
||||
NodeStatus | undefined,
|
||||
{ allowed: boolean; fallbackToLocal: boolean },
|
||||
]>([
|
||||
["online", { allowed: true, fallbackToLocal: false }],
|
||||
["offline", { allowed: true, fallbackToLocal: true }],
|
||||
["error", { allowed: true, fallbackToLocal: true }],
|
||||
["connecting", { allowed: true, fallbackToLocal: true }],
|
||||
[undefined, { allowed: true, fallbackToLocal: false }],
|
||||
])("applies fallback-local policy for status=%s", (status, expected) => {
|
||||
const result = applyUnavailableNodePolicy(status, "fallback-local", false);
|
||||
|
||||
expect(result.allowed).toBe(expected.allowed);
|
||||
expect(result.fallbackToLocal).toBe(expected.fallbackToLocal);
|
||||
});
|
||||
|
||||
it("defaults undefined policy to block behavior", () => {
|
||||
const result = applyUnavailableNodePolicy("offline", undefined, false);
|
||||
|
||||
expect(result).toEqual({
|
||||
allowed: false,
|
||||
fallbackToLocal: false,
|
||||
reason: "blocked:offline",
|
||||
])("applies block policy for status=%s", (nodeHealth, expected) => {
|
||||
const result = applyUnavailableNodePolicy({
|
||||
effectiveNode: effectiveNode("node-1", "task-override"),
|
||||
nodeHealth,
|
||||
policy: "block",
|
||||
});
|
||||
|
||||
expect(result).toEqual(expected);
|
||||
});
|
||||
|
||||
it("includes status in blocked and fallback reason strings", () => {
|
||||
expect(applyUnavailableNodePolicy("offline", "block", false).reason).toBe("blocked:offline");
|
||||
expect(applyUnavailableNodePolicy("error", "fallback-local", false).reason).toBe("fallback-local:error");
|
||||
it.each<[NodeStatus | undefined, { allowed: boolean; fallbackToLocal: boolean; reason?: string }]>([
|
||||
["online", { allowed: true, fallbackToLocal: false }],
|
||||
["offline", { allowed: true, fallbackToLocal: true, reason: "Node node-1 is offline; falling back to local per policy" }],
|
||||
["error", { allowed: true, fallbackToLocal: true, reason: "Node node-1 is error; falling back to local per policy" }],
|
||||
["connecting", { allowed: true, fallbackToLocal: true, reason: "Node node-1 is connecting; falling back to local per policy" }],
|
||||
[undefined, { allowed: true, fallbackToLocal: false }],
|
||||
])("applies fallback-local policy for status=%s", (nodeHealth, expected) => {
|
||||
const result = applyUnavailableNodePolicy({
|
||||
effectiveNode: effectiveNode("node-1", "project-default"),
|
||||
nodeHealth,
|
||||
policy: "fallback-local",
|
||||
});
|
||||
|
||||
expect(result).toEqual(expected);
|
||||
});
|
||||
|
||||
it.each<[NodeStatus | undefined, { allowed: boolean; fallbackToLocal?: boolean; reason?: string }]>([
|
||||
["online", { allowed: true, fallbackToLocal: false }],
|
||||
["offline", { allowed: false, reason: "Node node-1 is offline; policy is block" }],
|
||||
["error", { allowed: false, reason: "Node node-1 is error; policy is block" }],
|
||||
["connecting", { allowed: false, reason: "Node node-1 is connecting; policy is block" }],
|
||||
[undefined, { allowed: true, fallbackToLocal: false }],
|
||||
])("treats undefined policy as block for status=%s", (nodeHealth, expected) => {
|
||||
const result = applyUnavailableNodePolicy({
|
||||
effectiveNode: effectiveNode("node-1", "task-override"),
|
||||
nodeHealth,
|
||||
policy: undefined as UnavailableNodePolicy | undefined,
|
||||
});
|
||||
|
||||
expect(result).toEqual(expected);
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user