root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(FN-4238): export merger errors from engine and polish workflow results

Browse Source 
Exports merger error types from the engine package for use in the dashboard and CLI. Adds tests for the engine barrel exports and fixes workflow results tab styling to align the edit toggle with button styles.

Fusion-Task-Id: FN-4238
This commit is contained in:
Fusion
2026-05-12 20:35:00 -07:00
committed by gsxdsm
parent 8e9e48881b
commit 7e057a65d2
6 changed files with 99 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
packages/dashboard/app/components/WorkflowResultsTab.css
View File

@@ -54,19 +54,13 @@
.workflow-results-edit-toggle {
width: auto;
height: calc(var(--space-lg) * 2 - var(--space-xs));
padding: 0 calc(var(--space-sm) + var(--space-xs) * 0.5);
border: 1px solid var(--border);
border-radius: var(--radius-sm);
background: var(--surface);
min-height: calc(var(--space-lg) * 2 - var(--space-xs));
padding-inline: calc(var(--space-sm) + var(--space-xs) * 0.5);
color: var(--text-muted);
font-size: calc(var(--space-sm) + var(--space-xs));
font-weight: 500;
gap: calc(var(--space-xs) + var(--space-xs) * 0.5);
}
.workflow-results-edit-toggle:hover {
background: var(--card-hover);
color: var(--text);
}
@@ -229,7 +223,7 @@
/* Phase badge base and modifier classes */
.phase-badge {
margin-inline-start: var(--space-xs);
font-size: 11px;
font-size: calc(var(--space-sm) + var(--space-xs) * 0.75);
padding: var(--space-xs) var(--space-sm);
border-radius: var(--radius-sm);
}
@@ -293,6 +287,7 @@
.workflow-result-output-header {
display: flex;
flex-wrap: wrap;
align-items: center;
gap: var(--space-sm);
margin-bottom: var(--space-xs);
@@ -307,6 +302,8 @@
}
.workflow-result-output-preview {
flex: 1 1 calc(var(--space-2xl) * 6);
min-width: 0;
font-size: calc(var(--space-sm) + var(--space-xs) * 0.75);
color: var(--text-dim);
font-style: italic;
@@ -504,6 +501,19 @@
min-height: calc(var(--space-lg) * 2 + var(--space-xs));
}
.workflow-result-output-header {
align-items: flex-start;
}
.workflow-result-output-preview {
flex-basis: 100%;
order: 3;
}
.workflow-result-mode-toggle {
margin-left: 0;
}
.workflow-configured-header {
align-items: flex-start;
}

2
packages/dashboard/app/components/WorkflowResultsTab.tsx
View File

@@ -570,7 +570,7 @@ export function WorkflowResultsTab({
const editButton = canEdit ? (
<button
type="button"
className="modal-edit-btn workflow-results-edit-toggle"
className="btn btn-sm workflow-results-edit-toggle"
onClick={() => setIsEditing((prev) => !prev)}
data-testid="workflow-steps-edit-toggle"
aria-label={isEditing ? "Done editing workflow steps" : "Edit workflow steps"}

11
packages/dashboard/app/components/__tests__/WorkflowResultsTab.test.tsx
View File

@@ -873,6 +873,17 @@ describe("WorkflowResultsTab", () => {
expect(css).toMatch(/\.workflow-output-modal-name\s*\{[^}]*min-width:\s*0;[^}]*overflow-wrap:\s*anywhere;/);
});
it("keeps workflow output header actions visible without hardcoded badge sizing", () => {
const baseCss = loadAllAppCssBaseOnly();
const allCss = loadAllAppCss();
expect(baseCss).toMatch(/\.phase-badge\s*\{[^}]*font-size:\s*calc\(var\(--space-sm\) \+ var\(--space-xs\) \* 0\.75\);/);
expect(baseCss).toMatch(/\.workflow-result-output-header\s*\{[^}]*flex-wrap:\s*wrap;/);
expect(baseCss).toMatch(/\.workflow-result-output-preview\s*\{[^}]*flex:\s*1 1 calc\(var\(--space-2xl\) \* 6\);[^}]*min-width:\s*0;/);
expect(allCss).toMatch(/@media \(max-width: 768px\)\s*\{[\s\S]*?\.workflow-result-output-preview\s*\{[^}]*flex-basis:\s*100%;[^}]*order:\s*3;/);
expect(allCss).toMatch(/@media \(max-width: 768px\)\s*\{[\s\S]*?\.workflow-result-mode-toggle\s*\{[^}]*margin-left:\s*0;/);
});
it("allows workflow modal controls to wrap on mobile so the close button stays visible", () => {
const css = loadAllAppCss();