root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(dashboard): resolve typecheck test failures across test files

Browse Source 
- Exclude test files from tsconfig.app.json (matches tsconfig.json pattern)
  Test files use loose mocks that don't satisfy strict type checks —
  they're validated by vitest at runtime, not by tsc
- Fix highlightDiff.test.ts React 19 type errors (props typed as unknown)
- Remove duplicate fetchTasks import in api.test.ts
- Add Task[] cast in ActivityLogModal.test.tsx mock data

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
gsxdsm
2026-04-13 14:15:00 -07:00
parent 3935f4cf8e
commit 8b2eea90ff
4 changed files with 48 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

91
packages/dashboard/app/utils/highlightDiff.test.ts
View File

@@ -2,35 +2,38 @@ import { describe, it, expect } from "vitest";
import { highlightDiff } from "./highlightDiff";
import React from "react";
type ElProps = { className?: string; children?: React.ReactNode };
const propsOf = (el: React.ReactNode): ElProps =>
(el as React.ReactElement<ElProps>).props as ElProps;
const typeOf = (el: React.ReactNode) =>
(el as React.ReactElement).type;
describe("highlightDiff", () => {
it("applies diff-add class to added lines starting with +", () => {
const result = highlightDiff("+hello world");
expect(result).toHaveLength(1);
const span = result[0] as React.ReactElement;
expect(span.type).toBe("span");
expect(span.props.className).toBe("diff-add");
expect(span.props.children).toBe("+hello world\n");
expect(typeOf(result[0])).toBe("span");
expect(propsOf(result[0]).className).toBe("diff-add");
expect(propsOf(result[0]).children).toBe("+hello world\n");
});
it("applies diff-del class to removed lines starting with -", () => {
const result = highlightDiff("-world");
expect(result).toHaveLength(1);
const span = result[0] as React.ReactElement;
expect(span.type).toBe("span");
expect(span.props.className).toBe("diff-del");
expect(span.props.children).toBe("-world\n");
expect(typeOf(result[0])).toBe("span");
expect(propsOf(result[0]).className).toBe("diff-del");
expect(propsOf(result[0]).children).toBe("-world\n");
});
it("applies diff-hunk class to hunk headers starting with @@", () => {
const result = highlightDiff("@@ -1,5 +1,6 @@ function");
expect(result).toHaveLength(1);
const span = result[0] as React.ReactElement;
expect(span.type).toBe("span");
expect(span.props.className).toBe("diff-hunk");
expect(span.props.children).toBe("@@ -1,5 +1,6 @@ function\n");
expect(typeOf(result[0])).toBe("span");
expect(propsOf(result[0]).className).toBe("diff-hunk");
expect(propsOf(result[0]).children).toBe("@@ -1,5 +1,6 @@ function\n");
});
it("does not apply special class to context lines", () => {
@@ -38,27 +41,24 @@ describe("highlightDiff", () => {
expect(result).toHaveLength(1);
// Context lines should be returned as plain text fragments
const fragment = result[0] as React.ReactElement;
expect(fragment.type).toBe(React.Fragment);
expect(fragment.props.children).toBe(" context line\n");
expect(typeOf(result[0])).toBe(React.Fragment);
expect(propsOf(result[0]).children).toBe(" context line\n");
});
it("does not apply diff-add class to +++ lines", () => {
const result = highlightDiff("+++ b/file.ts");
expect(result).toHaveLength(1);
const fragment = result[0] as React.ReactElement;
expect(fragment.type).toBe(React.Fragment);
expect(fragment.props.children).toBe("+++ b/file.ts\n");
expect(typeOf(result[0])).toBe(React.Fragment);
expect(propsOf(result[0]).children).toBe("+++ b/file.ts\n");
});
it("does not apply diff-del class to --- lines", () => {
const result = highlightDiff("--- a/file.ts");
expect(result).toHaveLength(1);
const fragment = result[0] as React.ReactElement;
expect(fragment.type).toBe(React.Fragment);
expect(fragment.props.children).toBe("--- a/file.ts\n");
expect(typeOf(result[0])).toBe(React.Fragment);
expect(propsOf(result[0]).children).toBe("--- a/file.ts\n");
});
it("renders multiple lines correctly with different classes", () => {
@@ -76,34 +76,31 @@ describe("highlightDiff", () => {
expect(result).toHaveLength(8);
// Line 0: diff --git - plain fragment
expect((result[0] as React.ReactElement).type).toBe(React.Fragment);
expect(typeOf(result[0])).toBe(React.Fragment);
// Line 1: --- a/file.ts - plain fragment (not diff-del)
expect((result[1] as React.ReactElement).type).toBe(React.Fragment);
expect(typeOf(result[1])).toBe(React.Fragment);
// Line 2: +++ b/file.ts - plain fragment (not diff-add)
expect((result[2] as React.ReactElement).type).toBe(React.Fragment);
expect(typeOf(result[2])).toBe(React.Fragment);
// Line 3: @@ hunk header - diff-hunk
const hunkLine = result[3] as React.ReactElement;
expect(hunkLine.type).toBe("span");
expect(hunkLine.props.className).toBe("diff-hunk");
expect(typeOf(result[3])).toBe("span");
expect(propsOf(result[3]).className).toBe("diff-hunk");
// Line 4: context - plain fragment
expect((result[4] as React.ReactElement).type).toBe(React.Fragment);
expect(typeOf(result[4])).toBe(React.Fragment);
// Line 5: +added - diff-add
const addedLine = result[5] as React.ReactElement;
expect(addedLine.type).toBe("span");
expect(addedLine.props.className).toBe("diff-add");
expect(typeOf(result[5])).toBe("span");
expect(propsOf(result[5]).className).toBe("diff-add");
// Line 6: -deleted - diff-del
const deletedLine = result[6] as React.ReactElement;
expect(deletedLine.type).toBe("span");
expect(deletedLine.props.className).toBe("diff-del");
expect(typeOf(result[6])).toBe("span");
expect(propsOf(result[6]).className).toBe("diff-del");
// Line 7: another context - plain fragment
expect((result[7] as React.ReactElement).type).toBe(React.Fragment);
expect(typeOf(result[7])).toBe(React.Fragment);
});
it("renders empty diff without errors", () => {
@@ -111,19 +108,17 @@ describe("highlightDiff", () => {
expect(result).toHaveLength(1);
// Empty string becomes single element with empty line
const fragment = result[0] as React.ReactElement;
expect(fragment.type).toBe(React.Fragment);
expect(fragment.props.children).toBe("\n");
expect(typeOf(result[0])).toBe(React.Fragment);
expect(propsOf(result[0]).children).toBe("\n");
});
it("handles single line without newline", () => {
const result = highlightDiff("+single line");
expect(result).toHaveLength(1);
const span = result[0] as React.ReactElement;
expect(span.type).toBe("span");
expect(span.props.className).toBe("diff-add");
expect(span.props.children).toBe("+single line\n");
expect(typeOf(result[0])).toBe("span");
expect(propsOf(result[0]).className).toBe("diff-add");
expect(propsOf(result[0]).children).toBe("+single line\n");
});
it("handles diff header lines correctly", () => {
@@ -139,11 +134,11 @@ index 1234567..abcdefg 100644
expect(result).toHaveLength(5);
// All header lines should be plain fragments, not diff-add/diff-del
expect((result[0] as React.ReactElement).type).toBe(React.Fragment);
expect((result[1] as React.ReactElement).type).toBe(React.Fragment);
expect((result[2] as React.ReactElement).type).toBe(React.Fragment); // --- a/src/index.ts
expect((result[3] as React.ReactElement).type).toBe(React.Fragment); // +++ b/src/index.ts
expect((result[4] as React.ReactElement).type).toBe("span");
expect((result[4] as React.ReactElement).props.className).toBe("diff-hunk");
expect(typeOf(result[0])).toBe(React.Fragment);
expect(typeOf(result[1])).toBe(React.Fragment);
expect(typeOf(result[2])).toBe(React.Fragment); // --- a/src/index.ts
expect(typeOf(result[3])).toBe(React.Fragment); // +++ b/src/index.ts
expect(typeOf(result[4])).toBe("span");
expect(propsOf(result[4]).className).toBe("diff-hunk");
});
});