root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(FN-4940): merge fusion/fn-4940

Browse Source
This commit is contained in:
gsxdsm
2026-05-17 15:11:48 -07:00
parent a651e8ced1
commit 91ac073f8e
3 changed files with 9 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
packages/dashboard/app/__tests__/tablet-header-controls.test.tsx
View File

@@ -389,7 +389,7 @@ describe("tablet header controls", () => {
// ── Tablet project-switch affordances ──────────────────────────
it("does not render project selector on tablet", () => {
it("renders project selector on tablet with multiple projects", () => {
const projects = [
{ id: "1", name: "Project One", path: "/path/one", status: "active" as const },
{ id: "2", name: "Project Two", path: "/path/two", status: "active" as const },
@@ -400,7 +400,7 @@ describe("tablet header controls", () => {
onSelectProject: noop,
onViewAllProjects: noop,
});
expect(screen.queryByTestId("project-selector-trigger")).toBeNull();
expect(screen.getByTestId("project-selector-trigger")).toBeDefined();
});
it("does not render back to projects button on tablet", () => {
@@ -412,7 +412,7 @@ describe("tablet header controls", () => {
expect(screen.queryByTestId("back-to-projects-btn")).toBeNull();
});
it("shows switch project in overflow menu when multiple projects on tablet", () => {
it("does not show projects entry in overflow menu on tablet", () => {
const projects = [
{ id: "1", name: "Project One", path: "/path/one", status: "active" as const },
{ id: "2", name: "Project Two", path: "/path/two", status: "active" as const },
@@ -424,9 +424,7 @@ describe("tablet header controls", () => {
onViewAllProjects,
});
fireEvent.click(screen.getByTitle("More header actions"));
const btn = screen.getByTestId("overflow-project-selector-btn");
expect(btn).toBeDefined();
expect(btn.textContent).toContain("Projects");
expect(screen.queryByTestId("overflow-project-selector-btn")).toBeNull();
});
it("does not render mobile project switch trigger on tablet", () => {
@@ -438,9 +436,10 @@ describe("tablet header controls", () => {
projects,
currentProject: projects[0],
onSelectProject: vi.fn(),
onViewAllProjects: noop,
});
expect(screen.queryByTestId("mobile-project-switch-trigger")).toBeNull();
expect(screen.queryByTestId("project-selector-trigger")).toBeNull();
expect(screen.getByTestId("project-selector-trigger")).toBeDefined();
});
// ── Desktop still shows everything inline ──────────────────────

6
packages/dashboard/app/components/Header.tsx
View File

@@ -948,8 +948,8 @@ export function Header({
</div>
)}
{/* Project Selector - Back button when project selected, dropdown when 2+ projects (desktop only) */}
{!isCompact && projects.length >= 1 && onViewAllProjects && (
{/* Project Selector - Back button when project selected, dropdown when 2+ projects (tablet + desktop) */}
{!isMobile && projects.length >= 1 && onViewAllProjects && (
<ProjectSelector
projects={projects}
currentProject={currentProject ?? null}
@@ -1713,7 +1713,7 @@ export function Header({
aria-label="Additional header actions"
>
{/* Projects - in overflow on mobile */}
{projects.length >= 1 && onViewAllProjects && (
{isMobile && projects.length >= 1 && onViewAllProjects && (
<button
className="mobile-overflow-item"
onClick={() => handleOverflowAction(onViewAllProjects)}

6
packages/dashboard/app/components/ProjectSelector.css
View File

@@ -493,9 +493,3 @@
}
}
@media (min-width: 769px) and (max-width: 1024px) {
/* Hide project selector on tablet (controlled by React rendering too) */
.project-selector {
display: none;
}
}