root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(FN-5256): skip cycle preflight when new task has no deps

Browse Source 
The unconditional listTasks() in assertNoDependencyCycle was wasted work
for the common no-dependency write and broke the same-agent duplicate
intake fail-open path: tests that stub listTasks to throw had the cycle
check consume the rejection before _maybeAutoArchiveSameAgentDuplicate's
try/catch could swallow it, propagating the error out of createTask.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
gsxdsm
2026-05-21 06:40:15 -07:00
parent e12adeb3fa
commit 97e6a0cc0e
2 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/fix-fn-5256-cycle-check-empty-deps.md Normal file
View File

@@ -0,0 +1,5 @@
---
"@runfusion/fusion": patch
---
Skip the dependency-cycle preflight in `TaskStore.assertNoDependencyCycle` when the new task or update has no dependencies. The FN-5256 cycle-check rollout (e12adeb3f) added an unconditional `listTasks()` call on every write to build the dependency lookup, but an empty dependency list can never form a cycle so the query was wasted work. It also broke fail-open semantics in the same-agent duplicate intake path: tests that stubbed `listTasks` to throw saw the cycle check consume the rejection and propagate "boom" out of `createTask` before the duplicate-intake try/catch could swallow it.

1
packages/core/src/store.ts
View File

@@ -3311,6 +3311,7 @@ export class TaskStore extends EventEmitter<TaskStoreEvents> {
source: "createTask" | "createTaskWithReservedId" | "updateTask" | "replication", source: "createTask" | "createTaskWithReservedId" | "updateTask" | "replication",
overrides?: Map<string, readonly string[]>, overrides?: Map<string, readonly string[]>,
): Promise<void> { ): Promise<void> {
if (dependencies.length === 0 && !overrides) return;
const lookup = await this.buildActiveTaskDependencyLookup(overrides); const lookup = await this.buildActiveTaskDependencyLookup(overrides);
const cyclePath = detectDependencyCycle(taskId, dependencies, (candidateId) => lookup.get(candidateId)); const cyclePath = detectDependencyCycle(taskId, dependencies, (candidateId) => lookup.get(candidateId));
if (!cyclePath) return; if (!cyclePath) return;