feat(FN-1702): merge fusion/fn-1702

packages/dashboard/app/hooks/__tests__/useAuthOnboarding.test.ts

@@ -19,6 +19,8 @@ describe("useAuthOnboarding", () => {
     vi.clearAllMocks();
   });
 
+  // --- Trigger branches ---
+
   it("opens onboarding when no providers are authenticated and onboarding is incomplete", async () => {
     mockFetchAuthStatus.mockResolvedValue({
       providers: [{ id: "openai", name: "OpenAI", authenticated: false }],
@@ -44,6 +46,32 @@ describe("useAuthOnboarding", () => {
     expect(openSettings).not.toHaveBeenCalled();
   });
 
+  it("opens onboarding when modelOnboardingComplete is undefined (first-run detection)", async () => {
+    mockFetchAuthStatus.mockResolvedValue({
+      providers: [{ id: "openai", name: "OpenAI", authenticated: false }],
+    });
+    // Explicit first-run: modelOnboardingComplete is undefined (not explicitly false)
+    mockFetchGlobalSettings.mockResolvedValue({
+      modelOnboardingComplete: undefined,
+      defaultProvider: undefined,
+      defaultModelId: undefined,
+    } as never);
+
+    renderHook(() =>
+      useAuthOnboarding({
+        projectId: "proj_123",
+        openModelOnboarding,
+        openSettings,
+      }),
+    );
+
+    await waitFor(() => {
+      expect(openModelOnboarding).toHaveBeenCalledTimes(1);
+    });
+
+    expect(openSettings).not.toHaveBeenCalled();
+  });
+
   it("opens authentication settings when onboarding is complete but no providers are authenticated", async () => {
     mockFetchAuthStatus.mockResolvedValue({
       providers: [{ id: "anthropic", name: "Anthropic", authenticated: false }],
@@ -94,6 +122,34 @@ describe("useAuthOnboarding", () => {
     expect(openSettings).not.toHaveBeenCalled();
   });
 
+  it("does NOT auto-open when authenticated provider exists and default model is configured", async () => {
+    mockFetchAuthStatus.mockResolvedValue({
+      providers: [{ id: "anthropic", name: "Anthropic", authenticated: true }],
+    });
+    mockFetchGlobalSettings.mockResolvedValue({
+      modelOnboardingComplete: true,
+      defaultProvider: "anthropic",
+      defaultModelId: "claude-sonnet-4-5",
+    } as never);
+
+    renderHook(() =>
+      useAuthOnboarding({
+        projectId: "proj_123",
+        openModelOnboarding,
+        openSettings,
+      }),
+    );
+
+    // Give time for any async calls to resolve
+    await waitFor(() => {
+      expect(mockFetchAuthStatus).toHaveBeenCalledTimes(1);
+    });
+
+    // Neither onboarding nor settings should open
+    expect(openModelOnboarding).not.toHaveBeenCalled();
+    expect(openSettings).not.toHaveBeenCalled();
+  });
+
   it("does nothing when auth status fetch fails", async () => {
     mockFetchAuthStatus.mockRejectedValueOnce(new Error("network"));
 
@@ -113,4 +169,111 @@ describe("useAuthOnboarding", () => {
     expect(openSettings).not.toHaveBeenCalled();
     expect(mockFetchGlobalSettings).not.toHaveBeenCalled();
   });
+
+  // --- One-shot guard ---
+
+  it("does not re-trigger onboarding when projectId changes after initial bootstrap", async () => {
+    mockFetchAuthStatus.mockResolvedValue({
+      providers: [{ id: "openai", name: "OpenAI", authenticated: false }],
+    });
+    mockFetchGlobalSettings.mockResolvedValue({
+      modelOnboardingComplete: false,
+      defaultProvider: undefined,
+      defaultModelId: undefined,
+    } as never);
+
+    // First render with project 1
+    const { rerender } = renderHook(
+      ({ projectId }: { projectId: string }) =>
+        useAuthOnboarding({
+          projectId,
+          openModelOnboarding,
+          openSettings,
+        }),
+      {
+        initialProps: { projectId: "proj_1" },
+      },
+    );
+
+    await waitFor(() => {
+      expect(openModelOnboarding).toHaveBeenCalledTimes(1);
+    });
+
+    // Simulate project context churn - change projectId prop
+    rerender({ projectId: "proj_2" });
+
+    // Onboarding should NOT open again (one-shot guard prevents repeat)
+    expect(openModelOnboarding).toHaveBeenCalledTimes(1);
+    expect(openSettings).not.toHaveBeenCalled();
+  });
+
+  it("does not re-trigger when openModelOnboarding reference changes", async () => {
+    mockFetchAuthStatus.mockResolvedValue({
+      providers: [{ id: "openai", name: "OpenAI", authenticated: false }],
+    });
+    mockFetchGlobalSettings.mockResolvedValue({
+      modelOnboardingComplete: false,
+      defaultProvider: undefined,
+      defaultModelId: undefined,
+    } as never);
+
+    const { rerender } = renderHook(
+      ({ open }: { open: () => void }) =>
+        useAuthOnboarding({
+          projectId: "proj_123",
+          openModelOnboarding: open,
+          openSettings,
+        }),
+      {
+        initialProps: { open: openModelOnboarding },
+      },
+    );
+
+    await waitFor(() => {
+      expect(openModelOnboarding).toHaveBeenCalledTimes(1);
+    });
+
+    // Simulate a new function reference (e.g., after modal manager re-render)
+    const newOpenOnboarding = vi.fn();
+    rerender({ open: newOpenOnboarding });
+
+    // Should NOT trigger again
+    expect(openModelOnboarding).toHaveBeenCalledTimes(1);
+    expect(newOpenOnboarding).not.toHaveBeenCalled();
+  });
+
+  it("does not re-trigger when openSettings reference changes", async () => {
+    mockFetchAuthStatus.mockResolvedValue({
+      providers: [{ id: "anthropic", name: "Anthropic", authenticated: false }],
+    });
+    mockFetchGlobalSettings.mockResolvedValue({
+      modelOnboardingComplete: true,
+      defaultProvider: "anthropic",
+      defaultModelId: "claude-sonnet-4-5",
+    } as never);
+
+    const { rerender } = renderHook(
+      ({ open }: { open: (section?: string) => void }) =>
+        useAuthOnboarding({
+          projectId: "proj_123",
+          openModelOnboarding,
+          openSettings: open,
+        }),
+      {
+        initialProps: { open: openSettings },
+      },
+    );
+
+    await waitFor(() => {
+      expect(openSettings).toHaveBeenCalledWith("authentication");
+    });
+
+    // Simulate a new function reference
+    const newOpenSettings = vi.fn();
+    rerender({ open: newOpenSettings });
+
+    // Should NOT trigger again
+    expect(openSettings).toHaveBeenCalledTimes(1);
+    expect(newOpenSettings).not.toHaveBeenCalled();
+  });
 });