feat(FN-3995): add GitHub tracking disclosure to task detail modal
Added GitHub tracking disclosure UI and behavior to the TaskDetailModal with corresponding tests and documentation updates (FN-3995). Fusion-Task-Id: FN-3995
This commit is contained in:
@@ -421,6 +421,7 @@ Inspect task definition, logs, review feedback, comments, documents, workflow ou
|
|||||||
- Execution mode has a read-mode inline lightning-bolt toggle for Fast mode on/off without opening the full edit form.
|
- Execution mode has a read-mode inline lightning-bolt toggle for Fast mode on/off without opening the full edit form.
|
||||||
- These two metadata controls share matched sizing/alignment in read mode (including mobile wrapping) so they behave like a single polished control group.
|
- These two metadata controls share matched sizing/alignment in read mode (including mobile wrapping) so they behave like a single polished control group.
|
||||||
- Eligible existing tasks (triage, todo, in-progress, in-review) expose a **GitHub tracking** section directly in Task Detail, even when tracking is currently disabled.
|
- Eligible existing tasks (triage, todo, in-progress, in-review) expose a **GitHub tracking** section directly in Task Detail, even when tracking is currently disabled.
|
||||||
|
- The GitHub tracking section now defaults to a compact summary row; use the disclosure arrow to expand linked-issue details plus tracking edit controls.
|
||||||
- In shared task edit/create forms, GitHub Tracking appears at the bottom of **More options**, after **Workflow Steps**.
|
- In shared task edit/create forms, GitHub Tracking appears at the bottom of **More options**, after **Workflow Steps**.
|
||||||
- From this section you can explicitly enable/disable tracking and manage a per-task repo override (`owner/repo`). Clearing the override saves `null` and falls back to project/global defaults.
|
- From this section you can explicitly enable/disable tracking and manage a per-task repo override (`owner/repo`). Clearing the override saves `null` and falls back to project/global defaults.
|
||||||
- The **Review** tab is separate from **Comments**: Review shows actionable PR/reviewer feedback and same-task revision controls, while Comments remains the general collaboration thread.
|
- The **Review** tab is separate from **Comments**: Review shows actionable PR/reviewer feedback and same-task revision controls, while Comments remains the general collaboration thread.
|
||||||
|
|||||||
@@ -401,7 +401,7 @@ Tracking behavior is controlled per task:
|
|||||||
|
|
||||||
- `task.githubTracking.enabled` turns tracking on for that task.
|
- `task.githubTracking.enabled` turns tracking on for that task.
|
||||||
- `task.githubTracking.repoOverride` optionally forces a specific target repo (`owner/repo`).
|
- `task.githubTracking.repoOverride` optionally forces a specific target repo (`owner/repo`).
|
||||||
- In the dashboard **Task Detail** modal, eligible existing tasks (`triage`, `todo`, `in-progress`, `in-review`) always show GitHub tracking controls so tracking can be enabled, disabled, or retargeted without reopening the task in a creation flow.
|
- In the dashboard **Task Detail** modal, eligible existing tasks (`triage`, `todo`, `in-progress`, `in-review`) always show a compact GitHub tracking summary row; linked-issue details and tracking controls are behind a disclosure arrow so tracking can still be enabled, disabled, or retargeted without reopening the task in a creation flow.
|
||||||
- Clearing the Task Detail repo override stores `null`, which reverts repo resolution to project/global defaults.
|
- Clearing the Task Detail repo override stores `null`, which reverts repo resolution to project/global defaults.
|
||||||
- Explicit task-level enablement is honored even when project/global GitHub tracking defaults are unset. If `enabled: true` and the repo resolves at task scope (for example via `repoOverride`), Fusion attempts tracking-issue creation on both create-time and eligible edit-time flows.
|
- Explicit task-level enablement is honored even when project/global GitHub tracking defaults are unset. If `enabled: true` and the repo resolves at task scope (for example via `repoOverride`), Fusion attempts tracking-issue creation on both create-time and eligible edit-time flows.
|
||||||
- Explicit manual unlink (`githubTracking.issue: null`) does not recreate a tracking issue in that same update request, and disabling tracking does not create new issues.
|
- Explicit manual unlink (`githubTracking.issue: null`) does not recreate a tracking issue in that same update request, and disabling tracking does not create new issues.
|
||||||
|
|||||||
@@ -449,12 +449,17 @@
|
|||||||
padding: var(--space-sm) var(--space-md);
|
padding: var(--space-sm) var(--space-md);
|
||||||
}
|
}
|
||||||
|
|
||||||
.detail-github-tracking-grid {
|
.detail-github-tracking-content {
|
||||||
margin-top: var(--space-sm);
|
margin-top: var(--space-sm);
|
||||||
padding-top: var(--space-sm);
|
padding-top: var(--space-sm);
|
||||||
border-top: 1px solid var(--border);
|
border-top: 1px solid var(--border);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
.detail-github-tracking-grid {
|
||||||
|
margin-top: 0;
|
||||||
|
padding-top: 0;
|
||||||
|
}
|
||||||
|
|
||||||
.detail-github-issue-state {
|
.detail-github-issue-state {
|
||||||
font-weight: 600;
|
font-weight: 600;
|
||||||
text-transform: lowercase;
|
text-transform: lowercase;
|
||||||
|
|||||||
@@ -534,6 +534,7 @@ export function TaskDetailContent({
|
|||||||
const [showMoveMenu, setShowMoveMenu] = useState(false);
|
const [showMoveMenu, setShowMoveMenu] = useState(false);
|
||||||
const [showActionsMenu, setShowActionsMenu] = useState(false);
|
const [showActionsMenu, setShowActionsMenu] = useState(false);
|
||||||
const [sourceIssueExpanded, setSourceIssueExpanded] = useState(false);
|
const [sourceIssueExpanded, setSourceIssueExpanded] = useState(false);
|
||||||
|
const [githubTrackingExpanded, setGithubTrackingExpanded] = useState(false);
|
||||||
const [githubRepoOverrideDraft, setGithubRepoOverrideDraft] = useState(task.githubTracking?.repoOverride ?? "");
|
const [githubRepoOverrideDraft, setGithubRepoOverrideDraft] = useState(task.githubTracking?.repoOverride ?? "");
|
||||||
const [githubTrackingEnabledDraft, setGithubTrackingEnabledDraft] = useState<boolean | null>(null);
|
const [githubTrackingEnabledDraft, setGithubTrackingEnabledDraft] = useState<boolean | null>(null);
|
||||||
const [githubRepoOverrideError, setGithubRepoOverrideError] = useState<string | null>(null);
|
const [githubRepoOverrideError, setGithubRepoOverrideError] = useState<string | null>(null);
|
||||||
@@ -584,6 +585,7 @@ export function TaskDetailContent({
|
|||||||
setEditSourceIssueUrl(task.sourceIssue?.url ?? "");
|
setEditSourceIssueUrl(task.sourceIssue?.url ?? "");
|
||||||
setEditExecutionMode(normalizeExecutionModeValue(task.executionMode));
|
setEditExecutionMode(normalizeExecutionModeValue(task.executionMode));
|
||||||
setSourceIssueExpanded(false);
|
setSourceIssueExpanded(false);
|
||||||
|
setGithubTrackingExpanded(false);
|
||||||
setGithubRepoOverrideDraft(task.githubTracking?.repoOverride ?? "");
|
setGithubRepoOverrideDraft(task.githubTracking?.repoOverride ?? "");
|
||||||
setGithubTrackingEnabledDraft(null);
|
setGithubTrackingEnabledDraft(null);
|
||||||
setGithubRepoOverrideError(null);
|
setGithubRepoOverrideError(null);
|
||||||
@@ -2358,62 +2360,78 @@ export function TaskDetailContent({
|
|||||||
</span>
|
</span>
|
||||||
)}
|
)}
|
||||||
</div>
|
</div>
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
className="detail-source-toggle"
|
||||||
|
aria-expanded={githubTrackingExpanded}
|
||||||
|
aria-label={githubTrackingExpanded ? "Collapse GitHub tracking details" : "Expand GitHub tracking details"}
|
||||||
|
onClick={() => setGithubTrackingExpanded((expanded) => !expanded)}
|
||||||
|
>
|
||||||
|
<ChevronRight
|
||||||
|
size={16}
|
||||||
|
className={githubTrackingExpanded ? "detail-source-chevron--expanded" : undefined}
|
||||||
|
/>
|
||||||
|
</button>
|
||||||
</div>
|
</div>
|
||||||
{githubTrackedIssue && (
|
{githubTrackingExpanded && (
|
||||||
<dl className="detail-source-grid detail-github-tracking-grid">
|
<div className="detail-github-tracking-content">
|
||||||
<div>
|
|
||||||
<dt>Issue</dt>
|
|
||||||
<dd>
|
|
||||||
{githubTrackedIssue.url ? (
|
|
||||||
<a className="detail-source-link" href={githubTrackedIssue.url} target="_blank" rel="noopener noreferrer">
|
|
||||||
{`${githubTrackedIssue.owner}/${githubTrackedIssue.repo}#${githubTrackedIssue.number}`}
|
|
||||||
</a>
|
|
||||||
) : (
|
|
||||||
<span>{`${githubTrackedIssue.owner}/${githubTrackedIssue.repo}#${githubTrackedIssue.number}`}</span>
|
|
||||||
)}
|
|
||||||
</dd>
|
|
||||||
</div>
|
|
||||||
<div>
|
|
||||||
<dt>State</dt>
|
|
||||||
<dd>
|
|
||||||
<span className={`detail-github-issue-state ${task.issueInfo?.state === "closed" ? "detail-github-issue-state--closed" : "detail-github-issue-state--open"}`}>
|
|
||||||
{task.issueInfo?.state ?? "open"}
|
|
||||||
</span>
|
|
||||||
</dd>
|
|
||||||
</div>
|
|
||||||
</dl>
|
|
||||||
)}
|
|
||||||
{canEditGithubTracking && (
|
|
||||||
<div className="detail-github-tracking-controls">
|
|
||||||
<label className="checkbox-label" htmlFor="detail-github-tracking-toggle">
|
|
||||||
<input
|
|
||||||
id="detail-github-tracking-toggle"
|
|
||||||
type="checkbox"
|
|
||||||
checked={githubTrackingEnabled}
|
|
||||||
disabled={isSavingGithubTracking}
|
|
||||||
onChange={() => void handleToggleGithubTracking()}
|
|
||||||
/>
|
|
||||||
Enable GitHub tracking
|
|
||||||
</label>
|
|
||||||
<div className="detail-github-tracking-repo-row">
|
|
||||||
<input
|
|
||||||
className="input"
|
|
||||||
value={githubRepoOverrideDraft}
|
|
||||||
onChange={(event) => {
|
|
||||||
setGithubRepoOverrideDraft(event.target.value);
|
|
||||||
setGithubRepoOverrideError(null);
|
|
||||||
}}
|
|
||||||
placeholder={effectiveGithubRepoDefault || "owner/repo"}
|
|
||||||
/>
|
|
||||||
<button className="btn btn-sm" onClick={() => void handleSaveGithubRepoOverride()} disabled={isSavingGithubTracking}>
|
|
||||||
Save
|
|
||||||
</button>
|
|
||||||
</div>
|
|
||||||
{githubRepoOverrideError && <small className="detail-github-tracking-error">{githubRepoOverrideError}</small>}
|
|
||||||
{githubTrackedIssue && (
|
{githubTrackedIssue && (
|
||||||
<button className="btn btn-sm touch-target" onClick={() => void handleUnlinkGithubIssue()} disabled={isSavingGithubTracking}>
|
<dl className="detail-source-grid detail-github-tracking-grid">
|
||||||
Unlink GitHub issue
|
<div>
|
||||||
</button>
|
<dt>Issue</dt>
|
||||||
|
<dd>
|
||||||
|
{githubTrackedIssue.url ? (
|
||||||
|
<a className="detail-source-link" href={githubTrackedIssue.url} target="_blank" rel="noopener noreferrer">
|
||||||
|
{`${githubTrackedIssue.owner}/${githubTrackedIssue.repo}#${githubTrackedIssue.number}`}
|
||||||
|
</a>
|
||||||
|
) : (
|
||||||
|
<span>{`${githubTrackedIssue.owner}/${githubTrackedIssue.repo}#${githubTrackedIssue.number}`}</span>
|
||||||
|
)}
|
||||||
|
</dd>
|
||||||
|
</div>
|
||||||
|
<div>
|
||||||
|
<dt>State</dt>
|
||||||
|
<dd>
|
||||||
|
<span className={`detail-github-issue-state ${task.issueInfo?.state === "closed" ? "detail-github-issue-state--closed" : "detail-github-issue-state--open"}`}>
|
||||||
|
{task.issueInfo?.state ?? "open"}
|
||||||
|
</span>
|
||||||
|
</dd>
|
||||||
|
</div>
|
||||||
|
</dl>
|
||||||
|
)}
|
||||||
|
{canEditGithubTracking && (
|
||||||
|
<div className="detail-github-tracking-controls">
|
||||||
|
<label className="checkbox-label" htmlFor="detail-github-tracking-toggle">
|
||||||
|
<input
|
||||||
|
id="detail-github-tracking-toggle"
|
||||||
|
type="checkbox"
|
||||||
|
checked={githubTrackingEnabled}
|
||||||
|
disabled={isSavingGithubTracking}
|
||||||
|
onChange={() => void handleToggleGithubTracking()}
|
||||||
|
/>
|
||||||
|
Enable GitHub tracking
|
||||||
|
</label>
|
||||||
|
<div className="detail-github-tracking-repo-row">
|
||||||
|
<input
|
||||||
|
className="input"
|
||||||
|
value={githubRepoOverrideDraft}
|
||||||
|
onChange={(event) => {
|
||||||
|
setGithubRepoOverrideDraft(event.target.value);
|
||||||
|
setGithubRepoOverrideError(null);
|
||||||
|
}}
|
||||||
|
placeholder={effectiveGithubRepoDefault || "owner/repo"}
|
||||||
|
/>
|
||||||
|
<button className="btn btn-sm" onClick={() => void handleSaveGithubRepoOverride()} disabled={isSavingGithubTracking}>
|
||||||
|
Save
|
||||||
|
</button>
|
||||||
|
</div>
|
||||||
|
{githubRepoOverrideError && <small className="detail-github-tracking-error">{githubRepoOverrideError}</small>}
|
||||||
|
{githubTrackedIssue && (
|
||||||
|
<button className="btn btn-sm touch-target" onClick={() => void handleUnlinkGithubIssue()} disabled={isSavingGithubTracking}>
|
||||||
|
Unlink GitHub issue
|
||||||
|
</button>
|
||||||
|
)}
|
||||||
|
</div>
|
||||||
)}
|
)}
|
||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
|
|||||||
@@ -59,8 +59,8 @@ describe("TaskDetailModal", () => {
|
|||||||
|
|
||||||
const toggle = screen.getByRole("button", { name: "Expand source issue details" });
|
const toggle = screen.getByRole("button", { name: "Expand source issue details" });
|
||||||
expect(toggle).toHaveAttribute("aria-expanded", "false");
|
expect(toggle).toHaveAttribute("aria-expanded", "false");
|
||||||
const chevron = screen.getByTestId("chevron-right-icon");
|
const chevron = toggle.querySelector("svg");
|
||||||
expect(chevron.classList.contains("detail-source-chevron--expanded")).toBe(false);
|
expect(chevron?.classList.contains("detail-source-chevron--expanded")).toBe(false);
|
||||||
|
|
||||||
await user.click(toggle);
|
await user.click(toggle);
|
||||||
|
|
||||||
@@ -71,7 +71,8 @@ describe("TaskDetailModal", () => {
|
|||||||
const sourceLink = screen.getByRole("link", { name: "https://github.com/runfusion/fusion/issues/2473" });
|
const sourceLink = screen.getByRole("link", { name: "https://github.com/runfusion/fusion/issues/2473" });
|
||||||
expect(sourceLink).toHaveAttribute("href", "https://github.com/runfusion/fusion/issues/2473");
|
expect(sourceLink).toHaveAttribute("href", "https://github.com/runfusion/fusion/issues/2473");
|
||||||
expect(sourceLink).toHaveAttribute("target", "_blank");
|
expect(sourceLink).toHaveAttribute("target", "_blank");
|
||||||
expect(screen.getByTestId("chevron-right-icon").classList.contains("detail-source-chevron--expanded")).toBe(true);
|
const expandedChevron = screen.getByRole("button", { name: "Collapse source issue details" }).querySelector("svg");
|
||||||
|
expect(expandedChevron?.classList.contains("detail-source-chevron--expanded")).toBe(true);
|
||||||
});
|
});
|
||||||
|
|
||||||
it("applies compact GitHub source summary styling contracts", () => {
|
it("applies compact GitHub source summary styling contracts", () => {
|
||||||
@@ -2132,6 +2133,10 @@ describe("TaskDetailModal", () => {
|
|||||||
});
|
});
|
||||||
|
|
||||||
describe("github tracking section", () => {
|
describe("github tracking section", () => {
|
||||||
|
const expandGithubTracking = () => {
|
||||||
|
fireEvent.click(screen.getByRole("button", { name: "Expand GitHub tracking details" }));
|
||||||
|
};
|
||||||
|
|
||||||
it("renders linked issue as link when url exists", () => {
|
it("renders linked issue as link when url exists", () => {
|
||||||
render(
|
render(
|
||||||
<TaskDetailModal
|
<TaskDetailModal
|
||||||
@@ -2158,6 +2163,12 @@ describe("TaskDetailModal", () => {
|
|||||||
);
|
);
|
||||||
|
|
||||||
expect(screen.getByText("GitHub tracking")).toBeTruthy();
|
expect(screen.getByText("GitHub tracking")).toBeTruthy();
|
||||||
|
expect(screen.getByLabelText("GitHub tracking status")).toHaveTextContent("Linked");
|
||||||
|
expect(screen.queryByRole("link", { name: "runfusion/fusion#123" })).toBeNull();
|
||||||
|
|
||||||
|
expandGithubTracking();
|
||||||
|
|
||||||
|
expect(screen.getByRole("button", { name: "Collapse GitHub tracking details" })).toHaveAttribute("aria-expanded", "true");
|
||||||
expect(screen.getByRole("link", { name: "runfusion/fusion#123" })).toHaveAttribute("href", "https://github.com/runfusion/fusion/issues/123");
|
expect(screen.getByRole("link", { name: "runfusion/fusion#123" })).toHaveAttribute("href", "https://github.com/runfusion/fusion/issues/123");
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -2176,6 +2187,7 @@ describe("TaskDetailModal", () => {
|
|||||||
|
|
||||||
expect(screen.getByText("GitHub tracking")).toBeTruthy();
|
expect(screen.getByText("GitHub tracking")).toBeTruthy();
|
||||||
expect(screen.getByText("Tracking is currently disabled")).toBeTruthy();
|
expect(screen.getByText("Tracking is currently disabled")).toBeTruthy();
|
||||||
|
expect(screen.queryByLabelText("Enable GitHub tracking")).toBeNull();
|
||||||
});
|
});
|
||||||
|
|
||||||
it("hides section when tracking is disabled and task is not in an eligible column", () => {
|
it("hides section when tracking is disabled and task is not in an eligible column", () => {
|
||||||
@@ -2224,6 +2236,8 @@ describe("TaskDetailModal", () => {
|
|||||||
/>,
|
/>,
|
||||||
);
|
);
|
||||||
|
|
||||||
|
expandGithubTracking();
|
||||||
|
|
||||||
const toggle = screen.getByLabelText("Enable GitHub tracking") as HTMLInputElement;
|
const toggle = screen.getByLabelText("Enable GitHub tracking") as HTMLInputElement;
|
||||||
expect(toggle.checked).toBe(false);
|
expect(toggle.checked).toBe(false);
|
||||||
|
|
||||||
@@ -2258,6 +2272,8 @@ describe("TaskDetailModal", () => {
|
|||||||
/>,
|
/>,
|
||||||
);
|
);
|
||||||
|
|
||||||
|
expandGithubTracking();
|
||||||
|
|
||||||
fireEvent.click(screen.getByLabelText("Enable GitHub tracking"));
|
fireEvent.click(screen.getByLabelText("Enable GitHub tracking"));
|
||||||
await waitFor(() => {
|
await waitFor(() => {
|
||||||
expect(mockUpdate).toHaveBeenCalledWith("FN-001", { githubTracking: { enabled: false } }, undefined);
|
expect(mockUpdate).toHaveBeenCalledWith("FN-001", { githubTracking: { enabled: false } }, undefined);
|
||||||
@@ -2281,6 +2297,8 @@ describe("TaskDetailModal", () => {
|
|||||||
/>,
|
/>,
|
||||||
);
|
);
|
||||||
|
|
||||||
|
expandGithubTracking();
|
||||||
|
|
||||||
fireEvent.change(screen.getByPlaceholderText("owner/repo"), { target: { value: "runfusion/cli" } });
|
fireEvent.change(screen.getByPlaceholderText("owner/repo"), { target: { value: "runfusion/cli" } });
|
||||||
fireEvent.click(screen.getByRole("button", { name: "Save" }));
|
fireEvent.click(screen.getByRole("button", { name: "Save" }));
|
||||||
|
|
||||||
@@ -2327,6 +2345,8 @@ describe("TaskDetailModal", () => {
|
|||||||
/>,
|
/>,
|
||||||
);
|
);
|
||||||
|
|
||||||
|
expandGithubTracking();
|
||||||
|
|
||||||
fireEvent.click(screen.getByRole("button", { name: "Unlink GitHub issue" }));
|
fireEvent.click(screen.getByRole("button", { name: "Unlink GitHub issue" }));
|
||||||
await waitFor(() => {
|
await waitFor(() => {
|
||||||
expect(mockUpdate).not.toHaveBeenCalledWith("FN-001", { githubTracking: { issue: null } }, undefined);
|
expect(mockUpdate).not.toHaveBeenCalledWith("FN-001", { githubTracking: { issue: null } }, undefined);
|
||||||
|
|||||||
Reference in New Issue
Block a user