From 9f8be56f14f647e21878cb4e140e2680380459f7 Mon Sep 17 00:00:00 2001
From: gsxdsm <gsxdsm@users.noreply.github.com>
Date: Sat, 18 Jul 2026 06:44:58 -0700
Subject: [PATCH] fix(dashboard): Settings Memory nav + Loading ready wait
 (#2301)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

## Summary
- Full Suite
[29645564540](https://github.com/Runfusion/Fusion/actions/runs/29645564540):
shards 1–3 green; shard 4 settings suite failed.
- Exact `Memory` nav name (vs `/Memory/` matching **Memory Backups**).
- `waitForSettingsModalReady` waits for Loading… to clear after
fetchSettings.

## Test plan
- [x] memory backend status hook test
- [x] Anthropic Subscription OAuth incomplete toast
- [ ] Full Suite all 4 shards green on main

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Tests**
* Improved settings modal test synchronization to reliably wait for
loading to finish.
* Refined memory settings navigation checks to target the correct
section and avoid ambiguous matches.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---
 .../__tests__/SettingsModal.general.test.tsx           |  7 ++++++-
 .../__tests__/SettingsModal.test-harness.tsx           | 10 +++++++++-
 2 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/packages/dashboard/app/components/__tests__/SettingsModal.general.test.tsx b/packages/dashboard/app/components/__tests__/SettingsModal.general.test.tsx
index 1b91b5cb20..37d719d40f 100644
--- a/packages/dashboard/app/components/__tests__/SettingsModal.general.test.tsx
+++ b/packages/dashboard/app/components/__tests__/SettingsModal.general.test.tsx
@@ -838,7 +838,12 @@ describe("SettingsModal", () => {
       );
       expect(initialCallHasDisabled).toBe(true);
 
-      await settingsModalUser.click(screen.getByRole("button", { name: /Memory/ }));
+      /*
+      FNXC:DashboardTests 2026-07-18-13:35:
+      Settings nav also exposes "Memory Backups"; /Memory/ matches both. Use the exact
+      Memory section label so the deferred memory-backend status hook test stays scoped.
+      */
+      await settingsModalUser.click(screen.getByRole("button", { name: "Memory" }));
 
       await waitFor(() => {
         const enabledCallSeen = mockUseMemoryBackendStatus.mock.calls.some(
diff --git a/packages/dashboard/app/components/__tests__/SettingsModal.test-harness.tsx b/packages/dashboard/app/components/__tests__/SettingsModal.test-harness.tsx
index 4d390e6ef3..09a4ca6f8d 100644
--- a/packages/dashboard/app/components/__tests__/SettingsModal.test-harness.tsx
+++ b/packages/dashboard/app/components/__tests__/SettingsModal.test-harness.tsx
@@ -142,8 +142,16 @@ export function renderModal(props: Partial<ComponentProps<typeof SettingsModal>>
 }
 
 export async function waitForSettingsModalReady() {
+  /*
+  FNXC:DashboardTests 2026-07-18-13:35:
+  Full Suite shard 4 failed when mockFetchSettings was called but the modal still showed
+  Loading… on the next paint (OAuth incomplete-toast test). Wait for Loading to clear so
+  Authentication/section clicks do not race the initial settings fetch.
+  */
   await waitFor(() => expect(mockFetchSettings).toHaveBeenCalled());
-  expect(screen.queryByText("Loading…")).not.toBeInTheDocument();
+  await waitFor(() => {
+    expect(screen.queryByText("Loading…")).not.toBeInTheDocument();
+  });
 }
 
 export async function renderModalSection(