root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Harden architecture hot paths

Browse Source
This commit is contained in:
gsxdsm
2026-04-12 15:13:27 -07:00
parent 7b78963a4c
commit a34ba41ad1
38 changed files with 1212 additions and 561 deletions
Download Patch File Download Diff File Expand all files Collapse all files

58
packages/core/src/__tests__/architecture-hot-paths.test.ts Normal file
View File

@@ -0,0 +1,58 @@
import { describe, expect, it } from "vitest";
import { readFileSync, readdirSync, statSync } from "node:fs";
import { join, relative } from "node:path";
const workspaceRoot = join(__dirname, "..", "..", "..", "..");
function listSourceFiles(dir: string): string[] {
const entries = readdirSync(dir);
const files: string[] = [];
for (const entry of entries) {
const path = join(dir, entry);
const stat = statSync(path);
if (stat.isDirectory()) {
if (entry === "__tests__" || entry === "dist" || entry === "node_modules") {
continue;
}
files.push(...listSourceFiles(path));
continue;
}
if (!/\.(ts|tsx)$/.test(entry) || /\.test\.(ts|tsx)$/.test(entry)) {
continue;
}
files.push(path);
}
return files;
}
describe("architecture hot-path contracts", () => {
it("keeps production listTasks() callers explicit about payload shape", () => {
const sourceRoots = [
"packages/cli/src",
"packages/dashboard/app",
"packages/dashboard/src",
"packages/engine/src",
];
const bareListTaskCalls: string[] = [];
for (const root of sourceRoots) {
for (const file of listSourceFiles(join(workspaceRoot, root))) {
const content = readFileSync(file, "utf-8");
const lines = content.split("\n");
lines.forEach((line, index) => {
if (/\.\s*listTasks\(\)/.test(line)) {
bareListTaskCalls.push(`${relative(workspaceRoot, file)}:${index + 1}`);
}
});
}
}
expect(bareListTaskCalls).toEqual([]);
});
});

126
packages/core/src/__tests__/settings-parity.test.ts
View File

@@ -4,104 +4,9 @@ import {
DEFAULT_PROJECT_SETTINGS,
GLOBAL_SETTINGS_KEYS,
PROJECT_SETTINGS_KEYS,
isGlobalSettingsKey,
isProjectSettingsKey,
} from "../types.js";
import type { GlobalSettings, ProjectSettings } from "../types.js";
const GLOBAL_KEYS: (keyof GlobalSettings)[] = [
"themeMode",
"colorTheme",
"defaultProvider",
"defaultModelId",
"fallbackProvider",
"fallbackModelId",
"defaultThinkingLevel",
"ntfyEnabled",
"ntfyTopic",
"ntfyEvents",
"ntfyDashboardHost",
"defaultProjectId",
"setupComplete",
"favoriteProviders",
"favoriteModels",
"openrouterModelSync",
"modelOnboardingComplete",
];
const PROJECT_KEYS: (keyof ProjectSettings)[] = [
"globalPause",
"enginePaused",
"maxConcurrent",
"maxWorktrees",
"pollIntervalMs",
"groupOverlappingFiles",
"autoMerge",
"mergeStrategy",
"worktreeInitCommand",
"testCommand",
"buildCommand",
"recycleWorktrees",
"worktreeNaming",
"taskPrefix",
"includeTaskIdInCommit",
"planningProvider",
"planningModelId",
"planningFallbackProvider",
"planningFallbackModelId",
"validatorProvider",
"validatorModelId",
"validatorFallbackProvider",
"validatorFallbackModelId",
"modelPresets",
"autoSelectModelPreset",
"defaultPresetBySize",
"autoResolveConflicts",
"smartConflictResolution",
"strictScopeEnforcement",
"buildRetryCount",
"buildTimeoutMs",
"requirePlanApproval",
"taskStuckTimeoutMs",
"aiSessionTtlMs",
"aiSessionCleanupIntervalMs",
"autoUnpauseEnabled",
"autoUnpauseBaseDelayMs",
"autoUnpauseMaxDelayMs",
"maxStuckKills",
"maxSpawnedAgentsPerParent",
"maxSpawnedAgentsGlobal",
"maintenanceIntervalMs",
"autoUpdatePrStatus",
"autoCreatePr",
"autoBackupEnabled",
"autoBackupSchedule",
"autoBackupRetention",
"autoBackupDir",
"autoSummarizeTitles",
"titleSummarizerProvider",
"titleSummarizerModelId",
"titleSummarizerFallbackProvider",
"titleSummarizerFallbackModelId",
"scripts",
"setupScript",
"insightExtractionEnabled",
"insightExtractionSchedule",
"insightExtractionMinIntervalMs",
"memoryEnabled",
"memoryBackendType",
"tokenCap",
"runStepsInNewSessions",
"maxParallelSteps",
"missionStaleThresholdMs",
"missionMaxTaskRetries",
"missionHealthCheckIntervalMs",
"agentPrompts",
"promptOverrides",
"reflectionEnabled",
"reflectionIntervalMs",
"reflectionAfterTask",
"reviewHandoffPolicy",
"showQuickChatFAB",
];
function assertExactKeyCoverage(scopeName: string, actual: readonly string[], expected: readonly string[]): void {
const uniqueActual = [...new Set(actual)];
@@ -124,30 +29,29 @@ function assertExactKeyCoverage(scopeName: string, actual: readonly string[], ex
}
describe("settings key parity", () => {
it("GLOBAL_SETTINGS_KEYS covers all GlobalSettings keys", () => {
assertExactKeyCoverage("GLOBAL_SETTINGS_KEYS", GLOBAL_SETTINGS_KEYS as readonly string[], GLOBAL_KEYS as string[]);
});
it("PROJECT_SETTINGS_KEYS covers all ProjectSettings keys", () => {
assertExactKeyCoverage("PROJECT_SETTINGS_KEYS", PROJECT_SETTINGS_KEYS as readonly string[], PROJECT_KEYS as string[]);
});
it("DEFAULT_GLOBAL_SETTINGS covers all GlobalSettings keys", () => {
it("GLOBAL_SETTINGS_KEYS is derived from the global settings defaults", () => {
assertExactKeyCoverage(
"DEFAULT_GLOBAL_SETTINGS",
"GLOBAL_SETTINGS_KEYS",
GLOBAL_SETTINGS_KEYS as readonly string[],
Object.keys(DEFAULT_GLOBAL_SETTINGS),
GLOBAL_KEYS as string[],
);
});
it("DEFAULT_PROJECT_SETTINGS covers all ProjectSettings keys", () => {
it("PROJECT_SETTINGS_KEYS is derived from the project settings defaults", () => {
assertExactKeyCoverage(
"DEFAULT_PROJECT_SETTINGS",
"PROJECT_SETTINGS_KEYS",
PROJECT_SETTINGS_KEYS as readonly string[],
Object.keys(DEFAULT_PROJECT_SETTINGS),
PROJECT_KEYS as string[],
);
});
it("identifies settings scopes", () => {
expect(isGlobalSettingsKey("themeMode")).toBe(true);
expect(isGlobalSettingsKey("maxConcurrent")).toBe(false);
expect(isProjectSettingsKey("maxConcurrent")).toBe(true);
expect(isProjectSettingsKey("themeMode")).toBe(false);
});
it("No key appears in both GLOBAL_SETTINGS_KEYS and PROJECT_SETTINGS_KEYS", () => {
const projectKeySet = new Set(PROJECT_SETTINGS_KEYS as readonly string[]);
const overlap = (GLOBAL_SETTINGS_KEYS as readonly string[]).filter((key) => projectKeySet.has(key));