root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(FN-3791): add agent provisioning approval guards and policy enforcemen

Browse Source 
Implements approval guards for agent provisioning (FN-3791), adding policy-gated create/delete flows with dedupe logic, CLI tool alignment, engine run-audit coverage, and corresponding test suites, plus documentation updates and a regression fix for verification/tool docs sync.

Fusion-Task-Id: FN-3791
This commit is contained in:
Fusion
2026-05-10 22:44:50 -07:00
committed by gsxdsm
parent 7fd3ccc68b
commit a39985cabf
10 changed files with 316 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
packages/cli/src/extension.ts
View File

@@ -2530,7 +2530,14 @@ export default function kbExtension(pi: ExtensionAPI) {
description: "Create a new non-ephemeral agent.",
parameters: Type.Object({
name: Type.String({ description: "Agent name" }),
role: Type.String({ description: "Agent role/capability" }),
role: Type.Union([
Type.Literal("triage"),
Type.Literal("executor"),
Type.Literal("reviewer"),
Type.Literal("merger"),
Type.Literal("engineer"),
Type.Literal("custom"),
], { description: "Agent role/capability" }),
soul: Type.Optional(Type.String({ description: "Agent personality/identity text" })),
instructions_text: Type.Optional(Type.String({ description: "Inline custom instructions" })),
instructions_path: Type.Optional(Type.String({ description: "Path to instructions markdown" })),
@@ -2545,14 +2552,22 @@ export default function kbExtension(pi: ExtensionAPI) {
const agentStore = new AgentStore({ rootDir: getFusionDir(ctx.cwd) });
await agentStore.init();
const store = await getStore(ctx.cwd);
const caller = { id: "user", role: "user", isPrivileged: true } as const;
const policy = resolveAgentProvisioningPolicy({
tool: "fn_agent_create",
caller: { id: "user", role: "user", isPrivileged: true },
caller,
settings: await store.getSettings(),
});
if (!caller.isPrivileged && params.reportsTo !== undefined && params.reportsTo !== caller.id) {
return {
content: [{ type: "text" as const, text: "ERROR: You can only create agents that report to you" }],
details: { outcome: "denied", matchedRule: "privileged-caller", effectiveMode: policy.effectiveMode },
};
}
if (policy.decision === "require-approval") {
const approvalStore = new ApprovalRequestStore((store as unknown as { db: unknown }).db as never);
const approvalStore = new ApprovalRequestStore(store.getDatabase());
const request = approvalStore.create({
requester: { actorId: "user", actorType: "user", actorName: "CLI User" },
targetAction: { category: "agent_provisioning", action: "create", summary: `Create agent ${params.name} (${params.role})`, resourceType: "agent", resourceId: "", context: { tool: "fn_agent_create", params } },
@@ -2590,7 +2605,7 @@ export default function kbExtension(pi: ExtensionAPI) {
label: "fn: Delete Agent",
description: "Delete a non-ephemeral agent.",
parameters: Type.Object({
id: Type.String({ description: "Agent ID to delete" }),
agent_id: Type.String({ description: "Agent ID to delete" }),
force: Type.Optional(Type.Boolean({ description: "Force delete when holding checkout" })),
reassign_to: Type.Optional(Type.String({ description: "Optional replacement agent for assigned tasks" })),
}),
@@ -2599,25 +2614,33 @@ export default function kbExtension(pi: ExtensionAPI) {
const agentStore = new AgentStore({ rootDir: getFusionDir(ctx.cwd) });
await agentStore.init();
const store = await getStore(ctx.cwd);
const caller = { id: "user", role: "user", isPrivileged: true } as const;
const policy = resolveAgentProvisioningPolicy({
tool: "fn_agent_delete",
caller: { id: "user", role: "user", isPrivileged: true },
caller,
settings: await store.getSettings(),
});
if (policy.decision === "require-approval") {
const approvalStore = new ApprovalRequestStore((store as unknown as { db: unknown }).db as never);
const approvalStore = new ApprovalRequestStore(store.getDatabase());
const request = approvalStore.create({
requester: { actorId: "user", actorType: "user", actorName: "CLI User" },
targetAction: { category: "agent_provisioning", action: "delete", summary: `Delete agent ${params.id}`, resourceType: "agent", resourceId: params.id, context: { tool: "fn_agent_delete", params } },
targetAction: { category: "agent_provisioning", action: "delete", summary: `Delete agent ${params.agent_id}`, resourceType: "agent", resourceId: params.agent_id, context: { tool: "fn_agent_delete", params } },
});
return { content: [{ type: "text" as const, text: `Approval required. Request ${request.id} created.` }], details: { outcome: "pending_approval", approvalRequestId: request.id, matchedRule: policy.matchedRule, effectiveMode: policy.effectiveMode, agentId: params.id } };
return { content: [{ type: "text" as const, text: `Approval required. Request ${request.id} created.` }], details: { outcome: "pending_approval", approvalRequestId: request.id, matchedRule: policy.matchedRule, effectiveMode: policy.effectiveMode, agentId: params.agent_id } };
}
await agentStore.deleteAgent(params.id, { force: params.force === true, reassignTo: params.reassign_to });
if (policy.decision === "deny") {
return {
content: [{ type: "text" as const, text: `DENIED: agent delete blocked by policy (${policy.matchedRule})` }],
details: { outcome: "denied", matchedRule: policy.matchedRule, effectiveMode: policy.effectiveMode, agentId: params.agent_id },
};
}
await agentStore.deleteAgent(params.agent_id, { force: params.force === true, reassignTo: params.reassign_to });
return {
content: [{ type: "text" as const, text: `Deleted ${params.id}` }],
details: { outcome: "deleted", matchedRule: policy.matchedRule, effectiveMode: policy.effectiveMode, agentId: params.id },
content: [{ type: "text" as const, text: `Deleted ${params.agent_id}` }],
details: { outcome: "deleted", matchedRule: policy.matchedRule, effectiveMode: policy.effectiveMode, agentId: params.agent_id },
};
},
});