test(FN-5148): complete Step 4 — add stale github tracking modal coverage

Fusion-Task-Id: FN-5148
Fusion-Task-Lineage: af70f85f-ec90-4040-bbf3-9e1bce3a49b9

packages/dashboard/app/components/__tests__/TaskDetailModal.github-tracking-stale.test.tsx

@@ -0,0 +1,91 @@
+import { describe, it, expect, vi } from "vitest";
+import { render, screen, waitFor } from "@testing-library/react";
+import userEvent from "@testing-library/user-event";
+import { makeTask, noopDelete, noopMerge, noopMove, noopOpenDetail, setupTaskDetailModalHooks } from "./TaskDetailModal.test-helpers";
+import { TaskDetailModal } from "../TaskDetailModal";
+
+setupTaskDetailModalHooks();
+
+describe("TaskDetailModal GitHub tracking stale await guards (FN-5148)", () => {
+  it("ignores stale enable-tracking result after navigating to another task", async () => {
+    const user = userEvent.setup();
+    const onTaskUpdated = vi.fn();
+    const addToast = vi.fn();
+
+    let resolveUpdate!: (value: any) => void;
+    const deferred = new Promise((resolve) => {
+      resolveUpdate = resolve;
+    });
+    const { updateTask } = await import("../../api");
+    const mockUpdateTask = vi.mocked(updateTask);
+    mockUpdateTask.mockImplementationOnce(() => deferred as any);
+
+    const taskA = makeTask({ id: "FN-A", title: "A", column: "todo", githubTracking: { enabled: false } });
+    const taskB = makeTask({ id: "FN-B", title: "B", column: "todo", githubTracking: { enabled: false } });
+
+    const { rerender } = render(
+      <TaskDetailModal
+        task={taskA}
+        onClose={() => {}}
+        onMoveTask={noopMove}
+        onDeleteTask={noopDelete}
+        onMergeTask={noopMerge}
+        onOpenDetail={noopOpenDetail}
+        onTaskUpdated={onTaskUpdated}
+        addToast={addToast}
+      />,
+    );
+
+    await user.click(screen.getByRole("button", { name: "Enable GitHub tracking" }));
+    rerender(
+      <TaskDetailModal
+        task={taskB}
+        onClose={() => {}}
+        onMoveTask={noopMove}
+        onDeleteTask={noopDelete}
+        onMergeTask={noopMerge}
+        onOpenDetail={noopOpenDetail}
+        onTaskUpdated={onTaskUpdated}
+        addToast={addToast}
+      />,
+    );
+
+    resolveUpdate({ ...taskA, githubTracking: { enabled: true } });
+
+    await waitFor(() => {
+      expect(onTaskUpdated).not.toHaveBeenCalledWith(expect.objectContaining({ id: "FN-A" }));
+    });
+    expect(addToast).not.toHaveBeenCalledWith(expect.stringContaining("FN-A"), "error");
+    expect(screen.getByLabelText("Enabling GitHub tracking")).toBeInTheDocument();
+  });
+
+  it("applies enable-tracking result when still viewing the same task", async () => {
+    const user = userEvent.setup();
+    const onTaskUpdated = vi.fn();
+
+    const taskA = makeTask({ id: "FN-A", title: "A", column: "todo", githubTracking: { enabled: false } });
+    const { updateTask } = await import("../../api");
+    const mockUpdateTask = vi.mocked(updateTask);
+    mockUpdateTask.mockResolvedValueOnce({ ...taskA, githubTracking: { enabled: true } } as any);
+
+    render(
+      <TaskDetailModal
+        task={taskA}
+        onClose={() => {}}
+        onMoveTask={noopMove}
+        onDeleteTask={noopDelete}
+        onMergeTask={noopMerge}
+        onOpenDetail={noopOpenDetail}
+        onTaskUpdated={onTaskUpdated}
+        addToast={() => {}}
+      />,
+    );
+
+    await user.click(screen.getByRole("button", { name: "Enable GitHub tracking" }));
+
+    await waitFor(() => {
+      expect(onTaskUpdated).toHaveBeenCalledTimes(1);
+      expect(onTaskUpdated).toHaveBeenCalledWith(expect.objectContaining({ id: "FN-A" }));
+    });
+  });
+});

packages/dashboard/vitest.config.ts

@@ -12,7 +12,7 @@ const qualityAppTests = [
   "app/api/**/*.test.ts",
   // Representative workflow/component coverage. Exhaustive modal/view suites
   // stay available in the full `dashboard-app` project.
-  "app/components/__tests__/{ActiveAgentsPanel,ActivityLogModal,AgentMentionPopup,AgentMetricsBar,AgentReflectionsTab,AgentTokenStatsPanel,App,AuthTokenRecoveryDialog,Board,board-mobile-view-switch,ChatView,ChatView.autosize,ChatView.chat-input-autosize,ChatView.default-model-icon,ChatView.draft,ChatView.rooms,ChatView.swipe-back,Column,ConfirmDialog,ConversationHistory,DashboardLoader,DevServerView.mobile,DirectoryPicker,DuplicateWarningModal,ErrorBoundary,ExecutorStatusBar,FileBrowser,FileEditor,GitHubBadge,InlineCreateCard,LoginInstructions,MemoryView,MessageComposer,MobileNavBar,NewTaskModal,NodeCard,NodeHealthDot,NodeStatusIndicator,PrChecksList,PrCreateModal,PrCreateModal.layout,ProjectCard,ProjectSelector,ProviderIcon,PrPanel,PrPanel.merge,PrPanel.reviews,QuickChatFAB,ReliabilityView,ResearchView,SecretsView,SettingsModal,SettingsModal.worktrunk,StashRecoveryView,TaskCard,TaskCard.badge-height,TaskChangesTab,TaskComments,TaskDetailModal,TaskDetailModal.github-tracking-header,TaskDetailModal.rebind-banner,TaskDocumentsTab,TaskForm,TaskIdIntegrityBanner,TrackingRepoSelect,WorkflowResultsTab,WorktrunkInstallApprovalDetails}.test.tsx",
+  "app/components/__tests__/{ActiveAgentsPanel,ActivityLogModal,AgentMentionPopup,AgentMetricsBar,AgentReflectionsTab,AgentTokenStatsPanel,App,AuthTokenRecoveryDialog,Board,board-mobile-view-switch,ChatView,ChatView.autosize,ChatView.chat-input-autosize,ChatView.default-model-icon,ChatView.draft,ChatView.rooms,ChatView.swipe-back,Column,ConfirmDialog,ConversationHistory,DashboardLoader,DevServerView.mobile,DirectoryPicker,DuplicateWarningModal,ErrorBoundary,ExecutorStatusBar,FileBrowser,FileEditor,GitHubBadge,InlineCreateCard,LoginInstructions,MemoryView,MessageComposer,MobileNavBar,NewTaskModal,NodeCard,NodeHealthDot,NodeStatusIndicator,PrChecksList,PrCreateModal,PrCreateModal.layout,ProjectCard,ProjectSelector,ProviderIcon,PrPanel,PrPanel.merge,PrPanel.reviews,QuickChatFAB,ReliabilityView,ResearchView,SecretsView,SettingsModal,SettingsModal.worktrunk,StashRecoveryView,TaskCard,TaskCard.badge-height,TaskChangesTab,TaskComments,TaskDetailModal,TaskDetailModal.github-tracking-header,TaskDetailModal.github-tracking-stale,TaskDetailModal.rebind-banner,TaskDocumentsTab,TaskForm,TaskIdIntegrityBanner,TrackingRepoSelect,WorkflowResultsTab,WorktrunkInstallApprovalDetails}.test.tsx",
   // Hooks and utilities are fast, user-visible state/formatting behavior.
   "app/context/**/*.test.tsx",
   "app/hooks/__tests__/{useAgents,useAgentLogs,useAppSettings,useAuthOnboarding,useConfirm,useCurrentProject,useNodes,useNodeSettingsSync,useProjects,useQuickChat,useTasks,useTerminalSessions,useTheme,useToast,useUsageData,useViewState}.test.{ts,tsx}",