From abc2550cc66f94adf759e2ed6729bd350cc04dc2 Mon Sep 17 00:00:00 2001 From: gsxdsm Date: Fri, 17 Jul 2026 10:59:11 -0700 Subject: [PATCH] FN-8216: fix settings description test guard Keep the Settings default-description coverage aligned with surfaced and global-only settings. - Add missing Notifications and Scheduling description keys to the coverage map - Allowlist the global-only LAN discovery setting so the guard does not require a UI description Files changed: .../sections/__tests__/settings-default-descriptions.test.tsx | 9 +++++++++ 1 file changed, 9 insertions(+) Fusion-Task-Id: FN-8216 Fusion-Task-Lineage: a5449429-c5b2-4d88-915b-26baba3fb60b Co-authored-by: Fusion (runfusion.ai) --- .../__tests__/settings-default-descriptions.test.tsx | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/packages/dashboard/app/components/settings/sections/__tests__/settings-default-descriptions.test.tsx b/packages/dashboard/app/components/settings/sections/__tests__/settings-default-descriptions.test.tsx index d1fd40f9de..0d7f3d6606 100644 --- a/packages/dashboard/app/components/settings/sections/__tests__/settings-default-descriptions.test.tsx +++ b/packages/dashboard/app/components/settings/sections/__tests__/settings-default-descriptions.test.tsx @@ -126,6 +126,12 @@ const SETTING_DESCRIPTION_KEYS: Record = { researchGlobalLocalDocsEnabled: "researchGlobal.localDocsSourceHint", researchGlobalWebSearchProvider: "researchGlobal.searchesAndFetchesUseTheAgentsNativeWebSearch", // NotificationsSection + /* + * FNXC:SettingsDefaults 2026-07-16-10:05: + * FN-8216 classifies the NotificationsSection clarification checkbox and SchedulingSection + * duplicate-resolution select as surfaced fields: their existing help text states each default. + */ + agentClarificationEnabled: "notifications.agentClarificationHint", failureNotificationDelayMs: "notifications.howLongAFailureMustPersistBeforeA", failureNotificationMode: "notifications.stickyFailuresOnlyDefault", ntfyEnabled: "notifications.ntfyEnabledHint", @@ -214,6 +220,7 @@ const SETTING_DESCRIPTION_KEYS: Record = { autoArchiveDoneAfterMs: "scheduling.numberOfDaysATaskCanStayIn", archiveAgentLogMode: "scheduling.compactModeKeepsArchiveSizeLowWhilePreserving", autoArchiveDuplicateTasksEnabled: "scheduling.autoArchiveDuplicateTasksHelp", + triageDuplicateResolution: "scheduling.triageDuplicateResolutionHelp", maxStuckKills: "scheduling.maximumStuckDetectorRetriesBeforeATaskIs", groupOverlappingFiles: "scheduling.whenEnabledTasksThatModifyTheSameFiles", ignoreHiddenOverlapPaths: "scheduling.ignoreHiddenDotPathsHelp", @@ -281,6 +288,8 @@ const SETTING_DESCRIPTION_KEYS: Record = { /** Setting keys intentionally not surfaced as a plain Settings UI description field, with reasons. */ const NOT_SURFACED_ALLOWLIST: Record = { + // Global-only serve/dashboard LAN discovery switch; no Settings UI description field exists. + localNetworkDiscoveryEnabled: "global-only LAN discovery runtime switch", // Moved to workflow settings (U4) — see MOVED_SETTINGS_KEYS in settings-schema.ts. workflowStepTimeoutMs: "moved to workflow settings (U4)", workflowStepScopeEnforcement: "moved to workflow settings (U4)",