feat(KB-622): unify steeringComments and comments into single comments field
- Merge steeringComments and comments into unified comments field in Task type - Update TaskStore to use single comments array instead of separate steeringComments - Add database migration to convert existing steeringComments to comments - Update executor to inject all comments into AI execution context - Update dashboard SteeringTab to use unified comments API - Update CLI task steer command to use comments field - Update PR comment handler to add comments via unified API
This commit is contained in:
@@ -58,7 +58,7 @@ export function fromJson<T>(json: string | null | undefined): T | undefined {
|
||||
|
||||
// ── Schema Definition ────────────────────────────────────────────────
|
||||
|
||||
const SCHEMA_VERSION = 4;
|
||||
const SCHEMA_VERSION = 5;
|
||||
|
||||
const SCHEMA_SQL = `
|
||||
-- Tasks table with JSON columns for nested data
|
||||
@@ -333,8 +333,15 @@ export class Database {
|
||||
});
|
||||
}
|
||||
|
||||
if (version < 5) {
|
||||
this.applyMigration(5, () => {
|
||||
// Migrate steeringComments to comments (unified comments field)
|
||||
this.migrateSteeringCommentsToComments();
|
||||
});
|
||||
}
|
||||
|
||||
// Future migrations go here:
|
||||
// if (version < 3) { this.applyMigration(3, () => { ... }); }
|
||||
// if (version < 6) { this.applyMigration(6, () => { ... }); }
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -368,6 +375,60 @@ export class Database {
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Migrate steeringComments data to the unified comments field.
|
||||
* This is a one-way migration from schema version 4 to 5.
|
||||
*/
|
||||
private migrateSteeringCommentsToComments(): void {
|
||||
// Only run if steeringComments column exists
|
||||
if (!this.hasColumn("tasks", "steeringComments")) {
|
||||
return;
|
||||
}
|
||||
|
||||
// Get all tasks that have steering comments
|
||||
const tasksWithSteering = this.db
|
||||
.prepare("SELECT id, steeringComments, comments FROM tasks WHERE steeringComments != '[]'")
|
||||
.all() as Array<{ id: string; steeringComments: string; comments: string }>;
|
||||
|
||||
for (const task of tasksWithSteering) {
|
||||
try {
|
||||
const steeringComments = JSON.parse(task.steeringComments) as Array<{
|
||||
id: string;
|
||||
text: string;
|
||||
createdAt: string;
|
||||
author: "user" | "agent";
|
||||
}>;
|
||||
const existingComments = JSON.parse(task.comments || "[]") as Array<{
|
||||
id: string;
|
||||
text: string;
|
||||
author: string;
|
||||
createdAt: string;
|
||||
updatedAt?: string;
|
||||
}>;
|
||||
|
||||
// Convert steering comments to the unified format
|
||||
const migratedComments = steeringComments.map((sc) => ({
|
||||
id: sc.id,
|
||||
text: sc.text,
|
||||
author: sc.author,
|
||||
createdAt: sc.createdAt,
|
||||
updatedAt: sc.createdAt, // Steering comments didn't have updatedAt
|
||||
}));
|
||||
|
||||
// Merge: existing comments first, then migrated steering comments
|
||||
const mergedComments = [...existingComments, ...migratedComments];
|
||||
|
||||
// Update the task with merged comments
|
||||
this.db
|
||||
.prepare("UPDATE tasks SET comments = ? WHERE id = ?")
|
||||
.run(JSON.stringify(mergedComments), task.id);
|
||||
} catch {
|
||||
// Skip tasks with invalid JSON in steeringComments
|
||||
continue;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Close the database connection.
|
||||
*/
|
||||
|
||||
Reference in New Issue
Block a user