From b0c42974d0cea269dd1329264202f0a644eaebbe Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 19 Jun 2026 23:50:37 +0000 Subject: [PATCH] fix(engine): correct parameter order in runVerificationCommand after merge Reorder backend/timeoutMsOverride params so timeoutMsOverride remains at position 10 (matching callers in executor.ts, merger.ts from main). Update mission-verification.ts call sites to pass undefined for timeoutMsOverride before the isolating backend argument. --- packages/engine/src/mission-verification.ts | 2 ++ packages/engine/src/verification-utils.ts | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/engine/src/mission-verification.ts b/packages/engine/src/mission-verification.ts index ec655e0d61..17f2b3f9ad 100644 --- a/packages/engine/src/mission-verification.ts +++ b/packages/engine/src/mission-verification.ts @@ -501,6 +501,7 @@ export class TestExecutionVerificationCapability implements VerificationCapabili verifyLog, "reviewer", scrubbedEnv, + undefined, isolating, ); @@ -531,6 +532,7 @@ export class TestExecutionVerificationCapability implements VerificationCapabili verifyLog, "reviewer", scrubbedEnv, + undefined, isolating, ); diff --git a/packages/engine/src/verification-utils.ts b/packages/engine/src/verification-utils.ts index 1c9ca2a91d..64c438c752 100644 --- a/packages/engine/src/verification-utils.ts +++ b/packages/engine/src/verification-utils.ts @@ -324,14 +324,14 @@ export async function runVerificationCommand( agentLabel?: string, /** Optional extra environment variables to inject into the child process (merged over process.env). */ extraEnv?: NodeJS.ProcessEnv, + /** Optional project-level per-command timeout override in milliseconds. Values <= 0 preserve the legacy default. */ + timeoutMsOverride?: number, /** * Optional explicit sandbox backend. When omitted, the process-global backend * is resolved. Pass this to pin an isolating backend without mutating global * state (required for safe concurrent verification — see mission-verification). */ backend?: SandboxBackend, - /** Optional project-level per-command timeout override in milliseconds. Values <= 0 preserve the legacy default. */ - timeoutMsOverride?: number, ): Promise { const logger = log ?? { log: console.log, error: console.error, warn: console.warn }; const label = (agentLabel ?? "merger") as AgentRole;