chore: consolidate test files into __tests__/ dirs and clean stray engine artifacts
- Move all co-located *.test.* files into sibling __tests__/ directories so the
layout is consistent across packages (159 renames + content-rewrite moves).
Updates relative imports, vi.mock specifiers, and __dirname/import.meta.url
path resolutions where tests read fixtures from disk.
- Drop tracked tsc-emit alongside engine .ts sources (auth-storage/logger/
skill-resolver/context-limit-detector/pi.{js,d.ts,*.map}). These were
accidentally committed in a merge and the stale pi.js was masking a real
test-mock vs source mismatch (tests imported "../pi.js" and vite preferred
the stale build over pi.ts).
- Add packages/engine/.gitignore to block future src/*.{js,d.ts,map}.
- Refactor plugin pi-module seams (openclaw/paperclip/hermes) to ESM-import
createFnAgent / promptWithFallback / describeModel from @fusion/engine
instead of require()-ing packages/engine/src/pi.js. Adds @fusion/engine to
the two plugin package.jsons that were missing it; exports describeModel
from the engine public API.
- Fix engine test mocks now that they run against current pi.ts: add
ModelRegistry.create static to mocks in pi.test.ts and pi-create-fn-agent
.test.ts; switch three boundary-result toEqual assertions to toMatchObject
so the new content/isError fields don't trip exact-match comparison.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
gsxdsm
@@ -0,0 +1,273 @@
|
||||
/**
|
||||
* Runtime Selection Regression Tests
|
||||
*
|
||||
* These tests verify that engine subsystems correctly use the runtime resolution
|
||||
* system and fall back to the default pi runtime when no runtime hint is configured.
|
||||
*
|
||||
* Key behaviors tested:
|
||||
* 1. Subsystems with pluginRunner option can resolve plugin runtimes
|
||||
* 2. Subsystems without pluginRunner or hint fall back to pi runtime
|
||||
* 3. Runtime resolution logs are emitted correctly
|
||||
*/
|
||||
|
||||
import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
|
||||
|
||||
// Mock the logger to suppress output during tests
|
||||
vi.mock("../logger.js", () => ({
|
||||
createLogger: vi.fn(() => ({
|
||||
log: vi.fn(),
|
||||
warn: vi.fn(),
|
||||
error: vi.fn(),
|
||||
})),
|
||||
}));
|
||||
|
||||
// Mock pi.js to avoid actual session creation
|
||||
vi.mock("../pi.js", () => ({
|
||||
createFnAgent: vi.fn().mockResolvedValue({
|
||||
session: {
|
||||
model: { provider: "anthropic", id: "claude-sonnet-4-5" },
|
||||
prompt: vi.fn(),
|
||||
},
|
||||
sessionFile: undefined,
|
||||
}),
|
||||
promptWithFallback: vi.fn().mockResolvedValue(undefined),
|
||||
describeModel: vi.fn().mockReturnValue("anthropic/claude-sonnet-4-5"),
|
||||
}));
|
||||
|
||||
// Mock the runtime resolution module
|
||||
const mockResolveRuntime = vi.fn();
|
||||
vi.mock("../runtime-resolution.js", () => ({
|
||||
resolveRuntime: (...args: unknown[]) => mockResolveRuntime(...args),
|
||||
buildRuntimeResolutionContext: vi.fn().mockReturnValue({
|
||||
sessionPurpose: "test",
|
||||
runtimeHint: undefined,
|
||||
pluginRunner: {},
|
||||
}),
|
||||
}));
|
||||
|
||||
// Mock session skill context
|
||||
vi.mock("../session-skill-context.js", () => ({
|
||||
buildSessionSkillContext: vi.fn().mockResolvedValue({
|
||||
skillSelectionContext: undefined,
|
||||
resolvedSkillNames: [],
|
||||
skillSource: "none",
|
||||
}),
|
||||
buildSessionSkillContextSync: vi.fn().mockReturnValue({
|
||||
skillSelectionContext: undefined,
|
||||
resolvedSkillNames: [],
|
||||
skillSource: "none",
|
||||
}),
|
||||
}));
|
||||
|
||||
// Mock agent instructions
|
||||
vi.mock("../agent-instructions.js", () => ({
|
||||
resolveAgentInstructions: vi.fn().mockResolvedValue(""),
|
||||
buildSystemPromptWithInstructions: vi.fn().mockImplementation((base) => base),
|
||||
resolveAgentInstructionsWithRatings: vi.fn().mockResolvedValue(""),
|
||||
}));
|
||||
|
||||
describe("Runtime Selection Regression Tests", () => {
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks();
|
||||
|
||||
// Default: resolveRuntime returns pi runtime
|
||||
mockResolveRuntime.mockResolvedValue({
|
||||
runtime: {
|
||||
id: "pi",
|
||||
name: "Default PI Runtime",
|
||||
createSession: async () => ({
|
||||
session: {
|
||||
model: { provider: "anthropic", id: "claude-sonnet-4-5" },
|
||||
prompt: vi.fn(),
|
||||
},
|
||||
}),
|
||||
promptWithFallback: vi.fn(),
|
||||
describeModel: () => "anthropic/claude-sonnet-4-5",
|
||||
},
|
||||
wasConfigured: false,
|
||||
runtimeId: "pi",
|
||||
});
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
vi.restoreAllMocks();
|
||||
});
|
||||
|
||||
describe("createResolvedAgentSession", () => {
|
||||
it("should call resolveRuntime when creating a session", async () => {
|
||||
const { createResolvedAgentSession } = await import("../agent-session-helpers.js");
|
||||
|
||||
await createResolvedAgentSession({
|
||||
sessionPurpose: "executor",
|
||||
pluginRunner: {} as any,
|
||||
cwd: "/test/path",
|
||||
systemPrompt: "Test prompt",
|
||||
});
|
||||
|
||||
expect(mockResolveRuntime).toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("should use the resolved runtime's createSession method", async () => {
|
||||
const mockCreateSession = vi.fn().mockResolvedValue({
|
||||
session: {
|
||||
model: { provider: "test", id: "test-model" },
|
||||
},
|
||||
});
|
||||
|
||||
mockResolveRuntime.mockResolvedValue({
|
||||
runtime: {
|
||||
id: "test-runtime",
|
||||
name: "Test Runtime",
|
||||
createSession: mockCreateSession,
|
||||
promptWithFallback: vi.fn(),
|
||||
describeModel: () => "test/model",
|
||||
},
|
||||
wasConfigured: true,
|
||||
runtimeId: "test-runtime",
|
||||
});
|
||||
|
||||
const { createResolvedAgentSession } = await import("../agent-session-helpers.js");
|
||||
|
||||
await createResolvedAgentSession({
|
||||
sessionPurpose: "executor",
|
||||
pluginRunner: {} as any,
|
||||
cwd: "/test/path",
|
||||
systemPrompt: "Test prompt",
|
||||
});
|
||||
|
||||
expect(mockCreateSession).toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("should return runtime metadata along with session", async () => {
|
||||
mockResolveRuntime.mockResolvedValue({
|
||||
runtime: {
|
||||
id: "my-runtime",
|
||||
name: "My Runtime",
|
||||
createSession: async () => ({
|
||||
session: {
|
||||
model: { provider: "test", id: "test-model" },
|
||||
},
|
||||
}),
|
||||
promptWithFallback: vi.fn(),
|
||||
describeModel: () => "test/model",
|
||||
},
|
||||
wasConfigured: true,
|
||||
runtimeId: "my-runtime",
|
||||
});
|
||||
|
||||
const { createResolvedAgentSession } = await import("../agent-session-helpers.js");
|
||||
|
||||
const result = await createResolvedAgentSession({
|
||||
sessionPurpose: "triage",
|
||||
cwd: "/test/path",
|
||||
systemPrompt: "Test prompt",
|
||||
});
|
||||
|
||||
expect(result.runtimeId).toBe("my-runtime");
|
||||
expect(result.wasConfigured).toBe(true);
|
||||
});
|
||||
});
|
||||
|
||||
describe("Default pi runtime fallback", () => {
|
||||
it("should fall back to pi runtime when no runtime hint provided", async () => {
|
||||
mockResolveRuntime.mockResolvedValue({
|
||||
runtime: {
|
||||
id: "pi",
|
||||
name: "Default PI Runtime",
|
||||
createSession: async () => ({
|
||||
session: {
|
||||
model: { provider: "anthropic", id: "claude-sonnet-4-5" },
|
||||
},
|
||||
}),
|
||||
promptWithFallback: vi.fn(),
|
||||
describeModel: () => "anthropic/claude-sonnet-4-5",
|
||||
},
|
||||
wasConfigured: false,
|
||||
runtimeId: "pi",
|
||||
});
|
||||
|
||||
const { createResolvedAgentSession } = await import("../agent-session-helpers.js");
|
||||
|
||||
const result = await createResolvedAgentSession({
|
||||
sessionPurpose: "merger",
|
||||
cwd: "/test/path",
|
||||
systemPrompt: "Test prompt",
|
||||
});
|
||||
|
||||
expect(result.runtimeId).toBe("pi");
|
||||
expect(result.wasConfigured).toBe(false);
|
||||
});
|
||||
|
||||
it("should fall back to pi runtime when runtime hint references non-existent runtime", async () => {
|
||||
mockResolveRuntime.mockResolvedValue({
|
||||
runtime: {
|
||||
id: "pi",
|
||||
name: "Default PI Runtime",
|
||||
createSession: async () => ({
|
||||
session: {
|
||||
model: { provider: "anthropic", id: "claude-sonnet-4-5" },
|
||||
},
|
||||
}),
|
||||
promptWithFallback: vi.fn(),
|
||||
describeModel: () => "anthropic/claude-sonnet-4-5",
|
||||
},
|
||||
wasConfigured: false,
|
||||
runtimeId: "pi",
|
||||
});
|
||||
|
||||
const { createResolvedAgentSession } = await import("../agent-session-helpers.js");
|
||||
|
||||
const result = await createResolvedAgentSession({
|
||||
sessionPurpose: "heartbeat",
|
||||
pluginRunner: {} as any,
|
||||
runtimeHint: "non-existent-runtime",
|
||||
cwd: "/test/path",
|
||||
systemPrompt: "Test prompt",
|
||||
});
|
||||
|
||||
expect(result.runtimeId).toBe("pi");
|
||||
expect(result.wasConfigured).toBe(false);
|
||||
});
|
||||
});
|
||||
|
||||
describe("Plugin runtime selection", () => {
|
||||
it("should use configured plugin runtime when hint matches", async () => {
|
||||
mockResolveRuntime.mockResolvedValue({
|
||||
runtime: {
|
||||
id: "code-interpreter",
|
||||
name: "Code Interpreter Runtime",
|
||||
createSession: async () => ({
|
||||
session: {
|
||||
model: { provider: "custom", id: "custom-model" },
|
||||
},
|
||||
}),
|
||||
promptWithFallback: vi.fn(),
|
||||
describeModel: () => "custom/model",
|
||||
},
|
||||
wasConfigured: true,
|
||||
runtimeId: "code-interpreter",
|
||||
});
|
||||
|
||||
const { createResolvedAgentSession } = await import("../agent-session-helpers.js");
|
||||
|
||||
const result = await createResolvedAgentSession({
|
||||
sessionPurpose: "executor",
|
||||
pluginRunner: {
|
||||
getRuntimeById: vi.fn().mockReturnValue({
|
||||
pluginId: "code-plugin",
|
||||
runtime: {
|
||||
metadata: { runtimeId: "code-interpreter", name: "Code Interpreter" },
|
||||
factory: vi.fn(),
|
||||
},
|
||||
}),
|
||||
} as any,
|
||||
runtimeHint: "code-interpreter",
|
||||
cwd: "/test/path",
|
||||
systemPrompt: "Test prompt",
|
||||
});
|
||||
|
||||
expect(result.runtimeId).toBe("code-interpreter");
|
||||
expect(result.wasConfigured).toBe(true);
|
||||
});
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user