From c093f4a1e611384c45c58ec7d688ffc86f1fc8b1 Mon Sep 17 00:00:00 2001 From: gsxdsm Date: Fri, 19 Jun 2026 08:14:22 -0700 Subject: [PATCH] fix(desktop): skip native rebuild in electron-builder to unblock Windows release electron-builder's default @electron/rebuild step walked the desktop app's whole dependency tree and tried to source-build @homebridge/node-pty-prebuilt-multiarch (Node-ABI prebuilds only, none for Electron) via node-gyp, which fails on the Windows runner with "Could not find any Visual Studio installation". The app bundles no native addon needing an Electron-ABI rebuild (it uses node:sqlite; keytar/node-pty aren't in the files list and are loaded optionally), so the rebuild was pointless. Set npmRebuild: false to skip it on all platforms. Co-Authored-By: Claude Opus 4.8 (1M context) --- packages/desktop/electron-builder.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/packages/desktop/electron-builder.yml b/packages/desktop/electron-builder.yml index 94d0878f21..7237884726 100644 --- a/packages/desktop/electron-builder.yml +++ b/packages/desktop/electron-builder.yml @@ -6,6 +6,16 @@ directories: output: dist-electron buildResources: src/icons +# The desktop app bundles no native addon that needs an Electron-ABI rebuild: it +# uses Node's built-in `node:sqlite`, and the only native modules in the dependency +# tree (keytar, @homebridge/node-pty-prebuilt-multiarch via @fusion/dashboard) are +# loaded optionally and are NOT in the `files` list, so they're never packaged. +# electron-builder's default rebuild walks the whole tree and tries to source-build +# node-pty (it ships Node-ABI prebuilds only, none for Electron) via node-gyp, which +# fails on the Windows runner ("Could not find any Visual Studio installation"). +# Disabling the rebuild skips that pointless, platform-fragile compile entirely. +npmRebuild: false + files: # pnpm installs workspace/runtime deps as symlinked package entries backed by the # virtual store. These flat node_modules/X/**/* patterns only work when electron-builder