root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(FN-4893): cast fn_secret_get context fields via local alias

Browse Source 
Fusion-Task-Id: FN-4893
Fusion-Task-Lineage: 14912482-9b55-47ae-831e-03e149714d72
This commit is contained in:
Fusion (runfusion.ai)
2026-05-17 09:04:21 -07:00
committed by gsxdsm
parent 813001bc8b
commit c502820f68
1 changed files with 15 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
packages/cli/src/extension.ts
View File

@@ -1520,6 +1520,12 @@ export default function kbExtension(pi: ExtensionAPI) {
scope: Type.Optional(Type.Union([Type.Literal("project"), Type.Literal("global")], { description: "Optional scope" })), scope: Type.Optional(Type.Union([Type.Literal("project"), Type.Literal("global")], { description: "Optional scope" })),
}), }),
async execute(_toolCallId, params, _signal, _onUpdate, ctx) { async execute(_toolCallId, params, _signal, _onUpdate, ctx) {
const fnCtx = ctx as typeof ctx & {
agentId?: string;
agentName?: string;
runId?: string;
taskId?: string;
};
const store = await getStore(ctx.cwd); const store = await getStore(ctx.cwd);
const secretsStore = await store.getSecretsStore(); const secretsStore = await store.getSecretsStore();
const scopes: SecretScope[] = params.scope ? [params.scope] : ["project", "global"]; const scopes: SecretScope[] = params.scope ? [params.scope] : ["project", "global"];
@@ -1546,19 +1552,19 @@ export default function kbExtension(pi: ExtensionAPI) {
}); });
if (decision.policy === "deny") { if (decision.policy === "deny") {
emitSecretAudit(store, ctx as { runId?: string; agentId?: string; taskId?: string }, "secret:approval-denied", `${resolvedScope}:${params.key}`); emitSecretAudit(store, fnCtx, "secret:approval-denied", `${resolvedScope}:${params.key}`);
return { content: [{ type: "text", text: "Secret access denied by policy." }], details: { error: "denied", key: params.key, scope: resolvedScope, policySource: decision.source } }; return { content: [{ type: "text", text: "Secret access denied by policy." }], details: { error: "denied", key: params.key, scope: resolvedScope, policySource: decision.source } };
} }
if (decision.policy === "prompt") { if (decision.policy === "prompt") {
const { ApprovalRequestStore } = await import("@fusion/core"); const { ApprovalRequestStore } = await import("@fusion/core");
const approvalStore = new ApprovalRequestStore(store.getDatabase()); const approvalStore = new ApprovalRequestStore(store.getDatabase());
const dedupeKey = `secret-read:${resolvedScope}:${params.key}:${ctx.agentId ?? "unknown"}`; const dedupeKey = `secret-read:${resolvedScope}:${params.key}:${fnCtx.agentId ?? "unknown"}`;
const existing = approvalStore.findLatestByDedupeKey({ requesterActorId: ctx.agentId ?? "user", taskId: (ctx as { taskId?: string }).taskId, dedupeKey }); const existing = approvalStore.findLatestByDedupeKey({ requesterActorId: fnCtx.agentId ?? "user", taskId: fnCtx.taskId, dedupeKey });
const request = existing && existing.status === "pending" const request = existing && existing.status === "pending"
? existing ? existing
: approvalStore.create({ : approvalStore.create({
requester: { actorId: ctx.agentId ?? "user", actorType: "agent", actorName: ctx.agentName ?? ctx.agentId ?? "Agent" }, requester: { actorId: fnCtx.agentId ?? "user", actorType: "agent", actorName: fnCtx.agentName ?? fnCtx.agentId ?? "Agent" },
targetAction: { targetAction: {
category: "secrets_access", category: "secrets_access",
action: "read", action: "read",
@@ -1567,19 +1573,19 @@ export default function kbExtension(pi: ExtensionAPI) {
resourceId: record.id, resourceId: record.id,
context: { approvalDedupeKey: dedupeKey, key: params.key, scope: resolvedScope }, context: { approvalDedupeKey: dedupeKey, key: params.key, scope: resolvedScope },
}, },
...(ctx.runId ? { runId: ctx.runId } : {}), ...(fnCtx.runId ? { runId: fnCtx.runId } : {}),
...((ctx as { taskId?: string }).taskId ? { taskId: (ctx as { taskId?: string }).taskId } : {}), ...(fnCtx.taskId ? { taskId: fnCtx.taskId } : {}),
}); });
emitSecretAudit(store, ctx as { runId?: string; agentId?: string; taskId?: string }, "secret:approval-requested", `${resolvedScope}:${params.key}`); emitSecretAudit(store, fnCtx, "secret:approval-requested", `${resolvedScope}:${params.key}`);
return { return {
content: [{ type: "text", text: `Secret access requires approval. Request ${request.id} is pending. Approve via POST /api/approvals/:id/decision.` }], content: [{ type: "text", text: `Secret access requires approval. Request ${request.id} is pending. Approve via POST /api/approvals/:id/decision.` }],
details: { outcome: "pending_approval", approvalRequestId: request.id, key: params.key, scope: resolvedScope }, details: { outcome: "pending_approval", approvalRequestId: request.id, key: params.key, scope: resolvedScope },
}; };
} }
const revealed = await secretsStore.revealSecret(record.id, resolvedScope, { agentId: ctx.agentId ?? null }); const revealed = await secretsStore.revealSecret(record.id, resolvedScope, { agentId: fnCtx.agentId ?? null });
emitSecretAudit(store, ctx as { runId?: string; agentId?: string; taskId?: string }, "secret:read", `${resolvedScope}:${params.key}`, { key: params.key, scope: resolvedScope }); emitSecretAudit(store, fnCtx, "secret:read", `${resolvedScope}:${params.key}`, { key: params.key, scope: resolvedScope });
return { return {
content: [{ type: "text", text: `Loaded secret '${params.key}' from ${resolvedScope} scope.` }], content: [{ type: "text", text: `Loaded secret '${params.key}' from ${resolvedScope} scope.` }],
details: { key: params.key, value: revealed.plaintextValue, scope: resolvedScope }, details: { key: params.key, value: revealed.plaintextValue, scope: resolvedScope },