root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(FN-2839): add research settings section to settings modal and dashboar

Browse Source 
This merge introduces a research settings system including new resolver functions in `@fusion/core`, a dedicated ResearchView in the dashboard with a full SettingsModal integration, and corresponding TypeScript types and schemas. Comprehensive unit tests cover routing resolution, research settings,

Fusion-Task-Id: FN-2839
This commit is contained in:
Fusion
2026-04-30 19:08:15 -07:00
committed by gsxdsm
parent 1b6ee247f7
commit c553920b40
1 changed files with 39 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

79
packages/engine/src/__tests__/effective-node.test.ts
View File

@@ -2,32 +2,45 @@ import { describe, expect, it } from "vitest";
import { resolveEffectiveNode } from "../effective-node.js";
describe("resolveEffectiveNode", () => {
it("uses task override when both task and project default are set", () => {
expect(resolveEffectiveNode({ nodeId: "node-task" }, { defaultNodeId: "node-project" })).toEqual({
nodeId: "node-task",
source: "task-override",
});
});
it("uses project default when task override is not set", () => {
expect(resolveEffectiveNode({ nodeId: undefined }, { defaultNodeId: "node-project" })).toEqual({
nodeId: "node-project",
source: "project-default",
});
});
it("uses local when neither task override nor project default is set", () => {
expect(resolveEffectiveNode({ nodeId: undefined }, { defaultNodeId: undefined })).toEqual({
nodeId: undefined,
source: "local",
});
});
it("treats empty task override as unset and falls through to project default", () => {
expect(resolveEffectiveNode({ nodeId: "" }, { defaultNodeId: "node-project" })).toEqual({
nodeId: "node-project",
source: "project-default",
});
it.each([
{
name: "uses task override when both task and project default are set",
taskNodeId: "node-task",
projectDefaultNodeId: "node-project",
expected: { nodeId: "node-task", source: "task-override" as const },
},
{
name: "uses project default when task override is not set",
taskNodeId: undefined,
projectDefaultNodeId: "node-project",
expected: { nodeId: "node-project", source: "project-default" as const },
},
{
name: "uses local when neither task override nor project default is set",
taskNodeId: undefined,
projectDefaultNodeId: undefined,
expected: { nodeId: undefined, source: "local" as const },
},
{
name: "treats empty task override as unset and falls through to project default",
taskNodeId: "",
projectDefaultNodeId: "node-project",
expected: { nodeId: "node-project", source: "project-default" as const },
},
{
name: "treats empty project default as unset and falls through to local",
taskNodeId: undefined,
projectDefaultNodeId: "",
expected: { nodeId: undefined, source: "local" as const },
},
{
name: "uses local when both task and project values are empty",
taskNodeId: "",
projectDefaultNodeId: "",
expected: { nodeId: undefined, source: "local" as const },
},
])("$name", ({ taskNodeId, projectDefaultNodeId, expected }) => {
expect(resolveEffectiveNode({ nodeId: taskNodeId }, { defaultNodeId: projectDefaultNodeId })).toEqual(expected);
});
it("treats null task nodeId as unset", () => {
@@ -37,13 +50,6 @@ describe("resolveEffectiveNode", () => {
});
});
it("treats empty project default as unset and falls through to local", () => {
expect(resolveEffectiveNode({ nodeId: undefined }, { defaultNodeId: "" })).toEqual({
nodeId: undefined,
source: "local",
});
});
it("treats null project default as unset", () => {
expect(resolveEffectiveNode({ nodeId: undefined }, { defaultNodeId: null as unknown as string })).toEqual({
nodeId: undefined,
@@ -51,13 +57,6 @@ describe("resolveEffectiveNode", () => {
});
});
it("uses local when both task and project values are empty", () => {
expect(resolveEffectiveNode({ nodeId: "" }, { defaultNodeId: "" })).toEqual({
nodeId: undefined,
source: "local",
});
});
it("uses task override when set even if project default is empty", () => {
expect(resolveEffectiveNode({ nodeId: "node-task" }, { defaultNodeId: "" })).toEqual({
nodeId: "node-task",