feat(FN-2322): centralize loopback integration test gating

- Add a shared createLoopbackIntegrationTest helper that probes 127.0.0.1 binding once and caches the result
- Use the helper in webhook, websocket, and static asset integration tests to replace duplicated loopback detection logic
- Improve skip diagnostics by including a consistent skip reason and integration scope in skipped test names
This commit is contained in:
Fusion
2026-04-23 10:09:26 -07:00
committed by gsxdsm
parent 29056b412d
commit c7f7ac722a
4 changed files with 43 additions and 39 deletions

View File

@@ -1,9 +1,10 @@
import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
import { EventEmitter, once } from "node:events";
import http from "node:http";
import type { Task, TaskStore, PrInfo, IssueInfo } from "@fusion/core";
import type { Task, PrInfo, IssueInfo } from "@fusion/core";
import { createServer } from "../server.js";
import { getGitHubAppConfig } from "../github-webhooks.js";
import { createLoopbackIntegrationTest } from "./loopback-integration-test.js";
// Mock the github-webhooks module
vi.mock("../github-webhooks.js", async () => {
@@ -16,18 +17,7 @@ vi.mock("../github-webhooks.js", async () => {
const mockGetGitHubAppConfig = vi.mocked(getGitHubAppConfig);
async function detectLoopbackBinding(): Promise<boolean> {
return await new Promise((resolve) => {
const server = http.createServer();
server.once("error", () => resolve(false));
server.listen(0, "127.0.0.1", () => {
server.close(() => resolve(true));
});
});
}
const loopbackBindingAvailable = await detectLoopbackBinding();
const webhookIntegrationTest = loopbackBindingAvailable ? it : it.skip;
const webhookIntegrationTest = await createLoopbackIntegrationTest("GitHub webhook integration");
class MockStore extends EventEmitter {
private tasks = new Map<string, Task>();